Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Thu, 14 Dec 2023 13:04:48 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Roger Quadros <rogerq@kernel.org>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, shuah@kernel.org, s-vadapalli@ti.com,
        r-gunasekaran@ti.com, vigneshr@ti.com, srk@ti.com,
        horms@kernel.org, p-varis@ti.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 net-next 09/11] net: ethernet: ti: am65-cpsw-qos: Add
 Frame Preemption MAC Merge support
Message-ID: <20231214110448.lycg7yusrusbd7w2@skbuf>
References: <20231213110721.69154-1-rogerq@kernel.org>
 <20231213110721.69154-10-rogerq@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231213110721.69154-10-rogerq@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ORDOpEgJwyFYqhcgNiChs/mOm5QKZy+eD1LKJQ3N4/VT70cEWlwH2FnKDaZ+?=
 =?us-ascii?Q?Z5X/ifcdHR5wQ+ifgOlDMABmQkqshBqbVtO54Pfznw3woL6kqZ5shE9sDwnj?=
 =?us-ascii?Q?/v1ffsj9e055ONId54bzyLXQTjIhyM4HkeAIYHp6zyhMkTyc6re/lJRWDJud?=
 =?us-ascii?Q?qVgQFd0/T1SpKksiMpHYXAdmoqSBSPcAm0m3W5hYWolydzPjb5Q4ONT/iPgK?=
 =?us-ascii?Q?bFG/7TedzKYDTli9ZT5pvbec3JpmJA3GBXp5vD9BNHLMxzMgwaTMgSrlYJhR?=
 =?us-ascii?Q?MeSDxMDfIOOsePTy8f5qeIv1yi1FeRM4A4ZiljUVPDjoL7K6jyx3eFvEjxK3?=
 =?us-ascii?Q?C4m2mNQJrhKoY+5QVKnrMUyKp8WagLmY0c5ms17E5o07sSbC0DN9q3KPnG9t?=
 =?us-ascii?Q?TkEgtLamgCvPupHMrPof4hEUF9TY5xF+Sxx3diqd+47jFy5Gell9geOHNUUO?=
 =?us-ascii?Q?bXnLxNba/4m4G0xRtfDYhKCVVGfNpZOqcHzfQRtm1FAQuvEhhFHsKVtbFDU1?=
 =?us-ascii?Q?jvR56vrQnqOSmHZg1Z+AxsY2j0F/JLNrFfvLSCfIWPGwTSnGlGn6wH370V33?=
 =?us-ascii?Q?k0eZNMTJtaFMP3x+ttnqHexvCI9kLkElcvzpzuyVHLIaiE4O9j4oO/9GErYj?=
 =?us-ascii?Q?VvJnOJ8v2bJAwpHLfwmhq2/YkzjD1NQ4+Z8l1XKs0GqiFoGUDm3zo2wcb5YO?=
 =?us-ascii?Q?SEaG7pFMY4lsq/h9wtWG87GQSZd3ebkCPCIpBUf8FSt5PmzIigVboiI1l0Bd?=
 =?us-ascii?Q?vcopRSmASzirpNGgVSOPHXsXv9uuvC2QgEqvcCFvtnz6S449vjRlXi8UgoJ8?=
 =?us-ascii?Q?CypgD1AbGUDpYoXy8dB5XXb1PQ3PdH9Yoyb7uIqvOGm42RmSA+KBEFojKUay?=
 =?us-ascii?Q?WlY+OvSISbIMXVsoGUS0YWLslGijXKO18HkoKf+Za9BQELSt6SXwA/Riklr3?=
 =?us-ascii?Q?UZ+Jp6EaLe/ZygMDkfy6oxpoO/y4ECIEmoNgSaL7Y2w5o4SCCTDIxfdsrs01?=
 =?us-ascii?Q?k+2/cNE3V/JbcbFVv/HVG3LVaI4cMLQ4xGgWKGbGDVJ+/dxry+x1R3xksadQ?=
 =?us-ascii?Q?SSPNEJ0O7rdDKKtTyHwQTDPmioVyD9Y9TEnePva4FZpUiGDR19AJh9iJnVdV?=
 =?us-ascii?Q?wIptx1OQYJuMAabq5xqGRGquVS4pjhaUSu7MYcv+5P0AOdSJ70ktUCHHdYI9?=
 =?us-ascii?Q?4Bj+3xgkZa2Kg7DvO+GzqimjP/+9Be+WDFDNBPSAlxSIwi0RW0Nc1rX71CSd?=
 =?us-ascii?Q?E4DErZ6+s+HaIszOkVghQr5+Xk5QDhk8rwBzGJu6pz7xxWOckm6Fol8w9/d8?=
 =?us-ascii?Q?W3QIZ9Y8DxthvwBDz+4hJilYMSxumq8VWecuS6szyOffP7iWfxR74pzTElLs?=
 =?us-ascii?Q?WT3wnMMJwTlDWQDHiuv5RPL3vPRP5ZDMiwXI6Tr0f534xVnlcMcFj35N9cLI?=
 =?us-ascii?Q?d//rYXZ9B+Q8PJ13NUs1jczCU7b7aB88vN+TSa5kKto6uMrkgBhnGRHBcYpv?=
 =?us-ascii?Q?5/b2mFYo+MiJh3z3L0nwqHqGFUYigTJ1Mhf+zPhCexO/EI4+7cu3O2dHulfC?=
 =?us-ascii?Q?SqY8/TR1TLaVcQxe4WMLfOVsra+H2rp54zfZhl2ySGrOO6oMkdSmRQvNYRi9?=
 =?us-ascii?Q?DQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 61a80626-6485-4645-e6a5-08dbfc947eec
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 11:04:51.9968
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: whyv5tF1krCMDf1Ryk45ty0bEWGGs5ceYep1Aq35z0rl8tOLZ7d9EMRJzEgZVzpL2dhOkFrsWWM07kAJNzuptA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9070
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 14 Dec 2023 03:05:17 -0800 (PST)

On Wed, Dec 13, 2023 at 01:07:19PM +0200, Roger Quadros wrote:
> - Fix am65_cpsw_iet_get_verify_timeout_ms() to default to timeout for
>   1G link if link is inactive.
> +
> +static int am65_cpsw_set_mm(struct net_device *ndev, struct ethtool_mm_cfg *cfg,
> +			    struct netlink_ext_ack *extack)
> +{
> +	val = readl(port->port_base + AM65_CPSW_PN_REG_IET_CTRL);
> +	if (cfg->verify_enabled) {
> +		val &= ~AM65_CPSW_PN_IET_MAC_DISABLEVERIFY;
> +		/* Reset Verify state machine. Verification won't start here.
> +		 * Verification will be done once link-up.
> +		 */
> +		val |= AM65_CPSW_PN_IET_MAC_LINKFAIL;
> +	} else {
> +		val |= AM65_CPSW_PN_IET_MAC_DISABLEVERIFY;
> +		/* Clear LINKFAIL to allow verify/response packets */
> +		val &= ~AM65_CPSW_PN_IET_MAC_LINKFAIL;
> +	}
> +
> +	val &= ~AM65_CPSW_PN_IET_MAC_MAC_ADDFRAGSIZE_MASK;
> +	val |= AM65_CPSW_PN_IET_MAC_SET_ADDFRAGSIZE(add_frag_size);
> +	writel(val, port->port_base + AM65_CPSW_PN_REG_IET_CTRL);
> +
> +	/* verify_timeout_count can only be set at valid link */
> +	if (cfg->verify_time > 0)
> +		port->qos.iet.verify_time_ms = cfg->verify_time;
> +	else
> +		port->qos.iet.verify_time_ms = 10;

I don't think I understand what the check is for? The netlink policy for
ETHTOOL_A_MM_VERIFY_TIME limits the range between 1 ms and 128 ms.
How can it be 0?

> +
> +	/* enable/disable preemption based on link status */
> +	am65_cpsw_iet_commit_preemptible_tcs(port);
> +
> +	return 0;
> +}