Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5902955rdb;
        Thu, 14 Dec 2023 03:05:45 -0800 (PST)
X-Google-Smtp-Source: AGHT+IHS1+GaxPt9zBpSkzkX1rUwOTTfvrO+7xlEeZchiY6dx7o8u9a00eK2K8aiyTIKtYPLM2oS
X-Received: by 2002:a17:902:ca14:b0:1d3:5223:a3e9 with SMTP id w20-20020a170902ca1400b001d35223a3e9mr820180pld.74.1702551945711;
        Thu, 14 Dec 2023 03:05:45 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1702551945; cv=none;
        d=google.com; s=arc-20160816;
        b=AXSQP/MPbla2WMucxWp31DQiobgtEV5Pyd44QJ7b0AXG9jTAeiJyLJXGbWV/uBe1xt
         a6oOxwzYTR4O6+E1ALi/pODQrB+bDXH0z2oIvhUmz7yMi+eisO3vu+1pkaD8hmJyZOM5
         KK5IsGdJ79ecUPiiNufwS4f+TDuKbyUBc1qooeO8H6yOtIyIMAjyg6pBwMNNyynropcn
         OGlNM8wlNwpaW805fJ4tIRm94/EYwJlzMwhxydYZNHCiupDphkz8e5M28hh9/EXypKVj
         gNuuZZbSHn2r/HVZjdfEj7s6pcMD+lZwSua7zX7Lc9JpIHYygTdR+VWuQuUq8/Izay+Y
         SWiQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:mime-version:user-agent:references:in-reply-to
         :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature
         :dkim-signature:dkim-signature;
        bh=Jh37XTpPgpC2e/hQvtSi2xLMjUa4CLQ/Qc/4iU+ctz8=;
        fh=BKtipKovsCGcWnDysz6K+aSHDcfhPOHqPEDNW3phKx8=;
        b=dndIBQeqOnprnApjb0r3/Ukai2APfRZRS+dG6ZMZprYHnvJYx0nTT62vdKgIjZa3VN
         Cb0y6PRqdEq3uOX/+3W7hmRyUgc0LWTkHnN0tDZ/RbMEzVOqGHra4AcoAjCIUwkOxI5p
         /+LtZCgGRaXg0pd2/3NXfmWUQRD2nZ57t3KCjz80FsgsJfAYiJIcDwoFGN0sn5k5oaLa
         DOOjUWWUMH1qSSSj1h12dVmu1nM57gmaQ4Z6iESY9DuYUnYzS94MB0iI0P+0mP7qPe/a
         oL2LVQEilX2e1KH9d33WsRs4ujQmCXS5ujw/Ad3LQciFcPCU/8B/lbnMLoTDLuPGLN5t
         GZeQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=QhD1r8Ka;
       dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519;
       dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=Juks4PQG;
       dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=meOGCL4w;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33])
        by mx.google.com with ESMTPS id d14-20020a170902cece00b001d1db5e39adsi11318189plg.95.2023.12.14.03.05.44
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 14 Dec 2023 03:05:45 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=QhD1r8Ka;
       dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519;
       dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=Juks4PQG;
       dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=meOGCL4w;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
	by lipwig.vger.email (Postfix) with ESMTP id A7CAB8145958;
	Thu, 14 Dec 2023 03:05:42 -0800 (PST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1443924AbjLNLF2 (ORCPT
        <rfc822;aditya.jainadityajain.jain@gmail.com> + 99 others);
        Thu, 14 Dec 2023 06:05:28 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45176 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1443962AbjLNLFU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 14 Dec 2023 06:05:20 -0500
Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 790C819E;
        Thu, 14 Dec 2023 03:05:25 -0800 (PST)
Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97])
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
         key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
        (No client certificate requested)
        by smtp-out2.suse.de (Postfix) with ESMTPS id D8C701F7C5;
        Thu, 14 Dec 2023 11:05:22 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1702551923; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=Jh37XTpPgpC2e/hQvtSi2xLMjUa4CLQ/Qc/4iU+ctz8=;
        b=QhD1r8KaNEnVlUiKbnubxJCrqYOdYnKAv8yx6nfxbPiYeVXYYlr80UGEDucDxWeJFXzkv8
        Pkxjkh1GdLDme0PojFw+wITS4K1WchK83pPixo8QMJ9o4GA9Qmo1PRCCupLEVDFqbmJnGg
        jG06Cfp3tYENU3AbZlyImW6wga2oD5I=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1702551923;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=Jh37XTpPgpC2e/hQvtSi2xLMjUa4CLQ/Qc/4iU+ctz8=;
        b=1BL54thYGVy/fgg4y0NQVekCcFPlpbPdyE9DB7zb3UCRlfSxSPruU2LNHqSz0SH2jZtRVH
        /wJ0XhtpEJ6peXAg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1702551922; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=Jh37XTpPgpC2e/hQvtSi2xLMjUa4CLQ/Qc/4iU+ctz8=;
        b=Juks4PQGiBnzKLV4rBuaIEt83E+4s01zPghD6/57nHXY7Oua5zbFkmd/9sAn9M/MxC4I49
        QoZdlm1TDbX5Z1Hh7j1jXAq6xdqxTSoMR5kSlklVXygG1TZ+Uf0TmJE3Qd/JdzRzbTGlvo
        UlflqhTW0enE4d7+iQ0zm0vs1Q+mmSs=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1702551922;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=Jh37XTpPgpC2e/hQvtSi2xLMjUa4CLQ/Qc/4iU+ctz8=;
        b=meOGCL4wEyUo5NiQk+oYjFsoFTlUC4kJOvFwXFflJLRe6nllAqXyaDBaMc2wfzutE9nikp
        zT9OWayuyFk2ODDg==
Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
         key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
        (No client certificate requested)
        by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8F8D1137E8;
        Thu, 14 Dec 2023 11:05:22 +0000 (UTC)
Received: from dovecot-director2.suse.de ([10.150.64.162])
        by imap1.dmz-prg2.suse.org with ESMTPSA
        id f8eRIXLhemUwZwAAD6G6ig
        (envelope-from <tiwai@suse.de>); Thu, 14 Dec 2023 11:05:22 +0000
Date:   Thu, 14 Dec 2023 12:05:22 +0100
Message-ID: <87cyv9qc25.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Gergo Koteles <soyer@irl.hu>
Cc:     Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
        Baojun Xu <baojun.xu@ti.com>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, linux-kernel@vger.kernel.org,
        alsa-devel@alsa-project.org, stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/tas2781: reset the amp before component_add
In-Reply-To: <4d23bf58558e23ee8097de01f70f1eb8d9de2d15.1702511246.git.soyer@irl.hu>
References: <4d23bf58558e23ee8097de01f70f1eb8d9de2d15.1702511246.git.soyer@irl.hu>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
X-Spam-Score: -1.76
X-Spam-Level: 
X-Spam-Score: -1.87
X-Spam-Level: 
Authentication-Results: smtp-out2.suse.de;
        none
X-Spamd-Result: default: False [-1.87 / 50.00];
         ARC_NA(0.00)[];
         RCVD_VIA_SMTP_AUTH(0.00)[];
         FROM_HAS_DN(0.00)[];
         TO_DN_SOME(0.00)[];
         TO_MATCH_ENVRCPT_ALL(0.00)[];
         MIME_GOOD(-0.10)[text/plain];
         RCVD_COUNT_THREE(0.00)[3];
         DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];
         RCPT_COUNT_SEVEN(0.00)[9];
         MID_CONTAINS_FROM(1.00)[];
         DBL_BLOCKED_OPENRESOLVER(0.00)[irl.hu:email];
         FUZZY_BLOCKED(0.00)[rspamd.com];
         FROM_EQ_ENVFROM(0.00)[];
         MIME_TRACE(0.00)[0:+];
         RCVD_TLS_ALL(0.00)[];
         BAYES_HAM(-2.77)[98.99%]
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 14 Dec 2023 03:05:42 -0800 (PST)

On Thu, 14 Dec 2023 00:49:20 +0100,
Gergo Koteles wrote:
> 
> Calling component_add starts loading the firmware, the callback function
> writes the program to the amplifiers. If the module resets the
> amplifiers after component_add, it happens that one of the amplifiers
> does not work because the reset and program writing are interleaving.
> 
> Call tas2781_reset before component_add to ensure reliable
> initialization.
> 
> Fixes: 5be27f1e3ec9 ("ALSA: hda/tas2781: Add tas2781 HDA driver")
> CC: stable@vger.kernel.org
> Signed-off-by: Gergo Koteles <soyer@irl.hu>

Thanks, applied now.


Takashi