Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Thu, 14 Dec 2023 13:06:48 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Roger Quadros <rogerq@kernel.org>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, shuah@kernel.org, s-vadapalli@ti.com,
        r-gunasekaran@ti.com, vigneshr@ti.com, srk@ti.com,
        horms@kernel.org, p-varis@ti.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 net-next 08/11] net: ethernet: ti: am65-cpsw: add
 mqprio qdisc offload in channel mode
Message-ID: <20231214110648.n7rz2i7qobikavtp@skbuf>
References: <20231213110721.69154-1-rogerq@kernel.org>
 <20231213110721.69154-1-rogerq@kernel.org>
 <20231213110721.69154-9-rogerq@kernel.org>
 <20231213110721.69154-9-rogerq@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231213110721.69154-9-rogerq@kernel.org>
 <20231213110721.69154-9-rogerq@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?y8+UQ6wjompOJBrGwsb8FYPOl6sK6O+BziZ5X3MTA0gL9n29llkILd0KQpwp?=
 =?us-ascii?Q?nnEg4Enn+BmQxQwn3jDSfDeQt7YEaofDgibEkmzdT/7gYuMFiHRlKIhi8BoP?=
 =?us-ascii?Q?VgZuQdNpVink/LLStHIAHwxlNdjrQVHrUqBIbgwDJJ8o6lhcnlkXCQr95cRi?=
 =?us-ascii?Q?V/jxksfqqaQGzyiMDqqZjM82aqevAb+Jn2SaY/LsrPZRo0wiVbfbtXa9CkC4?=
 =?us-ascii?Q?YO8+CRg03LvcQGtX2c3Idou17ZqcgHOkCKQV6iVirGJkbRRM+kNoLyfuwowH?=
 =?us-ascii?Q?d4tDpHtw4cvNCNthK39aATdPvSYUjBEhDxrv5cO+GtRCwQulRMpkJBjqEN+Q?=
 =?us-ascii?Q?YF6RZR/nw9hzodw7w092dHWjBCospfImYwDLCNFlQ4yTJ2WChEU4pVqRt+2m?=
 =?us-ascii?Q?K2i+Y2bQGn4VxIF5Ajvvenx6ftyUUIjOfHC58EA8OSPz65GPubc8qPabESjH?=
 =?us-ascii?Q?oFapsfXXjmWf+vHoYTpYYV6y3t+XSWdeuinmRVoew6ccMk9wmYeMWw03wng/?=
 =?us-ascii?Q?Lv7eHA8o/htJHa2heABYVQRVedJFNXsFaKcSqkfakUvnSztnMR0K6RjegfRs?=
 =?us-ascii?Q?e/jjScZl320mGg3XruhtiDSKowLYhHQrlRqIeedm1lVvvwoiI6qwE2RTjDat?=
 =?us-ascii?Q?T0bF4CRc4ed1LWUCcGc1mFYecV/1B4hGY/xeJBVDRvaLQoQ6NNpVYuQykr9w?=
 =?us-ascii?Q?p1fDmEq7ZsENkegIMpmvN736AU0eHIwHSYiRxcYFlZUadVuvLsnmpaMuUdcr?=
 =?us-ascii?Q?pSpiholRTJ2onVCj4yu0Nk+JVA9P9L+yNgR3cz2r+E7gp/F+F3PjEflq1hZR?=
 =?us-ascii?Q?TwNJ++RZ9M0xosuLOlVb38H4Be4NkwwqgaY3+BH90VnzLCnekBmuZIaFiLnl?=
 =?us-ascii?Q?yMoei28L+Vfq51sdHWucA9POYB2Vfnr1UZhH/JfIuBxYp1DDHophsOhCHQAe?=
 =?us-ascii?Q?f0p1bhph4rlD4an4ZwHw4AoSjFT5r1a3LD/kbdmEDvQmuhnOjrm+mpHVlytD?=
 =?us-ascii?Q?jx2wj6DDuR8TnREOqFktancQYXQIfmxoNNkxjUPkdplHWfgDCLRA9gPJqLE3?=
 =?us-ascii?Q?cNbUt78RZd++5cvRDhWB35AyqNXmJCUgz56Ya0Kl+YlhMjdYE4fSUKUoMvxP?=
 =?us-ascii?Q?fJQJxMCvVqAllQBn0JKWsV9VvQ31OuKWCZYcTf7U+DXj4ePuHBRmUVChHjkz?=
 =?us-ascii?Q?Zn99y9tpCNXShNBQQWsopSYtOJuCb7WLedWTVBdtSPHIt+ytP32Jg80ArQUe?=
 =?us-ascii?Q?F2Rdy8boeu6w2muJEyr7yU+cESIME9DQAhnQ6oRub8ynl+w4ng2N9bgg1NAs?=
 =?us-ascii?Q?/MaG960/PnWh1sK0jVLMKsDXp1DYn7JKwmkOsjKatzkJzQJ3WKLThudqYUmQ?=
 =?us-ascii?Q?4wvT+8JD0PiHPCPXj5hr2IcGOruMFdvP1rzBiVloER+8qmICOY+Qg1JPEnie?=
 =?us-ascii?Q?PHeJ9/UzlkwSOekrJSyNHToo7bNSE9l8TzYrQkZSId4n88MvB6p8zBchYTaq?=
 =?us-ascii?Q?2IhVxHgYHMq5BjYY3sWDsn/aGLKRUlqgZ+JdhtGnaurq3vNcpZ7ti9XiB8Oc?=
 =?us-ascii?Q?aAmNcbLlpnyKZZb0Zj3WT8TSlurV1ZAU9Da44vyd6nuogdxcr8I7JMlduARB?=
 =?us-ascii?Q?jw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa51e1de-7c5e-42c0-25b1-08dbfc94c695
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 11:06:52.1393
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wUXsB1p5lfSx7FI3VEnVh4wr74EFFfPlgJ+F+A8YyGDAqKsD5+U1RLnAoCGBhsH2ulKxI//Wr/c0vJyXyUJL7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9070
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 14 Dec 2023 03:07:23 -0800 (PST)

On Wed, Dec 13, 2023 at 01:07:18PM +0200, Roger Quadros wrote:
> +	for (i = num_tc - 1; i >= 0; i--) {
> +		u32 ch_msk;
> +
> +		if (mqprio->min_rate[i])
> +			min_rate_msk |= BIT(i);
> +		min_rate_total +=  mqprio->min_rate[i];
> +
> +		if (has_max_rate) {
> +			if (mqprio->max_rate[i])
> +				max_rate_msk |= BIT(i);
> +			max_rate_total +=  mqprio->max_rate[i];
> +
> +			if (!mqprio->min_rate[i] && mqprio->max_rate[i]) {
> +				NL_SET_ERR_MSG_FMT_MOD(extack,
> +						       "TX tc%d rate max>0 but min=0\n",
> +						       i);
> +				return -EINVAL;
> +			}
> +
> +			if (mqprio->max_rate[i] &&
> +			    mqprio->max_rate[i] < mqprio->min_rate[i]) {
> +				NL_SET_ERR_MSG_FMT_MOD(extack,
> +						       "TX tc%d rate min(%llu)>max(%llu)\n",
> +						       i, mqprio->min_rate[i],
> +						       mqprio->max_rate[i]);
> +				return -EINVAL;
> +			}
> +		}
> +
> +		ch_msk = GENMASK(num_tc - 1, i);
> +		if ((min_rate_msk & BIT(i)) && (min_rate_msk ^ ch_msk)) {
> +			NL_SET_ERR_MSG_FMT_MOD(extack,
> +					       "Min rate must be set sequentially hi->lo tx_rate_msk%x\n",
> +					       min_rate_msk);
> +			return -EINVAL;
> +		}
> +
> +		if ((max_rate_msk & BIT(i)) && (max_rate_msk ^ ch_msk)) {
> +			NL_SET_ERR_MSG_FMT_MOD(extack,
> +					       "Max rate must be set sequentially hi->lo tx_rate_msk%x\n",
> +					       max_rate_msk);
> +			return -EINVAL;
> +		}
> +	}

Netlink extack strings don't need \n at the end.