Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Thu, 14 Dec 2023 13:09:54 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Roger Quadros <rogerq@kernel.org>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, shuah@kernel.org, s-vadapalli@ti.com,
        r-gunasekaran@ti.com, vigneshr@ti.com, srk@ti.com,
        horms@kernel.org, p-varis@ti.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 net-next 06/11] net: ethernet: ti: am65-cpsw: Move
 code to avoid forward declaration
Message-ID: <20231214110954.mn5kx4wrvciuk2hi@skbuf>
References: <20231213110721.69154-1-rogerq@kernel.org>
 <20231213110721.69154-1-rogerq@kernel.org>
 <20231213110721.69154-7-rogerq@kernel.org>
 <20231213110721.69154-7-rogerq@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231213110721.69154-7-rogerq@kernel.org>
 <20231213110721.69154-7-rogerq@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yfRoiW8Hft+HQi6thEDTYyJBW0YInGrZHO/T+UCSJJJDMKtK9nQfiuMvEfGQ?=
 =?us-ascii?Q?Cf3w6sqicDDx1XvlfFO7d0MYi17f9Jee9mHZ0wZn0NQLZ6WbosmSem5JGliR?=
 =?us-ascii?Q?Tw0hsAIUsGLigiRlC9r44BSkF1l+pf4yfmK7x/yssYjXcRJAv5x08AhwCeJb?=
 =?us-ascii?Q?G03r3vd0Xm37ikVF2mWCG9S5lNBpin9ZaFSS+JXgqUOilZaWUn+3ALFz3DuT?=
 =?us-ascii?Q?4YV5K2hpYpJQLuWuXaFrxwdlFWzfsMU/jiTFJwEDfYVcS5HjZh1D6ukQvbCI?=
 =?us-ascii?Q?etPibDG6PhRURohIp8SyPl8WEIHFpEHdWMFQVRJVCo29E04lSTPPre8vLW5k?=
 =?us-ascii?Q?+eGrsKs43NA383PuAXgWfkIUvr6DweeLxNic5WDfXbIeaPSMZafYTyr9gzrA?=
 =?us-ascii?Q?ltTSBMYGC/ULdN2Knmt+JM03Qbx3rmU0rGCnENcR47F+E6wwF/guRt02O9L6?=
 =?us-ascii?Q?ygx8y6zre8JdIFlJMVm5CxKagZfu6oqVjejfQKkgdjkE0aC0AAKy7usBx2U0?=
 =?us-ascii?Q?/HewzgdkuP8so7ggqd0sI0NOeY54zZHUKYDTuzRd1m+ZdyvofAjENMhN5WlI?=
 =?us-ascii?Q?h1N0IEN7czvjYT+ksx2L+NYuTHc0vDDJpwws+6ObrkOCo9SoCencoqU5PNIU?=
 =?us-ascii?Q?C77JF4plHqUcONAZ2gNj7exXYwktj7QjVILxtuaQHc63cY8e3doGC2eD4FQu?=
 =?us-ascii?Q?MIlrg4lR8CQOri1yjQeP68GNa8GN04BICIHAr3MqwG400XrOjVz8wiFQdVqZ?=
 =?us-ascii?Q?Esv7HstQwtw0KmywQyB+XaMkg9Lef5jM2vc8y7E76wkxL7MvhWMFhDJZnWfY?=
 =?us-ascii?Q?IxwI9NrmgxR5W5ZctEiq9yOVhlhkIIpcsm9uRjGoV22NPbuFa0qo7LjMNpVD?=
 =?us-ascii?Q?5L42Xs0WdqSrahxeoqh53g9tDVQ88fi/DhA1NR75Bvu971W7FQnOm0EgiXtP?=
 =?us-ascii?Q?8cZ+miPscvYW00fgv9yhgVrdbQ/ejX5LhGJ5wP1Vx9FO52It+g5peFEWCfAC?=
 =?us-ascii?Q?4A9lh0H2cRn6zwWcoUtEq8eJGnMX+eddHCXGIqhA/DBA4bgl+/lN4D50yAdM?=
 =?us-ascii?Q?T7/3bYWvLOhtCUpM+JZ3K1LoksnckhbZWJtPbev6rv+fQakcAj/xZ7cxI33s?=
 =?us-ascii?Q?1fbz11VQBh2YWoJZ3KkEjVGsMlMJEOksIjKzrzX5fJgl8IRZyVRE9QmnZCSN?=
 =?us-ascii?Q?YnkRc/4VB+jz+8LcGGJzDQcDqKx5eZ0DI1rKKQ/SVIP699rlr6yM7PeVmvVO?=
 =?us-ascii?Q?FHxuScOLaxOJrmgK9UKDD2oo0ZXd+S/R8olOGu816K3Pmy9VD2Ptt3EC6RV+?=
 =?us-ascii?Q?uH+q6kGpRnsRIX+cagkZY12wbGOmeFDPyHoJ2GPGBMMsT05mFPkpJqeil3gP?=
 =?us-ascii?Q?ikezXRu7Qzuoo52G6Xv1t2j5MQ3j1E20sa60egLcqO7t+R9Er51SCra5uABG?=
 =?us-ascii?Q?sTocpHEKsFPn/mN6c/jnu392QfwUAdFtzpNlxQXcS4Joo/ivtxLi3URyRSRz?=
 =?us-ascii?Q?8JBC3Gogu9jTf9qaWeD7qvtioDrwV5Lkp+g4LoTz0J6WOsc5kw40qjftEHzJ?=
 =?us-ascii?Q?8hDIoqobFKEOGLAxombBINalAsxdLqc9NsuMuATSURc1qigh/+Y5mfUdiv8Q?=
 =?us-ascii?Q?cQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7985950f-0cd8-4ffb-8547-08dbfc95355d
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 11:09:58.0185
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bJpNAgVmAs1cEbw5eDzA/UEc06ONOG8a1ti5H2DTlfuSNgztNJK+Dmn17Jz/h8VAl2hsVZxqYFHuhVzL8H7wqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7273
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 14 Dec 2023 03:10:07 -0800 (PST)

On Wed, Dec 13, 2023 at 01:07:16PM +0200, Roger Quadros wrote:
> Move this code to the end to avoid forward declaration.
> No functional change.

It's no longer all being moved to the end - see qox_tx_rate_calc().

> 
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>