Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Thu, 14 Dec 2023 13:23:52 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Roger Quadros <rogerq@kernel.org>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, shuah@kernel.org, s-vadapalli@ti.com,
        r-gunasekaran@ti.com, vigneshr@ti.com, srk@ti.com,
        horms@kernel.org, p-varis@ti.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 net-next 05/11] net: ethernet: am65-cpsw: cleanup
 TAPRIO handling
Message-ID: <20231214112352.iaomw3apleewkdfz@skbuf>
References: <20231213110721.69154-1-rogerq@kernel.org>
 <20231213110721.69154-6-rogerq@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231213110721.69154-6-rogerq@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4akb4KMQiX44jxnsQi6PtvO0HnjLihboiBfxmwmiYqUTJgs0v+35Ie/dq60S?=
 =?us-ascii?Q?Sshc/J39ug9bMtVFOkav7XuNeUNjJn7EzZ2fVaI9iGXbcaC2EQcdwhzketwt?=
 =?us-ascii?Q?Bnss3HKdAj30V56xlrdMKoGiEwQMLM5FV027oUeT+ntGlQE8RV2Wy14wDuVy?=
 =?us-ascii?Q?RM2zYVxiNY0Jn2sa3/npIgu/uC+Cg+Y55S/bd2FfO1+5Abig0E8QBMfe7/UD?=
 =?us-ascii?Q?Y/PW5GaVzNAnzQ5ylZIewWUXhkAt+OSB3jRrJNWZQjg8ZJwSWAwJqchdBYQG?=
 =?us-ascii?Q?ztPkTqgF5R3ISYPSfFfzw1ibBPR4OKX8ZANu2LyxOlJF1ysHwbis4Zm3h5oB?=
 =?us-ascii?Q?wJ1mLP9gq6zOP0nz8PkAYNZyJTQbP7MOA7mlTqyuCu7muaVI2PKzTTBar6y6?=
 =?us-ascii?Q?fx9YWsiFj3E1lSjOa73/AzrQGc6n/kTUvKwFKPaxs4eBBMrF6DbjPiW0ktBo?=
 =?us-ascii?Q?Dbjm7UhVLWwzlmahgDvD5z1OX6xOfSwf4K77X8zTn76tzvpo50TRpiQgz2xP?=
 =?us-ascii?Q?MCwJuZWpchSCasSYlk0uAVOpm+EXH6qnl5vwwFTUvWZ+1v1T0aUbzWLiJ8e3?=
 =?us-ascii?Q?N2PBkUV/wFXoAjWRUxSDiDlqo3JgNgJWlLkkAUkRETTVK2vOpMqDXAPd/Lmy?=
 =?us-ascii?Q?c3/33rOq5zgWTgpwe+yIva3fPrfcWLxh9pNjWwweOaD0U7bml00wmoDH/zTu?=
 =?us-ascii?Q?tV4rG5HH8fdZO92A2lOjK2cF1caqvqItsG8rOsJCC50Pq1DC2ecL5EKrgKI2?=
 =?us-ascii?Q?7Ihg7yMWQGlJeytuScdCkPWkPa5Y1p11EQb+SHr36Jc9b5S1HwjDqEvqQ1Dm?=
 =?us-ascii?Q?f29fvLeslxUQEIkXHlMKnd79/VGyX5VrklsmeLnYpOM1BTkEMiy9um8WGkr/?=
 =?us-ascii?Q?zHPYdU8lrWo7EMtxP4gJNaYIib4Qs0YN5Ehy4N4vGPHBbLeS43bPHZ+7dkWU?=
 =?us-ascii?Q?+Kk4t0fTuXbQcC2Awx5tRgU+W8OI646lhVR63eKla7YNd9kuXENcm8rtxc/+?=
 =?us-ascii?Q?xcjTHwRJWK/AVEoaj4OSgW4pcrOGWa58moVptWADd3upjQf8xs2oySpPidDN?=
 =?us-ascii?Q?vWU9G2rWFg0BLzrfdNWOQ669NiEzXzTWGGbvyfcE/OKHJo+/ZB2wgGKfdgCL?=
 =?us-ascii?Q?4Y+hK1HOt+awmYHGpgh5WJtZRxkiA9Y2u38Oa4Fc/IO5hnCB/9is5xplz32r?=
 =?us-ascii?Q?pU6jmsRVbvcqmCBuHcTwVgxF5i91FqHMlHqBmTmSEHBY6LxSGqYOmOf9v+LM?=
 =?us-ascii?Q?arTNYSwxBmd3yCWRZtyGpwvE6vBofTEpxLeoE0dll3EVBirex/GxcOJjWzaA?=
 =?us-ascii?Q?rQx60/dZl8PtxEBGRi9m1XtohrqIZz7PeILklHawpU5bX/7CIwRjq68npb34?=
 =?us-ascii?Q?Sw08Jt+pef9akLX2FtnkGt3ICaTu8JmuWdP7lvbbQMAtIb02ZSMscr/enAT7?=
 =?us-ascii?Q?PFPJ6KfuvSizlGoN3dBfR/h5FgTVIIbCuBJwJDJyQXTSD7LxV+KBSuE2t23w?=
 =?us-ascii?Q?ELSbgTB+9veZcPjkgyZCgufbyZ7pGpvPGW8uGpLgt2zydl69IQlzCu4X8fcH?=
 =?us-ascii?Q?XhEbhFvZkPakBD150BLy0klsx6PZi5Xqiosw5bPrygsvtI1w5fS+LH017L11?=
 =?us-ascii?Q?lw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e539d8ad-ccd8-48ff-af5b-08dbfc97292d
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 11:23:56.5654
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wt4Oyr32cQuw9l20/S6HzWcpkkkBlEhER3l05+gbObxAWKnuRdCDGyteqwUzs78cuFHk+jr4/knALheQD8aMOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9333
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 14 Dec 2023 03:24:23 -0800 (PST)

On Wed, Dec 13, 2023 at 01:07:15PM +0200, Roger Quadros wrote:
> +static int am65_cpsw_taprio_replace(struct net_device *ndev,
> +				    struct tc_taprio_qopt_offload *taprio)
>  {
>  	struct am65_cpsw_common *common = am65_ndev_to_common(ndev);
> +	struct netlink_ext_ack *extack = taprio->mqprio.extack;
> +	struct am65_cpsw_port *port = am65_ndev_to_port(ndev);
>  	struct am65_cpts *cpts = common->cpts;
> -	int ret = 0, tact = TACT_PROG;
> +	struct am65_cpsw_est *est_new;
> +	int ret, tact;
>  
> -	am65_cpsw_est_update_state(ndev);
> +	if (!netif_running(ndev)) {
> +		NL_SET_ERR_MSG_MOD(extack, "interface is down, link speed unknown");
> +		return -ENETDOWN;
> +	}

I haven't used the runtime PM API that this driver uses. I don't know
much about how it works. What are the rules here? By checking for
netif_running(), are you intending to rely on the pm_runtime_resume_and_get()
call from ndo_open(), which is released with pm_runtime_put() at
ndo_stop() time?

I see some inconsistencies I don't quite understand.

am65_cpsw_nuss_ndo_slave_add_vid() checks for netif_running() then calls
pm_runtime_resume_and_get() anyway.

am65_cpsw_setup_mqprio() allows changing the offload even when the link
is down (which is more user-friendly anyway) and performs the pm_runtime_get_sync()
call itself.

> -}