Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5918527rdb; Thu, 14 Dec 2023 03:37:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IH0jLZOj4y77qFDYhhZYW1u4VR17hNIZMoVDYhKEo07HFX5nIiCPZ2+Yp55+Qbq0KPJ3nsR X-Received: by 2002:a05:6870:b6a5:b0:203:4659:ccd8 with SMTP id cy37-20020a056870b6a500b002034659ccd8mr1390505oab.85.1702553845202; Thu, 14 Dec 2023 03:37:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702553845; cv=none; d=google.com; s=arc-20160816; b=IMRy/Qz0uokGigEV7oqUywBZ4RFV1BpCBBNH0GXGWseH4cZjucejY6bhnVhBJppDO2 OrdjXAg5PWozzm8G5SDgeyQa56qs0FAhN/f6O3OSQNNkEmGQ/t1Gem+u3JidheXWjSOl VEHlSbBvyGp7kcP5hA0VAcI6P4Tn+IssU8KaXn1eXOPTJeV/hQxediGzHTY5w7ZjeqsK 3jJVCt84Gi/7TkEwg6FNOWYDsJnbPWMmQv/OYujZ9bvSiF5zsWkHz2scBiIi5LHmRLiq iIxFWEC9VjGmE7+mwDXLdDrJXUvrmAphzrl86ejCCCyNEXLVUy/DIzWR8GWAqQhb411c 2Rgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=MNzWbbwSPO/91tdRqHKeLJpepiQEE/7IoOmUKM/utug=; fh=V3EXrfhtPXQ8VZs+995Yo8T+zOpBnshrD4ANVkhZrjM=; b=ef1ozpxCYNdjNjYWBvrYCYFhgyoXx08zlZCb8rMu4MpzO49XcXptiT/LnkVxb45dpn DV37E/bXXWbl21v3IrdKm0q2RPQphEIW7leVeFaTmmmsru38z9XCXBmz673Ikq/IXShx RVnNKcbMUgwiDr5ijl0MXgJN7IifB+DB2iB/2KFqI5irrwsPDk3but6V63XQIYhZ5rsh Q5XmtuCZRnx1/MgMbBoAjukmdsGOV/N0hCqmBY7bTUgNK2BnCllWk2+TzF8pjW7v5psK LKnJfC2OJ/wfA7nVAsXZPNvctd/+3Nul429HmUlZXQt4ymANnHwHqSDshr1sD7+B9UZA nMqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id y3-20020a056a001c8300b006ce4050b6b6si10959476pfw.39.2023.12.14.03.37.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 03:37:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 1FB73802796C; Thu, 14 Dec 2023 03:37:23 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1444073AbjLNLhF (ORCPT + 99 others); Thu, 14 Dec 2023 06:37:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1444027AbjLNLgx (ORCPT ); Thu, 14 Dec 2023 06:36:53 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 76FB411D for ; Thu, 14 Dec 2023 03:36:59 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B69A3C15; Thu, 14 Dec 2023 03:37:44 -0800 (PST) Received: from [10.1.197.60] (eglon.cambridge.arm.com [10.1.197.60]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8429D3F738; Thu, 14 Dec 2023 03:36:56 -0800 (PST) Message-ID: Date: Thu, 14 Dec 2023 11:36:50 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v7 10/24] x86/resctrl: Allocate the cleanest CLOSID by searching closid_num_dirty_rmid Content-Language: en-GB To: Reinette Chatre , x86@kernel.org, linux-kernel@vger.kernel.org Cc: Fenghua Yu , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , Babu Moger , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com References: <20231025180345.28061-1-james.morse@arm.com> <20231025180345.28061-11-james.morse@arm.com> From: James Morse In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 14 Dec 2023 03:37:24 -0800 (PST) On 09/11/2023 17:46, Reinette Chatre wrote: > Hi James, > > On 10/25/2023 11:03 AM, James Morse wrote: >> MPAM's PMG bits extend its PARTID space, meaning the same PMG value can be >> used for different control groups. >> >> This means once a CLOSID is allocated, all its monitoring ids may still be >> dirty, and held in limbo. >> >> Instead of allocating the first free CLOSID, on architectures where >> CONFIG_RESCTRL_RMID_DEPENDS_ON_CLOSID is enabled, search >> closid_num_dirty_rmid[] to find the cleanest CLOSID. >> >> The CLOSID found is returned to closid_alloc() for the free list >> to be updated. >> >> Tested-by: Shaopeng Tan >> Tested-by: Peter Newman >> Reviewed-by: Shaopeng Tan >> Reviewed-by: Reinette Chatre >> Signed-off-by: James Morse >> --- >> Changes since v4: >> * Dropped stale section from comment >> >> Changes since v5: >> * Renamed some variables. >> >> No changes since v6 > > I use these patch changelogs to determine if I need to look at a > patch for which I already provided a review tag. At first this > patch appears to not deserve a second glance because I already provided a > review tag and the above states "No changes since v6". Unfortunately > this is false. I counted four changes. Now I cannot trust these > "No changes since v6" and I need to dig out v6 to diff patches I already > reviewed to determine if I need to look at them again. False patch > changelogs make a patch series harder to review. Sorry, looks like I applied the changes suggested by Babu, but didn't update this bit of text that doesn't get committed. I added this 'No changes' text to any patch that didn't have any entries. You should be able to rely on people dropping Reviewed-by tags if there are substantial changes. This is the normal threshold for re-reviewing a patch. James