Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <f3538c30-3c74-5106-66f4-1e2cbe7780bf@arm.com>
Date:   Thu, 14 Dec 2023 11:38:16 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v7 19/24] x86/resctrl: Add helpers for system wide
 mon/alloc capable
Content-Language: en-GB
To:     babu.moger@amd.com, x86@kernel.org, linux-kernel@vger.kernel.org
Cc:     Fenghua Yu <fenghua.yu@intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        shameerali.kolothum.thodi@huawei.com,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        carl@os.amperecomputing.com, lcherian@marvell.com,
        bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com,
        baolin.wang@linux.alibaba.com, Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, peternewman@google.com,
        dfustini@baylibre.com, amitsinght@marvell.com
References: <20231025180345.28061-1-james.morse@arm.com>
 <20231025180345.28061-20-james.morse@arm.com>
 <5e3cc44f-5492-4dc0-a585-b58caa1e27d4@amd.com>
From:   James Morse <james.morse@arm.com>
In-Reply-To: <5e3cc44f-5492-4dc0-a585-b58caa1e27d4@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Babu,

On 09/11/2023 20:51, Moger, Babu wrote:
> Thought you are replacing all rdt_mon_capable with
> resctrl_arch_mon_capable. But, you missed few.
> 
> 1 rdtgroup.c rdt_get_tree             2640 if (rdt_mon_capable)
> 2 rdtgroup.c mkdir_rdt_prepare        3420 if (rdt_mon_capable)
> 
> Any reason these are not replaced?

Nope,
These were added in tip, which I rebased on to in order to post this late, but didn't have
the time to retest the ~100 other patches (mostly MPAM driver) that sit on top of this.
x86 was quite happy without these. (There are too many moving parts!)

- thanks for catching these.


Thanks,

James