Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <dbecf6f1-4d51-c61d-a092-a85f9ab464ea@arm.com>
Date:   Thu, 14 Dec 2023 11:38:22 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v7 20/24] x86/resctrl: Add CPU online callback for resctrl
 work
Content-Language: en-GB
To:     babu.moger@amd.com, x86@kernel.org, linux-kernel@vger.kernel.org
Cc:     Fenghua Yu <fenghua.yu@intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        shameerali.kolothum.thodi@huawei.com,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        carl@os.amperecomputing.com, lcherian@marvell.com,
        bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com,
        baolin.wang@linux.alibaba.com, Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, peternewman@google.com,
        dfustini@baylibre.com, amitsinght@marvell.com
References: <20231025180345.28061-1-james.morse@arm.com>
 <20231025180345.28061-21-james.morse@arm.com>
 <a8725d37-e3f5-4fd4-a426-b03b143a3b26@amd.com>
From:   James Morse <james.morse@arm.com>
In-Reply-To: <a8725d37-e3f5-4fd4-a426-b03b143a3b26@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Babu,

On 09/11/2023 20:51, Moger, Babu wrote:
> On 10/25/23 13:03, James Morse wrote:
>> The resctrl architecture specific code may need to create a domain when
>> a CPU comes online, it also needs to reset the CPUs PQR_ASSOC register.
>> The resctrl filesystem code needs to update the rdtgroup_default CPU
>> mask when CPUs are brought online.
>>
>> Currently this is all done in one function, resctrl_online_cpu().
>> This will need to be split into architecture and filesystem parts
>> before resctrl can be moved to /fs/.
>>
>> Pull the rdtgroup_default update work out as a filesystem specific
>> cpu_online helper. resctrl_online_cpu() is the obvious name for this,
>> which means the version in core.c needs renaming.
>>
>> resctrl_online_cpu() is called by the arch code once it has done the
>> work to add the new CPU to any domains.
>>
>> In future patches, resctrl_online_cpu() will take the rdtgroup_mutex
>> itself.

> Reviewed-by: Babu Moger <babu.moger@amd.com>

Thanks!


James