Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5925105rdb; Thu, 14 Dec 2023 03:52:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IGLNDQCuhVx5la4WzGxfab4ds7v2/+4lHDl6f2y21mKHOexat8Uq/Fj+UwquzBy4tMaN4Zy X-Received: by 2002:a81:6557:0:b0:5d7:4bfd:950 with SMTP id z84-20020a816557000000b005d74bfd0950mr9510627ywb.0.1702554750670; Thu, 14 Dec 2023 03:52:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702554750; cv=none; d=google.com; s=arc-20160816; b=T6aYaYdB9NDuDSW08vUbBLcdinvX6AH7+No6nlRXIvgGb/EV9yrzdFCsQyyrsHT7AL 6VYGobjg4pvAPW5sz6m7t6dbl/waEQSnk3O9z+sa1fPg9Q16j5YkZtTrc6J3mpinlRGL BqAv2yI++0OSohG4qsEgRYjRWRWkhaU5YAOOdcabam73bZxFg3URRe9Okjst+K517UIu nNuRicHqZPBnaU7K32Q7cD8zFFTSnXxWT3IwRVA6pCr6AOFwSUC5+ZgXsp9jlcOi1Zwe a4ryhBN6iwINElgT6XuRCyKjnquoUJjs02zH8xcQYcVhHWL/kwqQ3BbCKPFhSNrLZpoY 2IuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=GKt11ljdbrQuqgwD8h0TcinNH0vRuCIxothOamPhbdc=; fh=lBgBarZcGJtm65Aw/cs+dhuBd2BAs+5Q/E4ZehVC9aQ=; b=D1rJErMfuGZUdIquSuvjS0tQePoYH58WDi3oadEOFf4AoQ1vPBmtmUusUJFbHjfuFs vEdscUKPfvzaMYxLVcf1VVLdbWVh7loXt5dHPStzmf3ee0ztDI2jml+veGi3GqUcOMFc vHRC3n8Q7M3AKfQE3TWUKSuVrsTtyfd5xF5yjM1Itft+XQr4MC0dLUZ4sw6/pw5b0t4d GJLt7qGDu0Sny17n08d9ja0Mwt7kwFi2J/8+SKK2n3Dq9M7F/VwPXA9xTXvZxFYEoi4X 5R+BfTb5OvuTNivHlJHE2glnL9vuU2OpyiQGpEdrh+KdcO0zOy8jlVHCJAvGC7+RFysr II/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="Fmv/m90x"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id q18-20020a17090311d200b001d06d410ea0si7195516plh.448.2023.12.14.03.52.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 03:52:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="Fmv/m90x"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 0B5F8808BE50; Thu, 14 Dec 2023 03:51:54 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1444156AbjLNLvN (ORCPT + 99 others); Thu, 14 Dec 2023 06:51:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573008AbjLNLu5 (ORCPT ); Thu, 14 Dec 2023 06:50:57 -0500 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F31C9113; Thu, 14 Dec 2023 03:50:49 -0800 (PST) Received: by mail-ot1-x32a.google.com with SMTP id 46e09a7af769-6d9d209c9bbso6591312a34.0; Thu, 14 Dec 2023 03:50:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702554649; x=1703159449; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GKt11ljdbrQuqgwD8h0TcinNH0vRuCIxothOamPhbdc=; b=Fmv/m90xFqGeXgAIlW2erJMSrPKn16A/7lvl1myUBAQPbAkd2D9mVhsDABZOEHCXdE 9KThEzikiHNpukc7Z0rg4E6Ijs6XymKkFVqqZYf21uEcrZWfQREdrGzqraeW1ayAYWTp 8IxcCqYGWXeC8kzX9i07yx7FZpL9sqlyr2cLpj+Q2xkVHxaM+vDJ2kBYqI6ZoA24SAUF rieUZQU2FvmTMevfFjalXtKDUgp8cqeCTy66tXekQvyLZi/NKGNWrob2tkbt52+Bqyo7 ZOrbLnhxua69LI3CF9lhjSYHGM9eL3Af+ELm61zIcsK5ELyAokQ4aPt3zR7mMA6IHEyg uf0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702554649; x=1703159449; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GKt11ljdbrQuqgwD8h0TcinNH0vRuCIxothOamPhbdc=; b=nzafL5yXNXu/6+1ymZPF6TeCCLDC+5q53W9NVSi/RtBDyA56BLd1eXaITdgkmC4giB +ZsZfoBnR3CLbnfRrovPqhtD5gfCNvFkdcfaazY9ASBrZjQnYOnqQ3t5SOzJPrNIfQQ/ qIacHbwF+LdqsK6wFDHzvxoRCj6+4jyHwkds1fQpgxTOiJEnUsmqVogbE8wooWiW9Hlr 422Oq1dVsbdaqJCH6Lcfeax4Bs/j7uIackY6+D2weNSK/lTGJY2AQamTFMxD1z+SXBKQ 44+c+E1fcUIWshPZS9xrYK9h9MbHVUrhDyMg2iS8BtDp8YhOx4Lgios3c6FO0NufFMxj S9/Q== X-Gm-Message-State: AOJu0YweQAiumQtVORO6+wHhe7Wm8twwvtz+eCglmQi2HuQ2TQ8UuPQf D5rEMOtT5k98izq5FevA0L4DCp7iVxo= X-Received: by 2002:a05:6830:1bdb:b0:6da:32cd:893a with SMTP id v27-20020a0568301bdb00b006da32cd893amr3466239ota.41.1702554649168; Thu, 14 Dec 2023 03:50:49 -0800 (PST) Received: from rigel (60-241-235-125.tpgi.com.au. [60.241.235.125]) by smtp.gmail.com with ESMTPSA id c7-20020a056a00008700b006ce458995f8sm11686994pfj.173.2023.12.14.03.50.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 03:50:48 -0800 (PST) Date: Thu, 14 Dec 2023 19:50:44 +0800 From: Kent Gibson To: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org, andy@kernel.org Subject: Re: [PATCH v2 1/5] gpiolib: cdev: adopt scoped_guard() Message-ID: References: <20231214095814.132400-1-warthog618@gmail.com> <20231214095814.132400-2-warthog618@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231214095814.132400-2-warthog618@gmail.com> X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 14 Dec 2023 03:51:54 -0800 (PST) On Thu, Dec 14, 2023 at 05:58:10PM +0800, Kent Gibson wrote: > Use scoped_guard for critical sections rather than distinct > lock/unlock pairs. > It seems using guard() can further simplify cases where the scope extends to the end of the function, so I'll replace those cases when I do v3. Cheers, Kent.