Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5953970rdb; Thu, 14 Dec 2023 04:42:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IGsKXUv5TaOzIt73v2iV1251SyPTXiXuMwrlg19dID4ecJTr/hvVOoj/0Gi3oFUHMAhR+VE X-Received: by 2002:a17:903:2292:b0:1d0:92a0:4929 with SMTP id b18-20020a170903229200b001d092a04929mr12531894plh.85.1702557746474; Thu, 14 Dec 2023 04:42:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702557746; cv=none; d=google.com; s=arc-20160816; b=wPdUEllOMiGooDOQjBnUQGmTnQTXutXF9EzP+iTmfquWrymSwEWljb3uUYIbO9JI9C qm3oItLtkwf3yHfuHLZ2zjiS7/8773vOSHXZ358HK6xElwbtb+KewLRAy2gNHCWcGo3g LQCAjduxoSuEDoaqOnHz6I+twgOeTQ1AmB9BCJbWuBm8EpQUBt0aJTOAzP5U4SERWJZB qvUtsLzx0bFnWldNHZycsWp1SQUNx+PSa3KyJ/d4BPu+LqiarTLsb09FSRFfi2+v6C9w bhKlq30v3ZEhDgPFbkM/w3M/NxQbMOMXCTqeLAKcTQ4UDxxtJwIcMXrrThAgrQtK/utD j34w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ZOhaKaDvjpdr5GDOds7HS4Viwx6pgmBR0NCwbOLwLuk=; fh=3X80RpGoUIpRnCwEMQ9rcyGK2rKaVYfV9SdEBvlXwTU=; b=x+6ABEo1XorkxP0ZSnE2kQ5Pk40zr9owmIdXGdl8In7XF9/oGHVKnYB1s4ueUyLd7P Wlq6Syj9lW0rgw3RoyJ/KQja5lmGaWY/4YEHVTQVdYqzUtj3Guxyr3I0sXDtvfDvgHv0 0laKbUX5ETL5sOdDgtiWr9vRXxjHECi+12K6Eu/RYd6cm3zyFRareOZnvwvtC4e2pKSx CQ0K2eRKh0CStUGQDHVx5C5AKgTaPgVyIDgNykpR4E8rkjlsWzJ/s7gaFLVjNPuQKM72 NUk4YwnC4fYPiH5mgAxRWBA8NZDQIs4oE2mOY/YsbosCTg5vIS07qaHXyKqlfhb2w6KO 1Yzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id t6-20020a1709028c8600b001d3738e633csi425050plo.177.2023.12.14.04.42.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 04:42:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 57B338025BC1; Thu, 14 Dec 2023 04:42:24 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573118AbjLNMmP (ORCPT + 99 others); Thu, 14 Dec 2023 07:42:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573121AbjLNMmN (ORCPT ); Thu, 14 Dec 2023 07:42:13 -0500 X-Greylist: delayed 987 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 14 Dec 2023 04:42:19 PST Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04AF6129; Thu, 14 Dec 2023 04:42:19 -0800 (PST) Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4SrWkd4XgVz1kvF0; Thu, 14 Dec 2023 20:24:41 +0800 (CST) Received: from canpemm500010.china.huawei.com (unknown [7.192.105.118]) by mail.maildlp.com (Postfix) with ESMTPS id DCEEE1A0190; Thu, 14 Dec 2023 20:25:49 +0800 (CST) Received: from huawei.com (10.175.127.227) by canpemm500010.china.huawei.com (7.192.105.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 14 Dec 2023 20:25:49 +0800 From: Ye Bin To: , , , CC: Ye Bin Subject: [PATCH] scsi: core: add CMD_LAST flag for error handle scsi command Date: Thu, 14 Dec 2023 20:29:19 +0800 Message-ID: <20231214122919.985087-1-yebin10@huawei.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.127.227] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500010.china.huawei.com (7.192.105.118) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 14 Dec 2023 04:42:24 -0800 (PST) SCSI error handle will send scsi command bypass block layer. After commit 8930a6c20791 scsi support request batching. Some LLD only writing the hardware doorbell when necessary, after the last request was prepared. For scsi error handle, each command waits synchronously. So each scsi command is both the beginning and the end. So add CMD_LAST flag for error handle scsi command. Fixes: 8930a6c20791 ("scsi: core: add support for request batching") Signed-off-by: Ye Bin --- drivers/scsi/scsi_error.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index 1bac12ef238e..9e79047a1250 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c @@ -1147,6 +1147,7 @@ static enum scsi_disposition scsi_send_eh_cmnd(struct scsi_cmnd *scmd, const unsigned long stall_for = msecs_to_jiffies(100); int rtn; + scmd->flags |= SCMD_LAST; retry: scsi_eh_prep_cmnd(scmd, &ses, cmnd, cmnd_size, sense_bytes); shost->eh_action = &done; -- 2.31.1