Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5957327rdb; Thu, 14 Dec 2023 04:49:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IGTHo376FBb9t7TAZI7Ti04nYIxKHonk3yMPVdX+6ecVEOmGZ3p97NIbOjYRy3C9Cq5eaDN X-Received: by 2002:a05:6e02:164c:b0:35f:73fa:6450 with SMTP id v12-20020a056e02164c00b0035f73fa6450mr3402187ilu.30.1702558156070; Thu, 14 Dec 2023 04:49:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702558156; cv=none; d=google.com; s=arc-20160816; b=Ym52OamWwzhN1BS9GWc1X7w812Uq9JcUU1ZHBSnoAShirzPkdHFa7jDPJEcin+ypP3 2RsMRwmJItlQly3TzU5VESNrIVNWmI+nu+eFUCeMA/uu/2rtxiGbnSQM/8e+CQUKQ8mG MyD93HvVTpCIPbTnF+rmBS0hFUkdbPHVGDnJBlj5dkG5qLaYaO8rhRRJ1ySOvb1UZ32T U2M62YX9WqSWhh+fK0bNQa4PxNRzmg0Z2em4h+o5bWWfcyrceDJ9vV6/e4pyLzlMJTts EVIgQ1wGyyB2D0YO3ajXBpS4ItT690zqcDJl15zzt0Kt/XN0pE4svtGuMDH7paUQJR8R EJMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=Ev1/SB2ear2p40yVq/zMGRR51o+OVKdX74Ht4sWS5UI=; fh=IYJcvjruGo/ROSo30p5Adi0uNhPR2XdImYJiyUWh+ug=; b=mNrPq/FmH+aFFfyoXk8vAc5aOSvavLggO1Wxh/wPm63a8w5tqErLmpfIK61UyFv4yB 470f0WK2eCs5h1a66pDUidxM58T+vYWr0ZhsWEEzYsO6B02zkijLedbMT0akmRsO63SN 4q9ifKxG9mDhfT0kYhcEfoEpDwYjBDMCsoFQQhqqB9BcSW9weQxEH6D65BQxQGTmMP3B 1VejEo8rDbfYa8VjVmmgHXnwQhNqSYF9e/3thw6wuRkX6gOwDYnNawgnVvWnCZUUO2Ap 0656kmJAT859WL3KXE315fyT/Jli99wz1QPa8XB5UjB+6p1/Aey4fkLDmHlPbsTQUoXY jj8Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id ck17-20020a056a02091100b005c668c65401si11735939pgb.480.2023.12.14.04.49.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 04:49:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id BE4888069C7D; Thu, 14 Dec 2023 04:49:13 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573145AbjLNMs6 convert rfc822-to-8bit (ORCPT + 99 others); Thu, 14 Dec 2023 07:48:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573131AbjLNMs5 (ORCPT ); Thu, 14 Dec 2023 07:48:57 -0500 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA56E113; Thu, 14 Dec 2023 04:49:03 -0800 (PST) X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 3BECmjWhB840110, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 3BECmjWhB840110 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Dec 2023 20:48:46 +0800 Received: from RTEXMBS01.realtek.com.tw (172.21.6.94) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.17; Thu, 14 Dec 2023 20:48:46 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS01.realtek.com.tw (172.21.6.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 14 Dec 2023 20:48:45 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7]) by RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7%5]) with mapi id 15.01.2375.007; Thu, 14 Dec 2023 20:48:45 +0800 From: JustinLai0215 To: Jakub Kicinski CC: "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "andrew@lunn.ch" , Ping-Ke Shih , Larry Chiu Subject: RE: [PATCH net-next v14 09/13] rtase: Implement pci_driver suspend and resume function Thread-Topic: [PATCH net-next v14 09/13] rtase: Implement pci_driver suspend and resume function Thread-Index: AQHaKbuedtDdJPDHRk24Rnt75cJCOrClhpOAgAM9neA= Date: Thu, 14 Dec 2023 12:48:45 +0000 Message-ID: <05bd9b22872348c6a931408e7b58106a@realtek.com> References: <20231208094733.1671296-1-justinlai0215@realtek.com> <20231208094733.1671296-10-justinlai0215@realtek.com> <20231212111907.543e8f04@kernel.org> In-Reply-To: <20231212111907.543e8f04@kernel.org> Accept-Language: zh-TW, en-US Content-Language: zh-TW x-originating-ip: [172.21.210.185] x-kse-serverinfo: RTEXMBS01.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 14 Dec 2023 04:49:14 -0800 (PST) > > On Fri, 8 Dec 2023 17:47:29 +0800 Justin Lai wrote: > > +static int rtase_suspend(struct device *device) { > > + struct net_device *dev = dev_get_drvdata(device); > > + > > + if (netif_running(dev)) { > > + netif_stop_queue(dev); > > + netif_device_detach(dev); > > detach stops the queue, you don't have to call both Thanks for the reminder, I will modify it. > > > + rtase_hw_reset(dev);