Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5975591rdb; Thu, 14 Dec 2023 05:17:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IGJywJUP3dPOYC5fNIcXM49wBK12pjEyWNpwvnMCgvB85jKRYdmFDCUiw+jdoo5K5r92nGY X-Received: by 2002:aa7:90c4:0:b0:6d2:674e:9b0f with SMTP id k4-20020aa790c4000000b006d2674e9b0fmr252345pfk.2.1702559859720; Thu, 14 Dec 2023 05:17:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702559859; cv=none; d=google.com; s=arc-20160816; b=wbql/rTCzvlYZV6nEtPO2mS/IV9hZWuAHytKUknYaB4QwBIBg79nnzfRYXRzAXA2Jd exe5RwHPKnBmGZYlFAlfh/spTNTlDxeAjWi+ahJA2BXOpIAqVT2cqEaaEsZVzlN8u7zp INF/yFA47lawbAhKdnLotcNW3Yr47hcPHqAE/1e1AAlEQx1hLBhI5GZdGyyjIc5oVYdi ePC0wEVz9umHC1Uf61i2cPWpS0+Bd3flz/3nKsu4Q+WSfiRWzXGXImU7p8LOjOHJS2Bo CHZi1zW1uaWOz6RypQcKDiOCy9QiP9YS5jz7bKKGM+FEaUti/lNtAqtxsjIA9a2eNIWn Ia4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=JOwx/mzdDKXszuaQLdYZ1msi9ylZyxJ8mX7DjwOPBEw=; fh=mn9tVxGD5eGCG6zN+I4gofqgHN4n5D4098e4jFxPMRk=; b=y1syIr7cp2RbNH5F0SMpkeknvmbJ8bdCbVT0/hL1TMD5SmTJ5NRhPspaoTKKTw+xsy x9yJIoXBeVvBJ3iZfRmWsR7wfqNwZtOEFjVTSmQ8CgykvzhMHs0n8O9X+ERHMesY8ptg pZ/h7sjPVi584ys3rE2Jc3e/Ve1SVeeYCYyVNcSg2WQaeLTy2oaRt+z+VkwTY9pWkDXA cqYWTFxU+zGhhw+MSJRFCJ44jOE+DYM8MB0ZF+7YUm7BPbTyPGpbW+7XB/mfnrqZc1ac GYlgepANy6zYbhto5xkL7HzLXd/l/hEyDeCI/6wYi47VMBruLnkhwD11Zb8DYipPxLss 3ttA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=jeNqshmt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id f21-20020a056a00239500b006ce05b64d14si11398291pfc.93.2023.12.14.05.17.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 05:17:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=jeNqshmt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 36AA2808477A; Thu, 14 Dec 2023 05:17:09 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229517AbjLNNQy (ORCPT + 99 others); Thu, 14 Dec 2023 08:16:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbjLNNQx (ORCPT ); Thu, 14 Dec 2023 08:16:53 -0500 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B38810E for ; Thu, 14 Dec 2023 05:16:55 -0800 (PST) Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-54744e66d27so12540a12.0 for ; Thu, 14 Dec 2023 05:16:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702559814; x=1703164614; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JOwx/mzdDKXszuaQLdYZ1msi9ylZyxJ8mX7DjwOPBEw=; b=jeNqshmtzVItlAWzSzV8k3NGNGlSbaJlo0wClasTi5q3siJPbUBufJyjHQ+7JeFSy9 GcJ7QdYz8voqHQg5JilAaqYRRAPjrp72jeijcdb0VCd6dNfkZjswZXP+QZrq9ohW0Wu4 oL2hRRRnrX/Hkd4BvxJyvs9pu1MS9T2Q3pgCDMyCksC4saUAka80RB595tjaSHoBzXi3 2C8Ha3xWvaJ6h3PnWV+NZMbqpBRlr3gd8EalTjTd7Mj5w5vUnVCnGtNHE+DO7JHFTVLc LGl1p8fwasGipoTYWuiN7fnz1SJk35CEP74tZOIxfbQ6OF9DwmLaa4b1BF6I+/u+OSWH 0Eww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702559814; x=1703164614; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JOwx/mzdDKXszuaQLdYZ1msi9ylZyxJ8mX7DjwOPBEw=; b=DfrSFFWnUaHu7m8a48x9XmJ1w/P2yWYU0a7nf1zQBC/nXoQEIz/IzZrPXCLn6Tfa+u gKLKa/CmOLgaqZkSAF6NKUlkMv1C81nQaO0OBAYOZXAIerADb77kIPqapnefohhUr8ny xDadq2+FrVyCnheMN5gDB+zVtKkALUPwifiF1k1meCkx3WP3afUqfZHLh9A3s1hy/BNC vygesZhUbreI4pC2W51bSiIaNtmpvQlYFdI4iNqFOZVZxY4TQUo60JGWLa0swZFbx3AT qyuD9ZDc5IK5JIlRq7VyWa5TWd1VZ7wAeFBmmgN4KfdTI1g09Lj5bYrSPaK44DW8K00N wb6w== X-Gm-Message-State: AOJu0YybW1uLdLxk5iGHY9kQJEKQIoYEoT+hpHXIIhMMJhXJ261EWd6P 0uynLnqhRkI0XDP7nH/LphVSJ+Fdbx+7+/I/WjA79w== X-Received: by 2002:a50:bacf:0:b0:54d:6a88:507e with SMTP id x73-20020a50bacf000000b0054d6a88507emr682903ede.4.1702559813499; Thu, 14 Dec 2023 05:16:53 -0800 (PST) MIME-Version: 1.0 References: <63bd69c0-8729-4237-82e6-53af12a60bf9@gmail.com> In-Reply-To: <63bd69c0-8729-4237-82e6-53af12a60bf9@gmail.com> From: Eric Dumazet Date: Thu, 14 Dec 2023 14:16:38 +0100 Message-ID: Subject: Re: [PATCH net-next v2] ipmr: support IP_PKTINFO on cache report IGMP msg To: Leone Fernando Cc: davem@davemloft.net, dsahern@kernel.org, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 14 Dec 2023 05:17:09 -0800 (PST) On Wed, Dec 13, 2023 at 5:28=E2=80=AFPM Leone Fernando wrote: > > In order to support IP_PKTINFO on those packets, we need to call > ipv4_pktinfo_prepare. > > When sending mrouted/pimd daemons a cache report IGMP msg, it is > unnecessary to set dst on the newly created skb. > It used to be necessary on older versions until > commit d826eb14ecef ("ipv4: PKTINFO doesnt need dst reference") which > changed the way IP_PKTINFO struct is been retrieved. > > Changes from v1: > 1. Undo changes in ipv4_pktinfo_prepare function. use it directly > and copy the control block. > > Fixes: d826eb14ecef ("ipv4: PKTINFO doesnt need dst reference") > Signed-off-by: Leone Fernando Reviewed-by: Eric Dumazet