Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Thu, 14 Dec 2023 15:41:31 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Roger Quadros <rogerq@kernel.org>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, shuah@kernel.org, s-vadapalli@ti.com,
        r-gunasekaran@ti.com, vigneshr@ti.com, srk@ti.com,
        horms@kernel.org, p-varis@ti.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 net-next 05/11] net: ethernet: am65-cpsw: cleanup
 TAPRIO handling
Message-ID: <20231214134131.ecww24rt7socuplt@skbuf>
References: <20231213110721.69154-1-rogerq@kernel.org>
 <20231213110721.69154-6-rogerq@kernel.org>
 <20231214112352.iaomw3apleewkdfz@skbuf>
 <0b437b72-d9ee-478c-a838-ff8c27ec05d5@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0b437b72-d9ee-478c-a838-ff8c27ec05d5@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gNGc8zzTnxRq5WVpSPNsI6199zPuwPfSzt0F5A1jDgTMRq2sSNYiiWL3oqjm?=
 =?us-ascii?Q?4Dhrj/3Zwmnc819jwNiPuKjRmqEE2JOeYWYuJ4esD2nSd5JWjpcEdpbccM/p?=
 =?us-ascii?Q?6TDDUYOSYePnIeYbBwvBf8KDKxiE+WD/iKZzG26K6fy3sR+NaOJqYpdJFTAj?=
 =?us-ascii?Q?FB92z/T4xo8TN30dHm5sh2nk4tTb/2I5fo/eq4TaAoZDAl49kYAx1EM/HR3B?=
 =?us-ascii?Q?m++0XJqhp3GBnWrdKHRM2g/DGfZdekLDDgyWMP0srZOr8kSWU/XWJfvZkQm4?=
 =?us-ascii?Q?iKfN5ViUiQ3Gn3JQO/CBNTButVZskapeEonDnYLjBIp4GWfURtF37saj5vX5?=
 =?us-ascii?Q?ARZcVj1COVwJKKzc3yokAiyGelLgYwjU1XBRBokpVdywNllufHs9Co1GzqxM?=
 =?us-ascii?Q?45tWlU9xYrG29WyeJpQAu1Rgd5M2zMbsjyrY3d30CpBU3wGpa1XB/8Im69kK?=
 =?us-ascii?Q?Px+CMpPfCdO7IzhhjNEwTdqcdC6o7vqgholFzKjGuhc49BhVOy9VkZ++uW5W?=
 =?us-ascii?Q?4/lOS+azfLLya3X2nkL60F9syRQhL0XB4i0IE0IBXfzXq1Ni1V1beEzL4vLg?=
 =?us-ascii?Q?lmzXNEFsR+sj1e0N6xycDBmkL+OYwBuBI0tNyMO3651NZzMkn2KYw4G35SeE?=
 =?us-ascii?Q?wEPahj+Qmtxqi+kjpohAbJdVBFIY0G1yGenlFenPPshC3OTnkpjjH5jZNFX4?=
 =?us-ascii?Q?JG3ZYV5u7y2dTMv3rJ40ItxfwTDFwMY4dauilG6uvFSvcnitVs7BeZy4RyNj?=
 =?us-ascii?Q?6hml+tFoOXEidIGhKEWY/ngHu7cxvPe0CG1GgPdF5KHQgDtnpvIpm2OZeMGc?=
 =?us-ascii?Q?T8ypulyIQSZfMO4AHPkMdRITpdX+ZY++mBNQ2uA/oPPcW468ZIwS6s7YSP5j?=
 =?us-ascii?Q?KUAVTv+fYDf1Z9SVXXgVIXnBEkjzp0CKy/WUtbZQOGfGIqE5JTyH3+Es92W5?=
 =?us-ascii?Q?MmFbN6MWu4x463XibCkUj2ortfY5tILUroCuSuNuoTzxGj8ez6Hx7WwUalCZ?=
 =?us-ascii?Q?fN50ciohPlxnt8RSFADH7ak+TeWirHAClYFJ4RKOx6SXCS5+8f+3GA1JhAXH?=
 =?us-ascii?Q?CT6uY0929ddKB3A2pNPnVfCfUkGRUkYgPAby08/NZwIwDrg0oL4M4MjaMZLk?=
 =?us-ascii?Q?EE3/kXdDfeQFbgJbvGSl1g3TGs9c9g2akMOLQq/rbVyqtYPjGmTEXfexELQU?=
 =?us-ascii?Q?J61gOmyyjvVf/4hJrDK9W2nMwXyRn7pQcl8jXlJo8uVURQjhCPwk+fVR3ohw?=
 =?us-ascii?Q?EdaW6ZEkR2ipitualKy2y4MFa13VPmdELW4sr58nrlE2r8Up/vXeSqjQKD01?=
 =?us-ascii?Q?pZrSOLf0fL/MmXSZQQdntyAIs4LzcE4tvyJbnDjE49y2Spi7EwXKkTO7wXaF?=
 =?us-ascii?Q?Nqnhz45itQ7OywQAxAIJKXSyxCgp8BjovCcqwf0wfLMEOc+x/59KU+dLdo5N?=
 =?us-ascii?Q?VRoO7sx2xUaYKVOwotQmdQkmB35DjFhPsoK95396nzPWXU4wUPJ+/47uZzJY?=
 =?us-ascii?Q?PiSviJ66kCH8Esyx4KBz8sihcteXpAoVMaC4ZW6jVuV0awMRPd36vzj5owIR?=
 =?us-ascii?Q?aVmGSHixmJqJegEtQ4+G7tOX5wkQeu0M5kcBHDlmqU8i0RrwOM3hTHmXPoyY?=
 =?us-ascii?Q?FA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c712181e-0aa2-4d66-31ff-08dbfcaa63e1
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 13:41:35.5463
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6Mx43msdQ5kvfxXED74wyNWei69VjUHaUtw+Wtqhm0Xn8lSu6GqgBkZUQ51H2eIl8QZcGkaYo7x9psahLUH8TA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7935
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 14 Dec 2023 05:41:58 -0800 (PST)

On Thu, Dec 14, 2023 at 03:36:57PM +0200, Roger Quadros wrote:
> Actually, this code is already present upstream. I'm only moving it around
> in this patch.
> 
> Based on the error message and looking at am65_cpsw_est_check_scheds() and
> am65_cpsw_est_set_sched_list() which is called later in am65_cpsw_taprio_replace(),
> both of which eventually call am65_est_cmd_ns_to_cnt() which expects valid link_speed,
> my understanding is that the author intended to have a valid link_speed before
> proceeding further.
> 
> Although it seems netif_running() check isn't enough to have valid link_speed
> as the link could still be down even if the netif is brought up.
> 
> Another gap is that in am65_cpsw_est_link_up(), if link was down for more than 1 second
> it just abruptly calls am65_cpsw_taprio_destroy().
> 
> So I think we need to do the following to improve taprio support in this driver:
> 1) accept taprio schedule irrespective of netif/link_speed status
> 2) call pm_runtime_get()/put() before any device access regardless of netif/link_speed state
> 3) on link_up when if have valid link_speed and taprio_schedule, apply it.
> 4) on link_down, destroy the taprio schedule form the controller.
> 
> But my concern is, this is a decent amount of work and I don't want to delay this series.
> My original subject of this patch series was mpqrio/frame-preemption/coalescing. ;)
> 
> Can we please defer taprio enhancement to a separate series? Thanks!

Ok, sounds fair to have some further taprio clean-up scheduled for later.
I would also add taprio_offload_get() to the list of improvements that
could be made.