Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Thu, 14 Dec 2023 15:50:39 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Roger Quadros <rogerq@kernel.org>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, shuah@kernel.org, s-vadapalli@ti.com,
        r-gunasekaran@ti.com, vigneshr@ti.com, srk@ti.com,
        horms@kernel.org, p-varis@ti.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 net-next 09/11] net: ethernet: ti: am65-cpsw-qos: Add
 Frame Preemption MAC Merge support
Message-ID: <20231214135039.6lcixyy7z6u56zgv@skbuf>
References: <20231213110721.69154-1-rogerq@kernel.org>
 <20231213110721.69154-10-rogerq@kernel.org>
 <20231214110448.lycg7yusrusbd7w2@skbuf>
 <c08814cb-86b6-44bb-8682-00a5b6a0c0bc@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c08814cb-86b6-44bb-8682-00a5b6a0c0bc@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MiGWjI7xea/K6k111SCLyZ3MNqe1iBTSQN/2/tq8wmG/fPFOCOfuwuv/uBg4?=
 =?us-ascii?Q?IXxOPlUQ1n8jH1A51r4/Rqmel9WuO9ZUTZMpPSmUjX+4mRJGzGKiDnzR2+V8?=
 =?us-ascii?Q?td/6BeifO0ztv9XesuxN01TUNRrI4ySjwK5pOMkSdEmhsJhar6PcGMe1iGfV?=
 =?us-ascii?Q?CptZNJzCsBASgy7qQ1nGrUjPbjvvxxecZscUL7T8emhuf0cShTn9MY9Rf5o+?=
 =?us-ascii?Q?IT3vkFaxSxfbXOSo7Bvm16+/DnKoPGHIM+8EjiFmEQj8txLdcdkVtI+5KPfU?=
 =?us-ascii?Q?GdpdZ1lMCk9Q29e46pSau/JJv26OGD8AZnEzADjsXb5SoxbkaoiGqpx+u3ux?=
 =?us-ascii?Q?CNEfTiSUJ3x5wKeSHQAEo+8JDlwa4xI6174CJ4vGVXz4ThmlBkmCND2H6VSs?=
 =?us-ascii?Q?Fn7Cc47four6AFLvU89NcMegLDrvP00EaeDMaQHzfUp11Leowcv+dpxQlygq?=
 =?us-ascii?Q?izFfoI4QQgrd8uTQvTWDDhQgruD6kzF4gQCX00dIEOfMg7yqAQ9I/k85jciH?=
 =?us-ascii?Q?iNSOrfOIU3gM7JXNVY8KV5+a0ohMgDtOv/0HhSIHK5LjTMvvCI2HvNbM1B44?=
 =?us-ascii?Q?RHXbduncf7yHJFhOUtQ6f2ofK8pZ9/MCmKUpcUW/CPg97jDdSe+l0HBuOVqU?=
 =?us-ascii?Q?Arqrn47Torj1buBMBwis7URYpBnCH4InFXQI05b6BvmX6+mnmDPbL/rCXDzA?=
 =?us-ascii?Q?TGk4UEq1vEK6NZ/+DQSwD8PxSEoZaFkoj82ndMxP+xllAYG6OOzLFoMRKjeT?=
 =?us-ascii?Q?3i2MAlURcBz6ZqjmYCpUCjJ6mn69ilD9QN7Hj2JbIHQ521bACtMxVB215vfr?=
 =?us-ascii?Q?zrjq2BFRm7zfzHluSZqpaL9yQLrgG7NCeMD0tSGQie1pbFS7pcPoeAx7fQwN?=
 =?us-ascii?Q?kLmy5al6rPjZHXSWd7coRXiqW7JkPaJVAntWnAxRPoKk2VvEpz+pTDbJpxuS?=
 =?us-ascii?Q?sxMqNctfQKd57qkI61eliU+61F519crVv7DEfccfeGKd1a9i6I+POS01whcI?=
 =?us-ascii?Q?EOi0POgax915LBEYUuRHw8Rs7P2/V1qTXWWWWRBNw1pQI5MIvPK08h2slwwO?=
 =?us-ascii?Q?v6pcaga2WAWYoY2ZZEQ5/x9iybb6sVAnC3t/3OZtls7j6GDXWQlCkQ8EjWiH?=
 =?us-ascii?Q?QcYK9sT6itQLpVdIaakLLirfoaL227x27AZremWn4Xrciw9praLit3tzA2lQ?=
 =?us-ascii?Q?mSOjUBC5DQ4mKnmYeVXBaSz73ySfNwUz+TocOYrHVk7eZvW7ISk2NPf4cu9m?=
 =?us-ascii?Q?SW2ZpgBZ9TDDn8ZDifsXkPwpBH6Nhfe8VJFZxHEGA9OoNicttiiO63stp4xY?=
 =?us-ascii?Q?FqhtANYjeHJwL3bPlT8/Br4m4i6dz+5nKAGH5oHL8AOOYrxpdIG9DiKviQ2e?=
 =?us-ascii?Q?EnbvCoskUj+KaNy6gZgkZsGfzvwCSGHKHACRW2pY5mLaXELg+7ymQJqfEJW2?=
 =?us-ascii?Q?lqm7VwR78fck/9I1JIJUPrT458uoXEBYTB8LD443F9ZSuElX3eQpCwJWDUn+?=
 =?us-ascii?Q?EnkQWCk4DO6cym9o7Gg3Mexp7KkXO1rpMGO0Tv/fZ3sg0T7akpw/N+OgXOuC?=
 =?us-ascii?Q?U6hcM9i3QmI4tJN8UDXXChTNP57jpmU2tXDVnSkxnKWFSKYadEgARJmqUZKe?=
 =?us-ascii?Q?uA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa70c1b9-fde5-464e-cf4f-08dbfcabaa9c
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 13:50:43.6091
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1R7GK/w9OXFADUxvssgEHYN6kMsGb5zuoeVOkVUfnhlMlMbLoNDtOsX2+zA1rqubu+JWzRC0Ypu+2AHYHVOn/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8758
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 14 Dec 2023 05:51:08 -0800 (PST)

On Thu, Dec 14, 2023 at 03:44:03PM +0200, Roger Quadros wrote:
> On 14/12/2023 13:04, Vladimir Oltean wrote:
> >> +	/* verify_timeout_count can only be set at valid link */
> >> +	if (cfg->verify_time > 0)
> >> +		port->qos.iet.verify_time_ms = cfg->verify_time;
> >> +	else
> >> +		port->qos.iet.verify_time_ms = 10;
> > 
> > I don't think I understand what the check is for? The netlink policy for
> > ETHTOOL_A_MM_VERIFY_TIME limits the range between 1 ms and 128 ms.
> > How can it be 0?
> 
> I didn't check ETHTOOL_A_MM_VERIFY_TIME before.

Not even when the exact same policy was rejecting the verify-time set by
LLDP in v6, for being larger than the upper limit of 128 ms? :-/