Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <4b20b60a-c72d-4283-a8af-ff82bc5d1b19@kernel.org>
Date:   Thu, 14 Dec 2023 15:53:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v8 net-next 09/11] net: ethernet: ti: am65-cpsw-qos: Add
 Frame Preemption MAC Merge support
Content-Language: en-US
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, shuah@kernel.org, s-vadapalli@ti.com,
        r-gunasekaran@ti.com, vigneshr@ti.com, srk@ti.com,
        horms@kernel.org, p-varis@ti.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20231213110721.69154-1-rogerq@kernel.org>
 <20231213110721.69154-10-rogerq@kernel.org>
 <20231214110448.lycg7yusrusbd7w2@skbuf>
 <c08814cb-86b6-44bb-8682-00a5b6a0c0bc@kernel.org>
 <20231214135039.6lcixyy7z6u56zgv@skbuf>
From:   Roger Quadros <rogerq@kernel.org>
In-Reply-To: <20231214135039.6lcixyy7z6u56zgv@skbuf>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 14/12/2023 15:50, Vladimir Oltean wrote:
> On Thu, Dec 14, 2023 at 03:44:03PM +0200, Roger Quadros wrote:
>> On 14/12/2023 13:04, Vladimir Oltean wrote:
>>>> +	/* verify_timeout_count can only be set at valid link */
>>>> +	if (cfg->verify_time > 0)
>>>> +		port->qos.iet.verify_time_ms = cfg->verify_time;
>>>> +	else
>>>> +		port->qos.iet.verify_time_ms = 10;
>>>
>>> I don't think I understand what the check is for? The netlink policy for
>>> ETHTOOL_A_MM_VERIFY_TIME limits the range between 1 ms and 128 ms.
>>> How can it be 0?
>>
>> I didn't check ETHTOOL_A_MM_VERIFY_TIME before.
> 
> Not even when the exact same policy was rejecting the verify-time set by
> LLDP in v6, for being larger than the upper limit of 128 ms? :-/

Sorry. I did check it before but overlooked it here. My memory seems to be failing me. :(

-- 
cheers,
-roger