Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <30f26111-2b17-6ef2-6c58-4b16c890ef87@nvidia.com>
Date:   Thu, 14 Dec 2023 15:54:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v5 1/6] nvme: move ns id info to struct nvme_ns_head
Content-Language: en-US
To:     Christoph Hellwig <hch@lst.de>, Daniel Wagner <dwagner@suse.de>
Cc:     Sagi Grimberg <sagi@grimberg.me>, linux-nvme@lists.infradead.org,
        linux-kernel@vger.kernel.org, Keith Busch <kbusch@kernel.org>,
        Hannes Reinecke <hare@suse.de>
References: <20231208105337.23409-1-dwagner@suse.de>
 <20231208105337.23409-2-dwagner@suse.de>
 <bf20cb2a-0985-467b-842b-6b5fd752f14b@grimberg.me>
 <7ldcd6imhzxhn3wsirhxxyhb75x5iay2p67p2i4qi2euyztc5i@nbjtvyixifqm>
 <20231213153833.GC7301@lst.de>
From:   Max Gurtovoy <mgurtovoy@nvidia.com>
In-Reply-To: <20231213153833.GC7301@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TW8vNUlveW1DeTcyY2JsR1pUWVBWWjNRd3BuOHlhMFdJajlpR3F4QjNBK1BT?=
 =?utf-8?B?WDNFMnI2clV4VmNOY2VqWkFVdGpBS3BrLzlCWFBHWmlNdmk2aURWYWJiWFhv?=
 =?utf-8?B?QzZMR0kwOVE5YnJhYzR4a01sLzA0NjBna2piTXRRZjA4OW1LZnlXcWEwK0w4?=
 =?utf-8?B?OW82WXR5Zk1XcG8yM0pTSlpESDJid2FGd1M4R1JjWGIrVUJva0N1bDh3dmhF?=
 =?utf-8?B?SFZ3QXpHVTdoY1hwS0tRVmk1alVNMzdVd2hXUGYzZ3FVendFUmN0U0hxTlJh?=
 =?utf-8?B?N0NFaFcxb1JyMGJVdGlRRFdSSE83cDZldllDVDd4amRock9qWVBLYnQvdWJE?=
 =?utf-8?B?S3F6NHRSTUNBV0U0ME5aQUF6M1lwWFdlZ2FNOXliNWhNcFl3WU40a0xEOVBj?=
 =?utf-8?B?c2xhVDFxeElDZGlubE1IMzNoTEU2ZFQ2YTA0My9zZHN6bDVEUnc3cnN1cjAy?=
 =?utf-8?B?dFdQMEhJd1gyVS9scWJ5a0oyd0tkYjVlam1jeVRueW9pdjFqank0QUlscVND?=
 =?utf-8?B?UFdEb0dxODNmZzJDTnNpd29oWkJCU0VhckhEY0UwNUgyNnl5ckZ6dUVyN0tv?=
 =?utf-8?B?aFVDMkdtZkdyV0FLd1JQTmJQQVMvZk1RYnVCY1BjeXV2UG1TRzdNS0Rsa0U3?=
 =?utf-8?B?dmd0cXUxMVpGYWlHYUpaOGNoM0dTd0s2M3cxYUlwR0ExK0tIVFdwY3V4SXgx?=
 =?utf-8?B?RFZDRW9JODZSaGpDNjRCUzhVS1YvQlVjQVVKeEhpQitwdDA2YjNBYVNNSHg2?=
 =?utf-8?B?cXVJSmlFOUlrMVFqeVpRODBvUkRxNmFTVHd4OWRjbTR6UkNIdE9HcGx3Nlpx?=
 =?utf-8?B?M1dYV3hKcXJQZFNNb3p5RGZjYThrVGc2eGN2a0xoNzh3YkFBSWx5eUVBUWZj?=
 =?utf-8?B?cVhxRTJ1YmxjR0gzK1ErY2Z5VjlodVZZc1VDNEJXVVNCWUU1L0ttYnkzSE5w?=
 =?utf-8?B?SkpvcWVwa3N3c3ovQnpUcUhTWWI3M25DRlRjQzRLelE2Ny9ITVZxSXpuOXo0?=
 =?utf-8?B?YXBWTXovaTFsSlN6RjRrd2lwNVp3MVlSZ2xUdmlRQnd3RHNXSXd0L0NEZC9y?=
 =?utf-8?B?NnZMcGNpZXpvWTV1V0J5M3FHNjhudURuYythcXVpMENsWG5EN1Mzd1NwNjlL?=
 =?utf-8?B?bTExNDhFRUtqYWNmZjhFcENjMGE2emtKakU5dUhaNGZyQnpJd1NHSWEwTnBY?=
 =?utf-8?B?Snc0ai9xeDBMc00wVXBDUWIwdTNYWUhCanR4SkVidkdEdWlzTmlJYVhIZ2Q1?=
 =?utf-8?B?OXUzZkkzZ21CanZ1VzREZVc4NUdPK3VKaCtoNW9GejFXL2UrNWpta3c3RjRZ?=
 =?utf-8?B?K2NmclJvMUNiYkxEdXZZZHVQVHJ4YU1hc21EUnB2SURFVGppejQ5c1cvNS9P?=
 =?utf-8?B?RW9rc1JvRUtHVlkvMlUyL1NFbklsaGIySnc4Z2tMWWNPcktuNk1BNERnN0ZO?=
 =?utf-8?B?MUpOMCswT2g1bS9LeGQvU2YwaHdkMzFzM2pMNFp6UzY0ajV3anFmM2Q3TnFN?=
 =?utf-8?B?dDdxZUtPZDlucjd2bnlTTHF4SFBST1ZURjcrUDJMNC9ZYTVPMnFPakRsemor?=
 =?utf-8?B?RWZ1aC9tc2tJQlNxRGxPaGVXekE2YktwWldkTE1PQ2svaHc5ZVNCQmErcEpm?=
 =?utf-8?B?c3dsNWY3Mmk5dlVFNDRmRzYzSWlBTVdwYkhDMlJSd1UvYjRJL1VxYWlpdWho?=
 =?utf-8?B?Vk5QKzlzMjNXYnU0TFVGU3hPK2wwRTVyZDF4VEZVY1NFNGsyN1daaEVuaTFx?=
 =?utf-8?B?aTVsbnNDTEFRTy93eW9CNnpvRkRPUmp5RHV5V29qMEpoOXVRUkpqaWc3c1kz?=
 =?utf-8?B?OFBWMnRVS3FHdW5XcnJqeDVPRnpuVTlkMlpNdDZUOEx4dkloT2JGK2k5dDMx?=
 =?utf-8?B?NWR0eXpMWDVQTXdlYVdrMlYwa3dvMTFKb0paQ1hkSHE2TXNtak44RXdNM3Mz?=
 =?utf-8?B?bWNMcU52blVtM2k2cU1yN2NlaHNvdWJiSVQzWll3NnRlN3psMkV1R0lYeDc3?=
 =?utf-8?B?YUFINlNwK3AxT2hobkpGYkRkdE9sN0k5a3gra0toRDJDa1pGSmw1cHZpWXFP?=
 =?utf-8?B?MldHRStQS1N4N05iYjRnRm5Qc0JOcFViVnI3SmdJTC84eVdVY2krVUJIRkda?=
 =?utf-8?Q?iYQVj1kt2ULhVUz/EPxwPXMC/?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1bd035e1-da3f-45fb-dd7b-08dbfcac3e05
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5040.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 13:54:51.0150
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iUcEYWXtbzgCeks1pXlmbiyoRwgugVXgTMRIfDpgyPMApL9EiQgazkh+LXAPdIHxX2DuqjOng+TAM/ARa55yhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8807
X-Spam-Status: No, score=-2.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 14 Dec 2023 05:55:02 -0800 (PST)


On 13/12/2023 17:38, Christoph Hellwig wrote:
> On Wed, Dec 13, 2023 at 03:54:25PM +0100, Daniel Wagner wrote:
>>> I think that the whole PI stuff needs to be taken with a bit more
>>> consideration because if not all paths agree on the pi (as we have
>>> hbas with fabrics) we can't just override or do a logical or on
>>> the capabilities/attributes.
>>
>> So should the PI variables stay in nvme_ns at this point? Or should I
>> add some checks which avoid an override and warn in this case?
> 
> Didn't we merge the patch from max to require uniform PI setups
> for all controllers that we're using in a multipath setup?  I'll
> check the code after finishing a few more things if no one remembers
> offhand.
> 

Not yet.
I will work on it and send it soon with some another small bug fix I found.
Then we'll need to rebase this series on top.