Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   Paul Durrant <xadimgnik@gmail.com>
Message-ID: <fad44fb9-f57a-46e8-99f8-1c3d8e830cbe@xen.org>
Date:   Thu, 14 Dec 2023 14:00:28 +0000
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Reply-To: paul@xen.org
Subject: Re: [PATCH v10 09/19] KVM: xen: separate initialization of
 shared_info cache and content
To:     David Woodhouse <dwmw2@infradead.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Sean Christopherson <seanjc@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>, Shuah Khan <shuah@kernel.org>,
        kvm@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
References: <20231204144334.910-1-paul@xen.org>
 <20231204144334.910-10-paul@xen.org>
 <1556d890fac61e36b9546c5f520faa15e449bd55.camel@infradead.org>
Content-Language: en-US
Organization: Xen Project
In-Reply-To: <1556d890fac61e36b9546c5f520faa15e449bd55.camel@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 14/12/2023 13:41, David Woodhouse wrote:
> On Mon, 2023-12-04 at 14:43 +0000, Paul Durrant wrote:
>> From: Paul Durrant <pdurrant@amazon.com>
>>
>> A subsequent patch will allow shared_info to be initialized using either a
>> GPA or a user-space (i.e. VMM) HVA. To make that patch cleaner, separate
>> the initialization of the shared_info content from the activation of the
>> pfncache.
>>
>> Signed-off-by: Paul Durrant <pdurrant@amazon.com>
> 
> 
> Spot the difference...
>   
>> -               /*
>> -                * This code mirrors kvm_write_wall_clock() except that it writes
>> -                * directly through the pfn cache and doesn't mark the page dirty.
>> -                */
>> -               wall_nsec = kvm_get_wall_clock_epoch(kvm);
> 
> 
>> +       /*
>> +        * This code mirrors kvm_write_wall_clock() except that it writes
>> +        * directly through the pfn cache and doesn't mark the page dirty.
>> +        */
>> +       wall_nsec = ktime_get_real_ns() - get_kvmclock_ns(kvm);
> 
> (Hint: it's commit 5d6d6a7d7e66a)

Ack.

> 
> With that fixed,
> 
> Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
> 

Thanks.