Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6021350rdb; Thu, 14 Dec 2023 06:25:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IHCvONeLTw0o8YpFshJvW16MWv+Inob2YTxIEMpDoLFxt1Cvd+6xS7gvIIRHIRwFNMbzF9P X-Received: by 2002:a05:6a20:3ca6:b0:18b:d207:d857 with SMTP id b38-20020a056a203ca600b0018bd207d857mr13702747pzj.11.1702563956788; Thu, 14 Dec 2023 06:25:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702563956; cv=none; d=google.com; s=arc-20160816; b=gyREXbw5kBHti8ruFx1FwnlB2Y/OonU1W5BpWrkjFkTUzNJch6J67kAzpbkDuNUsw1 Rzrkmhr9pW/gRVDMEqbLDnbGK7Nincp83NLirYsNze3WtazZLRzyqpws9A3dIbdU+W1u TUq2Tg+PUs7QMccKdzZDzmtmyQINKHfPHwwvsn5ZgAAzqd0qc6BMG8VCM8oGPEIwkoGu i2khqW7F5X+hDQ1ybOM58m4ytNVwR03+EVQr5O6eFBtW4Tg/ZTeCfBoIPk4ne1gEI80P DnYjcUiz6ZfHrA39B+KmUJK/mgk60PwgyyZqA5ybGuXd/fYJoILvYkoQJzJrBudRpyC3 b6wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=palsx5VIwiV3lVq548jtGUNWQua/RNNKDbImyebYbPE=; fh=+uPBL/NDtdW5lL0Y2FiS7l9ldi6PijzEBgC/QhIFVSo=; b=dS0q+tmeD6u8j2/JfYDWbK5xxQfq5GP0tiStYAoz6ykHn04b1nJy8FKe3pB2HQ6FgZ Xxn3pi9pRwVWuRSTmV7VLFTu3hAHCEeQLwlLR0CUM6kyWU+MbzpxBJD1EgGaMtrc8y7T gAWHKaErTBcylVuu8W1qDrXH5Jtmw6Hw/OcAX+9X3E9rh9jnPVkfb5ad0ACXlOAiekVU j8TljkEHYsfebuPd+1FI5frbM26PFtq76do/mzNg1mMKP75Qmg5VezS4ds/ayUZdXy+C CYwxV0uQxVXl+xlfsHSZdyxsu/k2BWbNHjyvw4uBHQf71+GQX2VqN/vLMIDUJt9GWfyn 9Qcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=AsJPnZ2r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id a9-20020a654189000000b005b9483bf765si11517138pgq.25.2023.12.14.06.25.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 06:25:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=AsJPnZ2r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id DF132809C14A; Thu, 14 Dec 2023 06:25:34 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573472AbjLNOZK (ORCPT + 99 others); Thu, 14 Dec 2023 09:25:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573453AbjLNOZJ (ORCPT ); Thu, 14 Dec 2023 09:25:09 -0500 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9151E9C; Thu, 14 Dec 2023 06:25:15 -0800 (PST) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a1e2f34467aso750445066b.2; Thu, 14 Dec 2023 06:25:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702563914; x=1703168714; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=palsx5VIwiV3lVq548jtGUNWQua/RNNKDbImyebYbPE=; b=AsJPnZ2rpPZ6UI99MxQUtqXLXf8HIpaSNotSrerGA9FrRo9mNyZRO1aFNaCx2q24W8 woohfthYgqA07g0HQLGVne6I32eCq4sYmwFslsVglydfepXxiOQXunfTSZlIqV8L6Vut P7uAurRl0LxQU+hoLGbY14SWCw3HE+xkiyWGou316X5WmkXT1stWKJN+qj9W5dk84iiy MU7jCzlaiu6oi04to7NZ/L5crloiZUTLOliLPLzITXKfWr7Rhsm3pTmY5+fcYF+yb1kT nV/+LPArS9Mq7iBLLC/Psc1/+WI3tARmmQOllpUQ32kzRpMUlfM+142cCt81+eLiC6Vx oBMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702563914; x=1703168714; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=palsx5VIwiV3lVq548jtGUNWQua/RNNKDbImyebYbPE=; b=me9Y+LKRQjnM5+n0oI+uUl5BbEzvBQIqjDvMnRkkqXRv1vqdf9M5SjChjImM2qrSwl jiB8JrqVqopUmXW9L6WYu4oIGJq/hMPCjblecIp8+As0nGJA/3YAJTReNuKg/G9/YnMm yWww3szcq//IvEFHbTeOA198boLq6tYSRAnCmQHLhhfP+H8ZMYdm1Yy2ALNJO1np+gjl 8yk7M6FSU/gMA2k6teWreAem0IZJZRBEmDllL3A7nioblpeEVYeNXYxL4UA7UX4mEkUT DjwzZg+FME3qB5VKlCK4zEUiqtRZn0OBm6JBa4wR1myt1JlEpTkMHdNI2QfSgTZoPqtC EudQ== X-Gm-Message-State: AOJu0YyELxlT+W9gNbukH6S2x3QWlTJlGBbS73qRexRRApM+KsFoGayk oj2Pa7Qad92g0XRMRlYYvN5ZpM/vHPgYLA== X-Received: by 2002:a17:906:29a:b0:a23:f3a:d997 with SMTP id 26-20020a170906029a00b00a230f3ad997mr617781ejf.75.1702563913837; Thu, 14 Dec 2023 06:25:13 -0800 (PST) Received: from skbuf ([188.27.185.68]) by smtp.gmail.com with ESMTPSA id tl1-20020a170907c30100b00a1c8d243cf7sm9409988ejc.2.2023.12.14.06.25.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 06:25:13 -0800 (PST) Date: Thu, 14 Dec 2023 16:25:11 +0200 From: Vladimir Oltean To: Ante Knezic Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: dsa: dont use generic selftest strings for custom selftests Message-ID: <20231214142511.rjbr2a726vlr57v4@skbuf> References: <20231214142136.17564-1-ante.knezic@helmholz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231214142136.17564-1-ante.knezic@helmholz.de> X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 14 Dec 2023 06:25:35 -0800 (PST) On Thu, Dec 14, 2023 at 03:21:36PM +0100, Ante Knezic wrote: > if dsa device supports custom selftests than we should use custom > selftest strings for ethtool. > > Signed-off-by: Ante Knezic > --- I didn't notice when the selftest support was added that there is no implementation in DSA drivers of custom ds->ops->self_test(). Adding interfaces with no users is frowned upon, precisely because it doesn't show the big picture. You must have noticed this because you do have a driver implementation, so would you mind posting it together with this fix?