Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
MIME-Version: 1.0
Date:   Thu, 14 Dec 2023 15:35:18 +0100
From:   Michael Walle <michael@walle.cc>
To:     Andy Shevchenko <andy@kernel.org>,
        =?UTF-8?Q?TY=5FChang=5B=E5=BC=B5?=
         =?UTF-8?Q?=E5=AD=90=E9=80=B8=5D?= <tychang@realtek.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] Add GPIO support for Realtek DHC(Digital Home
 Center) RTD SoCs.
In-Reply-To: <ZXsKAyIlY3y3tgUi@smile.fi.intel.com>
References: <20231207100723.15015-1-tychang@realtek.com>
 <20231207100723.15015-3-tychang@realtek.com>
 <ZXHMbZRXLXGa_tq8@smile.fi.intel.com>
 <989146448858478b975c66899b8f3fed@realtek.com>
 <ZXm0MIub8X2q_lnp@smile.fi.intel.com>
 <23574204547646779d02f0109c20b3ff@realtek.com>
 <ZXsKAyIlY3y3tgUi@smile.fi.intel.com>
Message-ID: <0f0b3b65a838aea6797ae78c47d6af49@walle.cc>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

>> >> >> This driver enables configuration of GPIO direction, GPIO values,
>> >> >> GPIO debounce settings and handles GPIO interrupts.
>> >> >
>> >> >Why gpio-regmap can't be used?
>> >>
>> >> I will try to use gpio-remap in the next version.
>> >
>> >If it appears that it makes code uglier / complicated, please add the note
>> >somewhere to answer the above question.
>> 
>> I've traced the gpio-regmap.c file. It appears that for the driver to 
>> register
>> gpio_irq_chip, it must create the irq_domain and add it into 
>> gpio_regmap_config.
>> Additionally, the driver needs to register the irq handler by itself.
>> However, this process can be managed by the gpiolib if the driver 
>> fills in the struct
>> gpio_irq_chip inside struct gpio_chip before invoking 
>> gpiochip_add_data.
> 
> Hmm... I thought this is solvable issue.
> Michael, is there a limitation in GPIO regmap that this driver can't be 
> converted?

gpio-regmap is designed that regmap-irq (drivers/base/regmap/irq.c) can 
be
used. So, if regmap-irq fit this driver, then it can be used together 
with
gpio-regmap.

 From a quick glance at the patch, it looks like the gpio portion might 
fit
gpio-regmap.

>> Moreover, apart from managing the registers for gpio direction and 
>> value, there
>> are several other registers that require access(interrupt enable, 
>> debounce...).
>> The GPIO IRQ status registers are located at different base addresses 
>> and are
>> not contiguous. It may need to create an additional regmap and assign 
>> the access
>> table to this regmap.
> 
> AFAIK this is not a problem as you can provide your own xlate function 
> that
> will take care about register mapping.

Just for the gpio part. IIRC regmap has it own translation (regmap 
fields).

>> With the above consideration, I tend to keep using the existing 
>> method.
> 
> I would like to hear from Michael if it's indeed a big obstacle.

So, regarding the irq portion, again, it must fit the regmap-irq. For 
the
additional requirement to set the debounce, you can add a .set_config to
gpio_regmap_config and supply your own set_config callback. See also 
[1].

-michael

[1] 
https://lore.kernel.org/linux-gpio/d4a6a640c373b6d939e147691efa596c@walle.cc/