Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6037812rdb; Thu, 14 Dec 2023 06:53:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IF1g00FOZPBwub23bQZi+GIIomrc5m/wyIZH8WCIUAyAM0fLi73VvFLdIY7p4ICPWNrLo1S X-Received: by 2002:a17:90a:bb10:b0:28a:b60d:da43 with SMTP id u16-20020a17090abb1000b0028ab60dda43mr2643526pjr.0.1702565631825; Thu, 14 Dec 2023 06:53:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702565631; cv=none; d=google.com; s=arc-20160816; b=WzFewScvQhNqVq06LJkFRDU94NAXHfjU+OoXDsu3s0pH3aIX7H8JUv3PJINB279ugI 7rGPYg9HjUQw+XzW+E9lUdWz/klG+y8i47UzV+VMpZTmi8Uk9qVxtzQbjjlmNYoOrJ+a 4KBjymBdLHQHXBQL5sOyqTFyB7kKVbxq3FvGRvU8e+rnvPUCPQT0did8EdbStPP3dDq2 dEZrvKpDlRsLS/3jVoIErxIclzwEod2FkTGG+tgEsFeNt8pQH1W/nOCnYHK931LmQt1d REbxbbuki/E/6zIdhKzofrbPiF1QOOIGxlBrJHLX3rZogcvTG6KyqjU1hm0yqg/eOkYa S2sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=plDRD/soL+q4SsrJ7gnbfLQRz76Ox9h5QvO2u34ku34=; fh=BiTih3HBn05OJvpBeKJCJhFgvirybBPBq65CdTV6sMo=; b=h1xJge6dco0Mwp1QljfvIWSDHTH6p2/uuq45UbSskTa5zLKf0F+EaoFF4iD9i7b+uD O1R3A3FdEwOw7n5OyEizoau15RlLxX4VNTVcqNwL9RF2AfLpWCYZTtdGbfaiFPWrjQZ+ cHbgR1gI3lOucBmikFA9uvqzJtWQjnY5VXMZNzBR/EBmw7ZCHfcohofV90bB/GqKMYNQ CuV+crx3DKf7rrRnh5x8RGJGww3s95P/hkRyoKS/1XrDunPHJT6LNtgYguLdXteNtMBK jJNENCz6yVd5o4opPvQLFg77OP8hdmI9sQOCKgCHBumog0oa3DMXXT0AhT+FBKyOtQV2 lbAw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id x31-20020a17090a6c2200b0028b21ae8ef4si122795pjj.87.2023.12.14.06.53.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 06:53:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 8AEB6824684A; Thu, 14 Dec 2023 06:53:49 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573570AbjLNOxd (ORCPT + 99 others); Thu, 14 Dec 2023 09:53:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573563AbjLNOxc (ORCPT ); Thu, 14 Dec 2023 09:53:32 -0500 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78F38121; Thu, 14 Dec 2023 06:53:39 -0800 (PST) X-IronPort-AV: E=McAfee;i="6600,9927,10924"; a="2288515" X-IronPort-AV: E=Sophos;i="6.04,275,1695711600"; d="scan'208";a="2288515" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2023 06:53:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10924"; a="897768617" X-IronPort-AV: E=Sophos;i="6.04,275,1695711600"; d="scan'208";a="897768617" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2023 06:53:37 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rDn5i-00000005s64-2QaF; Thu, 14 Dec 2023 16:53:34 +0200 Date: Thu, 14 Dec 2023 16:53:34 +0200 From: Andy Shevchenko To: Kent Gibson Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org Subject: Re: [PATCH v2 1/5] gpiolib: cdev: adopt scoped_guard() Message-ID: References: <20231214095814.132400-1-warthog618@gmail.com> <20231214095814.132400-2-warthog618@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231214095814.132400-2-warthog618@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 14 Dec 2023 06:53:49 -0800 (PST) On Thu, Dec 14, 2023 at 05:58:10PM +0800, Kent Gibson wrote: > Use scoped_guard for critical sections rather than distinct scoped_guard() > lock/unlock pairs. ... > - mutex_lock(&lr->config_mutex); > - > - ret = linereq_set_values_unlocked(lr, &lv); > - > - mutex_unlock(&lr->config_mutex); > + scoped_guard(mutex, &lr->config_mutex) > + ret = linereq_set_values_unlocked(lr, &lv); > > return ret; In this case it can be guard() guard(...)(...); return linereq_... ... > - mutex_lock(&lr->config_mutex); > - > - ret = linereq_set_config_unlocked(lr, &lc); > - > - mutex_unlock(&lr->config_mutex); > + scoped_guard(mutex, &lr->config_mutex) > + ret = linereq_set_config_unlocked(lr, &lc); > > return ret; Ditto. -- With Best Regards, Andy Shevchenko