Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6043260rdb; Thu, 14 Dec 2023 07:02:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IHlAGjv0fLIYivKsZv8rc/zQl7YniugBN9DGGDG+4JjbA1pJ23qIzGQiRLz8Q74U+D5p5gG X-Received: by 2002:a4a:620e:0:b0:590:7b3d:dbcb with SMTP id x14-20020a4a620e000000b005907b3ddbcbmr5894597ooc.1.1702566123657; Thu, 14 Dec 2023 07:02:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702566123; cv=none; d=google.com; s=arc-20160816; b=IgzgRmxHM1OfQI9+y1Tpkv/8FYcWBCWfbEzrBJHuNvrhttjoAAaftWGQKgjf0u+kv3 8/oHTmObVWuGd6ekFzQuNhZzj9/Z5cGLilcFfLy+I7LdJqkzWaaTP9CKK0yEdS3mChqL Ol4Z5y6M1/kWWVpdpVZsnchh+dOMr4Ga+d/rxxK9O08c98z0lmX/V9EXocGOETCnDsjh q0rsZV4FBNyKuRU2Wp5IYWF9wkIVtDDV5iUPFv+fWuyGsyeBRSkyVeKg3kmC5DbmPFjS YF1UU+V7V1bCApr0U80/gdxCAuXRWJma9UA4rSs9C1bd9hxaawTJBnQKAjebPwH9CHVv /v8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=iOOsVgUp1DA7fnaNyE4RqTD28SmbIWel8FV7qIJOts8=; fh=jsJwwuYTy3Q3bk3qROGtmq2W5LGrWtFhrJYiKtfg4qQ=; b=PvPK7AYH8P3W8Dlo5uRnZgd8tJ6UdZHDw1vEkdJjXQDsdYxLxCkpe8+fRfmdTzZMFK /tMUpgcqeBJ0BREuRFYvLsnVVbvpt+LOVo28OnQ37IyBOAICFq0aBap6WbNQKwTu/l7f GNsUh+/UhlHhn+VHkgpPMWSw2WcrROLdvyHid8qyuJm+vFNrhFAyYajmuK90FkDALiIc VMDE9qo8pu+fGqcm2bsvbyv1IabbXFm1aTV2K7/PoN8iHZH9f3qI5AhU93aglI4WiVsH /lPRW8s6NcIKFm4+m8/rnuKOqMEdRdCyjR8ZioYEXi4hG3+cFPh7eXo9k/1upWeGtgd+ Gm3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GDqOhTht; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id n25-20020a4a6119000000b0058e4c98bb99si3990118ooc.83.2023.12.14.07.02.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 07:02:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GDqOhTht; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 16311807C5DF; Thu, 14 Dec 2023 07:00:18 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573591AbjLNPAD (ORCPT + 99 others); Thu, 14 Dec 2023 10:00:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573569AbjLNPAB (ORCPT ); Thu, 14 Dec 2023 10:00:01 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CC0BBD for ; Thu, 14 Dec 2023 07:00:08 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27E51C433C7; Thu, 14 Dec 2023 15:00:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702566007; bh=1YjS65z8+/pfGjEqHXCMW75YMXrkf8CXxmJj2AiwZhY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=GDqOhThtvGROp4PSSxZkUah0QZE7Q1Kt4vyNMFrncdliBFkCDDm4ETYYrzhQGljSb PRp4/AY678LS6VHo3sIj946k+urm3FyM5N5Y3a43+HfiF1JN3lz1uk29BbW7GoT+Dc Rn+a0eKilpL+LIfaz0lIgYEYzLIR0iEA7C+gdTEpB8aEm4BK7274NjegNcAYStnBQg uZfLhPxjreTASYzcKnQH7ilIroLmxWhjy9ANr5sBXcCEMgH8gzatHXxthEHDdLQrET gonsUNeJDQCVQBVj74M8MbEDnX8sQN+Cv5LXpSRdX/z2DFTvU5lzwLC0Uol30cRDJ9 +tRRPm1PfDyzA== Message-ID: <47790c53-cfe0-4731-99d6-cd6ec2fec9be@kernel.org> Date: Thu, 14 Dec 2023 23:00:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] erofs: fix memory leak on short-lived bounced pages Content-Language: en-US To: Gao Xiang , linux-erofs@lists.ozlabs.org Cc: LKML References: <20231128175810.4105671-1-hsiangkao@linux.alibaba.com> <20231128180431.4116991-1-hsiangkao@linux.alibaba.com> From: Chao Yu Autocrypt: addr=chao@kernel.org; keydata= xsFNBFYs6bUBEADJuxYGZRMvAEySns+DKVtVQRKDYcHlmj+s9is35mtlhrLyjm35FWJY099R 6DL9bp8tAzLJOMBn9RuTsu7hbRDErCCTiyXWAsFsPkpt5jgTOy90OQVyTon1i/fDz4sgGOrL 1tUfcx4m5i5EICpdSuXm0dLsC5lFB2KffLNw/ZfRuS+nNlzUm9lomLXxOgAsOpuEVps7RdYy UEC81IYCAnweojFbbK8U6u4Xuu5DNlFqRFe/MBkpOwz4Nb+caCx4GICBjybG1qLl2vcGFNkh eV2i8XEdUS8CJP2rnp0D8DM0+Js+QmAi/kNHP8jzr7CdG5tje1WIVGH6ec8g8oo7kIuFFadO kwy6FSG1kRzkt4Ui2d0z3MF5SYgA1EWQfSqhCPzrTl4rJuZ72ZVirVxQi49Ei2BI+PQhraJ+ pVXd8SnIKpn8L2A/kFMCklYUaLT8kl6Bm+HhKP9xYMtDhgZatqOiyVV6HFewfb58HyUjxpza 1C35+tplQ9klsejuJA4Fw9y4lhdiFk8y2MppskaqKg950oHiqbJcDMEOfdo3NY6/tXHFaeN1 etzLc1N3Y0pG8qS/mehcIXa3Qs2fcurIuLBa+mFiFWrdfgUkvicSYqOimsrE/Ezw9hYhAHq4 KoW4LQoKyLbrdOBJFW0bn5FWBI4Jir1kIFHNgg3POH8EZZDWbQARAQABzRlDaGFvIFl1IDxj aGFvQGtlcm5lbC5vcmc+wsF3BBMBCgAhBQJWLOm1AhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4B AheAAAoJEKTPgB1/p52Gm2MP/0zawCU6QN7TZuJ8R1yfdhYr0cholc8ZuPoGim69udQ3otet wkTNARnpuK5FG5la0BxFKPlazdgAU1pt+dTzCTS6a3/+0bXYQ5DwOeBPRWeFFklm5Frmk8sy wSTxxEty0UBMjzElczkJflmCiDfQunBpWGy9szn/LZ6jjIVK/BiR7CgwXTdlvKcCEkUlI7MD vTj/4tQ3y4Vdx+p7P53xlacTzZkP+b6D2VsjK+PsnsPpKwaiPzVFMUwjt1MYtOupK4bbDRB4 NIFSNu2HSA0cjsu8zUiiAvhd/6gajlZmV/GLJKQZp0MjHOvFS5Eb1DaRvoCf27L+BXBMH4Jq 2XIyBMm+xqDJd7BRysnImal5NnQlKnDeO4PrpFq4JM0P33EgnSOrJuAb8vm5ORS9xgRlshXh 2C0MeyQFxL6l+zolEFe2Nt2vrTFgjYLsm2vPL+oIPlE3j7ToRlmm7DcAqsa9oYMlVTTnPRL9 afNyrsocG0fvOYFCGvjfog/V56WFXvy9uH8mH5aNOg5xHB0//oG9vUyY0Rv/PrtW897ySEPh 3jFP/EDI0kKjFW3P6CfYG/X1eaw6NDfgpzjkCf2/bYm/SZLV8dL2vuLBVV+hrT1yM1FcZotP WwLEzdgdQffuQwJHovz72oH8HVHD2yvJf2hr6lH58VK4/zB/iVN4vzveOdzlzsFNBFYs6bUB EADZTCTgMHkb6bz4bt6kkvj7+LbftBt5boKACy2mdrFFMocT5zM6YuJ7Ntjazk5z3F3IzfYu 94a41kLY1H/G0Y112wggrxem6uAtUiekR9KnphsWI9lRI4a2VbbWUNRhCQA8ag7Xwe5cDIV5 qb7r7M+TaKaESRx/Y91bm0pL/MKfs/BMkYsr3wA1OX0JuEpV2YHDW8m2nFEGP6CxNma7vzw+ JRxNuyJcNi+VrLOXnLR6hZXjShrmU88XIU2yVXVbxtKWq8vlOSRuXkLh9NQOZn7mrR+Fb1EY DY1ydoR/7FKzRNt6ejI8opHN5KKFUD913kuT90wySWM7Qx9icc1rmjuUDz3VO+rl2sdd0/1h Q2VoXbPFxi6c9rLiDf8t7aHbYccst/7ouiHR/vXQty6vSUV9iEbzm+SDpHzdA8h3iPJs6rAb 0NpGhy3XKY7HOSNIeHvIbDHTUZrewD2A6ARw1VYg1vhJbqUE4qKoUL1wLmxHrk+zHUEyLHUq aDpDMZArdNKpT6Nh9ySUFzlWkHUsj7uUNxU3A6GTum2aU3Gh0CD1p8+FYlG1dGhO5boTIUsR 6ho73ZNk1bwUj/wOcqWu+ZdnQa3zbfvMI9o/kFlOu8iTGlD8sNjJK+Y/fPK3znFqoqqKmSFZ aiRALjAZH6ufspvYAJEJE9eZSX7Rtdyt30MMHQARAQABwsFfBBgBCgAJBQJWLOm1AhsMAAoJ EKTPgB1/p52GPpoP/2LOn/5KSkGHGmdjzRoQHBTdm2YV1YwgADg52/mU68Wo6viStZqcVEnX 3ALsWeETod3qeBCJ/TR2C6hnsqsALkXMFFJTX8aRi/E4WgBqNvNgAkWGsg5XKB3JUoJmQLqe CGVCT1OSQA/gTEfB8tTZAGFwlw1D3W988CiGnnRb2EEqU4pEuBoQir0sixJzFWybf0jjEi7P pODxw/NCyIf9GNRNYByUTVKnC7C51a3b1gNs10aTUmRfQuu+iM5yST5qMp4ls/yYl5ybr7N1 zSq9iuL13I35csBOn13U5NE67zEb/pCFspZ6ByU4zxChSOTdIJSm4/DEKlqQZhh3FnVHh2Ld eG/Wbc1KVLZYX1NNbXTz7gBlVYe8aGpPNffsEsfNCGsFDGth0tC32zLT+5/r43awmxSJfx2P 5aGkpdszvvyZ4hvcDfZ7U5CBItP/tWXYV0DDl8rCFmhZZw570vlx8AnTiC1v1FzrNfvtuxm3 92Qh98hAj3cMFKtEVbLKJvrc2AO+mQlS7zl1qWblEhpZnXi05S1AoT0gDW2lwe54VfT3ySon 8Klpbp5W4eEoY21tLwuNzgUMxmycfM4GaJWNCncKuMT4qGVQO9SPFs0vgUrdBUC5Pn5ZJ46X mZA0DUz0S8BJtYGI0DUC/jAKhIgy1vAx39y7sAshwu2VILa71tXJ In-Reply-To: <20231128180431.4116991-1-hsiangkao@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 14 Dec 2023 07:00:18 -0800 (PST) On 2023/11/29 2:04, Gao Xiang wrote: > Both MicroLZMA and DEFLATE algorithms can use short-lived pages on > demand for overlap inplace I/O decompression. > > However, those short-lived pages are actually added to > `be->compressed_pages`. Thus, it should be checked instead of > `pcl->compressed_bvecs`. > > The LZ4 algorithm doesn't work like this, so it won't be impacted. > > Fixes: 67139e36d970 ("erofs: introduce `z_erofs_parse_in_bvecs'") > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,