Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6043818rdb; Thu, 14 Dec 2023 07:02:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IGfzcIiwRF/Q7DiPhOkMWZ+NYPuwRy5pVb5qhMd7i2HJhiQzCzDrAKMUUy1ocpHOHsMhlSC X-Received: by 2002:a05:6a20:9390:b0:18b:9041:5729 with SMTP id x16-20020a056a20939000b0018b90415729mr11980108pzh.17.1702566037706; Thu, 14 Dec 2023 07:00:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702566037; cv=none; d=google.com; s=arc-20160816; b=a8iDUZmJuGpYILGaPjtW7rHwkKkoh7d/R5y7UbLAjPSQ2eKOz81769lZeTBfSV5vle JWkUcq2sGSzhvIWu3Vxv3kiSTsyMSg52YzUhDgEPHd1FUnNZ8myzjlE/GtT3vXATrJrX BtaEK7zQnGoXci5ifMjQsSswgn46qSSwmCliTH2hVjzz9ja3/DHGWDfaKeb3/yHkyOhg QRs4ovp3rJyFb964dynbf78Op8hV7XOATjyl5KpxImqaW/fzGp8E5pTGT6Xlbxxw0tZT HSikGYzzje/L4sfLik24bf9wodZjZDU636vwpoo1I7NwHFo6Y9Iw7knV+bLhVptBma7b PpKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=YWD8flG08948c+kk5diZhSkaE4l4o5OrXgP93+sWFH8=; fh=4EXBCe2eRWRn1DJRKzcK41ZlB9kojxnJyL9l6+1UQlQ=; b=z1+ye8pup0qG2/fdHxuow8lSzqc5QPDOj8sEk4p75Wii09Ehk6Jd+tqFfJ+yUYoeZp +fNwRj2IPxl3G4b8DGIUJVfXtOaflOzwpuGIKf6YqdrOWc48M0Qc5OjnicixqGAJeuOI //5k70Wyxx1+PoheeHe7jqW0pTl7Go9la3Fwi5fdwZfqYsnnVxvyjasK4PA/mZ1L7v6L hD2NQVabPZa+Bfp8oI7f7OwsT5ltAC0VhjYDYhBOPEiBFPl6/J1DP1zxUv78HTm6UHqc 0dnFfF8ZRUXEiIxC/5VtQkqp1LjYCtu6MO2+BkQyllfogHf+JpUhLtTsGiMyDu3iWYM1 3Mkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DvsAgNQw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id fd3-20020a056a002e8300b006cdcd785487si11559935pfb.304.2023.12.14.07.00.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 07:00:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DvsAgNQw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id CAC8380AEB0D; Thu, 14 Dec 2023 07:00:33 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573606AbjLNPAT (ORCPT + 99 others); Thu, 14 Dec 2023 10:00:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573608AbjLNPAR (ORCPT ); Thu, 14 Dec 2023 10:00:17 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F36BB12D for ; Thu, 14 Dec 2023 07:00:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702566023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YWD8flG08948c+kk5diZhSkaE4l4o5OrXgP93+sWFH8=; b=DvsAgNQw4RtRf5gws7m4j72rD15EQf0iFQrZ41WBkKMZT5nrsHaUSUtozJwzGBAF8tfUtI q6X3QmWOZs8tYSmVIUM1E2TIjLAvmtJl2mwhY4r6gA5ugnN9hhFjIA4Mbsq18S4kkny1jj hkM8jo3Hdn1zmdXpQiMXzF0bzU8knic= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-170-6T4pY_1JPpqQlnz5ZvBO-A-1; Thu, 14 Dec 2023 10:00:20 -0500 X-MC-Unique: 6T4pY_1JPpqQlnz5ZvBO-A-1 Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-551dda474aeso124463a12.0 for ; Thu, 14 Dec 2023 07:00:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702566018; x=1703170818; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=YWD8flG08948c+kk5diZhSkaE4l4o5OrXgP93+sWFH8=; b=adZ917hl8QxFcDGOd3fuei+RQO+YVc3M3t3l8NWOCL8Sny8p2beiZ8qncoZLq6YZPp Hrk0oXYO2i/BGpiF7N50uO15C/ahbI55bBbiYslrb2U/62gJmOT4PE0wTKmK8Tok/hbP xuGHt4jbK5DjZYeHiCAC/1vebPUoPfNMsKInCk4R+p7/ewU8hFilKqY/YTNVIdHzGmb1 W02WA5ocKsm2rjAO2ZEw/BBa9qCAofUfE5eBFXfwG8GTzF3igGh1KCGiFcCSDb5biaWx m7PefAfad7sXFnP1xc7YAZNy3EHXSzJPzzATFahri6/v3R7CdSSfJyd2H6VAxonJC1lE eDpQ== X-Gm-Message-State: AOJu0Yzm5qPjPWrmgmud80DDT5iL588isViIk+SVOY5iWm7WKoMEOW4H KmNSCS8dMs/hdn7ab3h64VrXg5R1/8ImoBFJPh8L6z6kM8icbWaoCarnSVPCJ1xzEsThQuulcKO 1/bn1P7UiNFkeeePwUVOfs5CY X-Received: by 2002:a50:c349:0:b0:552:8299:65fc with SMTP id q9-20020a50c349000000b00552829965fcmr853878edb.4.1702566018700; Thu, 14 Dec 2023 07:00:18 -0800 (PST) X-Received: by 2002:a50:c349:0:b0:552:8299:65fc with SMTP id q9-20020a50c349000000b00552829965fcmr853840edb.4.1702566018356; Thu, 14 Dec 2023 07:00:18 -0800 (PST) Received: from gerbillo.redhat.com (146-241-252-36.dyn.eolo.it. [146.241.252.36]) by smtp.gmail.com with ESMTPSA id cn10-20020a0564020caa00b0054ca2619c1bsm6867552edb.9.2023.12.14.07.00.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 07:00:17 -0800 (PST) Message-ID: Subject: Re: [PATCH net-next v6 3/3] net: stmmac: Add driver support for DWMAC5 common safety IRQ From: Paolo Abeni To: Suraj Jaiswal , Vinod Koul , Bhupesh Sharma , Andy Gross , Bjorn Andersson , Konrad Dybcio , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexandre Torgue , Jose Abreu , Maxime Coquelin , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Prasad Sodagudi , Andrew Halaney , Rob Herring Cc: kernel@quicinc.com Date: Thu, 14 Dec 2023 16:00:15 +0100 In-Reply-To: <20231212115841.3800241-4-quic_jsuraj@quicinc.com> References: <20231212115841.3800241-1-quic_jsuraj@quicinc.com> <20231212115841.3800241-4-quic_jsuraj@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 14 Dec 2023 07:00:33 -0800 (PST) On Tue, 2023-12-12 at 17:28 +0530, Suraj Jaiswal wrote: > @@ -3759,6 +3763,7 @@ static int stmmac_request_irq_single(struct net_dev= ice *dev) > struct stmmac_priv *priv =3D netdev_priv(dev); > enum request_irq_err irq_err; > int ret; > + char *int_name; I'm sorry to nit-pick, but please respect the reverse x-mas tree above, Otherwise LGTM! Cheers, Paolo