Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6062592rdb; Thu, 14 Dec 2023 07:25:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IEoK64iuJT0ll0PNlAQ3KdS6VXvw1dbY6CsUvvvhyN4992Q7gpiyiB6jubqEDsvp5znOcRi X-Received: by 2002:a17:902:d34b:b0:1d3:77a0:ca01 with SMTP id l11-20020a170902d34b00b001d377a0ca01mr354449plk.120.1702567557305; Thu, 14 Dec 2023 07:25:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702567557; cv=none; d=google.com; s=arc-20160816; b=H8hufG7zPa8m7v9VEszlRiMui0TMhfdVwomYnoM+oujPLKthUPynKua2Wfzm5rrTOf QeBVyjWqvrAvwBVhXlp/R/SK1pt1vvsGqVxm7je8LVXwBwQ9wKPP6iCwtx/iYy1n32S2 WRgEo1MaQ3ijeyWdcBbpFi0qFf+BMKlu3QAGvM6CFaeZtDAnDaW97brBCDdf5miqt4Yx OGOHD9L35zozn2MyhMnx+7klI0Gjii+5jZXSLOqq5IcuRvFwXivaSrq0v6NNI+AnBsvk JW3/vI07deY75/OF3sFy+aJesBSQsfk2+qs3hGMJNm+KBisgZsHgmzYQv1RwjMdA93m8 0zcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:feedback-id:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from; bh=kdaE1oMnNfwyCeqMc5NPgJYXkDKIbaWvRsXADL1RA38=; fh=ub1T/TP7vmh6RvkYW+XCnzrkTYq6WX3fzbQTZcX9yfk=; b=cuqPy3ZqvLufzp+opsjKnghy9me1CV+XvCaP02zVmd5bAhZFFuDpJ46QtNDmMt6iGS rQLscS2LsGEQWz8axIET34LldNpV+Etfvzawc5h4WG9Fd1m02myobeyJU3rUGRIsPzbh DQ92s3hczpGTptKzCD6HOcppP0gCEl4J9Z9wEbHib48La2LfpZO5pOUG/otsf+xjCB9H 1c2d6hVG/iGqgaMV4gKpJYXTzQGFVrIIhuEMk3kcO4ZBl1IiMVGyukz9GcPjyUkWgBgH qqou3U7xLjOa5jdbCklTD5/0LN1blqxS/y+VXWoUeWlT02uqQlrNgeSuMTdtpi8TdgyU dMWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id d18-20020a170903231200b001d096bcfc22si11871944plh.340.2023.12.14.07.25.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 07:25:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 52E91809C3B3; Thu, 14 Dec 2023 07:25:32 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573834AbjLNPY6 (ORCPT + 99 others); Thu, 14 Dec 2023 10:24:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573831AbjLNPYk (ORCPT ); Thu, 14 Dec 2023 10:24:40 -0500 Received: from smtpbgsg2.qq.com (smtpbgsg2.qq.com [54.254.200.128]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 771CF10E9; Thu, 14 Dec 2023 07:15:15 -0800 (PST) X-QQ-mid: bizesmtp65t1702566900tw788o8z Received: from localhost.localdomain ( [125.76.217.162]) by bizesmtp.qq.com (ESMTP) with id ; Thu, 14 Dec 2023 23:14:58 +0800 (CST) X-QQ-SSF: 01400000000000E0H000000A0000000 X-QQ-FEAT: kUim6XnhvqXLGVCGif12YpsOAXyfr323UC3dd/L/ZZMRExUmZKiKHx5oLDwbc LZzHsLq4aDfbgSQBoakNgqyPtoAG8ML/TL2OLcIplBRfcTGJV3PPVGtuuGQ8pxWx/vIbIwR 5ZAFYsHnG0GHnlOQuCfHCgj5BCPU+Sp5ikANO2re6gi78KCC4oZ2SlOTAZZdmUfd/tpqRLx BCIp/8BX6nhxXydNyFpX4qd9MEtqTJO0gbbOdgkurPdXoX4elaPv0zkzjXbvy4mDwgJ+u5T SEbIvwlMP2On1e7fyOe2gsqtX6nCX33EzaxInBrs5an8wRXUQ4NmpffwfQHuFBCyyZKaakA IN5FFUpjE52KjRyGo9s3SmS9ZPTkBVhRvTH+JHNnfvuzTCtz8YlBuXkRf7qbUW64QU13N4m X-QQ-GoodBg: 1 X-BIZMAIL-ID: 16267120763352956004 From: Gou Hao To: song@kernel.org, linux-raid@vger.kernel.org Cc: linux-kernel@vger.kernel.org, gouhaojake@163.com Subject: [PATCH] md/raid1: remove unnecessary null checking Date: Thu, 14 Dec 2023 23:14:58 +0800 Message-Id: <20231214151458.28970-1-gouhao@uniontech.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:uniontech.com:qybglogicsvrgz:qybglogicsvrgz7a-0 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 14 Dec 2023 07:25:32 -0800 (PST) If %__GFP_DIRECT_RECLAIM is set then bio_alloc_bioset will always be able to allocate a bio. See comment of bio_alloc_bioset. Signed-off-by: Gou Hao --- drivers/md/raid1.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index 35d12948e0a9..e77dc95d4a75 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -1126,8 +1126,6 @@ static void alloc_behind_master_bio(struct r1bio *r1_bio, behind_bio = bio_alloc_bioset(NULL, vcnt, 0, GFP_NOIO, &r1_bio->mddev->bio_set); - if (!behind_bio) - return; /* discard op, we don't support writezero/writesame yet */ if (!bio_has_data(bio)) { -- 2.34.1