Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <5ce84888-6071-4fef-a6d5-5cf0b2a8c7ed@oracle.com>
Date:   Thu, 14 Dec 2023 15:46:13 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 00/16] block atomic writes
To:     Christoph Hellwig <hch@lst.de>
Cc:     axboe@kernel.dk, kbusch@kernel.org, sagi@grimberg.me,
        jejb@linux.ibm.com, martin.petersen@oracle.com, djwong@kernel.org,
        viro@zeniv.linux.org.uk, brauner@kernel.org, dchinner@redhat.com,
        jack@suse.cz, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, linux-scsi@vger.kernel.org,
        ming.lei@redhat.com, jaswin@linux.ibm.com, bvanassche@acm.org
References: <20231212110844.19698-1-john.g.garry@oracle.com>
 <20231212163246.GA24594@lst.de>
 <b8b0a9d7-88d2-45a9-877a-ecc5e0f1e645@oracle.com>
 <20231213154409.GA7724@lst.de>
 <c729b03c-b1d1-4458-9983-113f8cd752cd@oracle.com>
 <20231214143708.GA5331@lst.de>
Content-Language: en-US
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20231214143708.GA5331@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVJJb2V6Q3hKTnhlU0J2ckFadVNra2IwZ0xFNm53UjJWdlJsbmpkZmppcWRK?=
 =?utf-8?B?S2tGSkVHUzRmNWM4dEFTWXJMcmk0ajFNYmZubW11ZVd3Wmx3U0VWLzJpcWND?=
 =?utf-8?B?QU94Sy94TTdSUU9CaSs2aDMreG9pbnl3WkRXMVFQQWlNaHVjYmRXQ1dnajJN?=
 =?utf-8?B?TE9ueFllazdCZS9NQ1RCbjJaMGpUNC9vbUozMWlsazZ4L3lpRUp6OGd2L1Ev?=
 =?utf-8?B?ak5MMjFwZkpoZ3hzWTVRczNqaW4ydXlnbWxsaHBqNnVGaUFwcVNiN210R0dk?=
 =?utf-8?B?YzRMZTdYaWM1VVlZUTdYWHlGZmNGRSs3N3BWRjJHUmd6azA4YVo2M1IwVUg2?=
 =?utf-8?B?YmdzNmVpS01QNHN5bDYzUnVTa1A1NjQrVHlzQTdGTk1TeVZYRFVVYWhqYXVW?=
 =?utf-8?B?YmtKdFhVY1BBek9nRUU4SlA0U0ZGS2lIUCtlL2V0Sk83Y0Nac3ZWQS9wRURC?=
 =?utf-8?B?cmtjNHpqS0NNNFpuaDFraTlHOEEvTGxlRVBNMkx2Z1cyayt3K292dHYzS0pI?=
 =?utf-8?B?QVQvMytRK1h0WVlNOTRTQjhKQTZWZWVOR1M4K3V1R2liVGZ6S0tsQXZaNm8x?=
 =?utf-8?B?OFlONHRhK2hoajFKdW9LelJMTmlPdi82TVNOVU1EMXJud0NtOXM1R0FRdUxx?=
 =?utf-8?B?MU5USm5RaUU2SWI1cHQxWHY1Y3UyVFFGc1RBbG5GakltRDEwUzFaS0FnVnVB?=
 =?utf-8?B?NlpsRGIwVkRXWllmQ2hMSlUvclMzc3d4cGJuOUgySUx6aW85Mm5xUXJpazYr?=
 =?utf-8?B?R0Z4R2ovR1VHa3YwVy9uTU1BQk43bWp2K2xjZ0lNT3R0NEcxK05yNTN6K2N3?=
 =?utf-8?B?SjdzWXdxbitncEg1OFNwQ3pZWGVzNkdvVzVsV0s2T2Qyelg1QjZ0OUdGL0Y2?=
 =?utf-8?B?N1JOa2tGWlh4cnkvb29qR0x6S0JVazZoWU5WVDN1WjA0aDByNEJZYWROZHR4?=
 =?utf-8?B?UWdYTjNjMjJGN3hCbG1MUlVockxRa0g1am1PTjE0aTRxSXhxQ3BtMXlDd09r?=
 =?utf-8?B?VkJkM00zVkJIMVdzWkRHQjA1VUdZQzBRbUV6NVI1TWJ2M2NVWGkrck9jUElq?=
 =?utf-8?B?bjZDc1N1ZzRyWURTL0tXRU5LNnVJMTZLdUt1NWxVMG9udmpkY2ZLSTBrbzFC?=
 =?utf-8?B?UzYyc0xsSnRjd3R0NmJYTmxsYUF5UE11d3pRTU1WSnlNb216WHpQamNUcUJC?=
 =?utf-8?B?ckcrQ25DWjVIcGovcGlncHlaVTZnK3YwazQ1TFgrMFRJOWU1Z2Y2OWtYRmVm?=
 =?utf-8?B?MGIzRXpxck1XeFlTNUdXSVBOVHZMOWJwd3E4VG5xR2Z4UDg4Tnd2bFd6MGpT?=
 =?utf-8?B?VHA3YUpMR2tpelljblJiU296ZGlOSXpEZFc1d0hLRG9vNkh6dE1UbWNxdHhu?=
 =?utf-8?B?dzd5QWN5Zm5iOUFDOUlPTVBvQm9JK2pGTlRaU1BWM216cmdRK0RBVWFhaVlM?=
 =?utf-8?B?U2hmQkhJOHN1NmVBVUN4QnpYTTJrS1NrNVcyTEx4eGQwR3RKaW96d2VvbVJM?=
 =?utf-8?B?WDdzY1lMMUtkeVlsS3h0a0JlNHYxQzRucVJaS0ZycEN0THVVdE1mdHVVNEVY?=
 =?utf-8?B?ZGJiT0RSYjZmSysxRVY3clIxbmZ6dFJKQmpsNEluLzdtSFozbkUzUlhJU0h3?=
 =?utf-8?B?aitMSlVtVDFWRWtGaXdsTXdDbGFVVVVUeDBQenhzZE9DR3B4a2dSTTFjTU0r?=
 =?utf-8?B?OHl4OWhNb3JweTQzOWpDalVNaDFHYk56UGhZRnFSaVRFNmszK2crdFBpditq?=
 =?utf-8?B?MldNZGYxUk9BNzJJQWtMMFJ3bmY4ZC9INUVmbWtZcUx4WkNnRy9zbG03QkRI?=
 =?utf-8?B?d1FjdG1jdzNtcStzYnJJYi9rZ1JpaGRQOTU1SklqcW1wZzNBWldXbDdMTnhH?=
 =?utf-8?B?TWp2dDRqUHJEZ3M5M25ubDZMZFU3c0M0VXRUSjYwSkdBNGQ4Kzh1bXNoYytn?=
 =?utf-8?B?TVVYRHQvVWw0RWljdUNxbXU1ZnlTbktpUWVVQzR3cmNocW1NQitlMW5oTDlH?=
 =?utf-8?B?K1ozZURWR08rU25jVmlLMkgrNG1ydjlYZmtBNlA3eHQrREc2Y0ZhWVc5SDBn?=
 =?utf-8?B?bmtoVFZhYUFlTzM0RU1Xd25oUWg2SkhFejY5R0FCOGRjZjd4M29KbUZTcUhG?=
 =?utf-8?Q?0d7dHK3GsG7CxBDPTKt+tnCK0?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: qUPdrjbeh/OuZNLkkmcCcAqzx8xmqCu1pQ7zh7Eb2wA6P5NI/288Nwxm5jZH4yaNVqgMlgeEdJnj4B8pJ3lpufmXd1yvF/CCWZyFLrZTuFCASC9UJ9+5P6J8aSMqOXi9UdReMSH1Bi6Q9GO8jjhRohXGZ6Ke+cNegEPL8R4bicRBa9aXPZpLz0K0fENDs+ryP+4pbW/p+n+BNzMUh00gUxvxa4Z7EpWTZ2lilAiVSmcnBQLEuQyl2g9hihSfQydc6pZPvZSdEM9lqoHbkLfynijXD1Ii1oSrKUpo/5pWvtunSkMGLCMtT0r56YnQYpPWmQm+YdWRiEMFUmEYJx3jTtQAsGpF/u3cbYIXK+h6yOGpPdq8QVoIFsIRga4TxdFfMqin4kbL6XEixMi8BTh6TzAbONfd9U/iFpg+O9LewqN7dXnqH2liGf/ZshUQsHxlcXbAPIp+QxFJzqfxAev4U9OLUjxiV4sm2Hw8k5Y/34LnXkOEw5huZFx9l9EFlxiRjISUv5iZ6f1BbWcT44bJKqaG44CuwMb5RzgSiV2Q0FegB9cy+6c2/OOjoR+jCckwIrjUE4LqImsc3t/jeZsDShW90Tu/N+ovL0QSe8s5dCc=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a60c46f-316f-4352-07b1-08dbfcbbd03d
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 15:46:18.8170
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xeexG8l61dP3jWrksi0Xx71Ri1d1k3p0HKT6n4aG7YAx+EIeIbofLGJ7RLvwXbGw//6O61zsK7O8D7REezM/OA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6545
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-14_11,2023-12-14_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 suspectscore=0
 phishscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2312140111
X-Proofpoint-GUID: ueI6-cHM-8fPcjlby4IstjDopYl7XlgW
X-Proofpoint-ORIG-GUID: ueI6-cHM-8fPcjlby4IstjDopYl7XlgW
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 14 Dec 2023 07:46:57 -0800 (PST)

On 14/12/2023 14:37, Christoph Hellwig wrote:
> On Wed, Dec 13, 2023 at 04:27:35PM +0000, John Garry wrote:
>>>> Are there any patches yet for the change to always use SGLs for transfers
>>>> larger than a single PRP?
>>> No.
> Here is the WIP version.  With that you'd need to make atomic writes
> conditional on !ctrl->need_virt_boundary.

Cheers, I gave it a quick spin and on the surface looks ok.

# more /sys/block/nvme0n1/queue/atomic_write_unit_max_bytes
262144
# more /sys/block/nvme0n1/queue/virt_boundary_mask
0