Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Thu, 14 Dec 2023 15:56:52 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Jianhua Lu <lujianhua000@gmail.com>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Banajit Goswami <bgoswami@quicinc.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] ASoC: qcom: common: Add qcom_snd_tdm_hw_params
 function
Message-ID: <bee0ab28-6bd3-4904-8afc-44fe7ddacb79@sirena.org.uk>
References: <20231213123556.20469-1-lujianhua000@gmail.com>
 <7b13b8b6-9048-48a3-b1a1-e62de88e8171@sirena.org.uk>
 <ZXsklsO7nOqBFgzt@Gentoo>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="3QwHa6JjLmRb9NBb"
Content-Disposition: inline
In-Reply-To: <ZXsklsO7nOqBFgzt@Gentoo>
Precedence: bulk


--3QwHa6JjLmRb9NBb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Dec 14, 2023 at 11:51:50PM +0800, Jianhua Lu wrote:
> On Thu, Dec 14, 2023 at 11:11:06AM +0000, Mark Brown wrote:

> > The expectation is that TDM is set up by the machine driver, not from
> > hw_params - if the TDM setup can be changed from within hw_params then
> > it's hard to see how it's going to interact well with other TDM users on
> > the bus.  More usually hw_params() would be influenced by the setup done
> > in set_tdm_slot().

> Currently, qcom TDM setup need to read hw_params, if we want to move it
> to machine driver, we must hardcode some params, but it will reduce reduce
> readability.

What makes you say that TDM setup needs to read hw_params?

--3QwHa6JjLmRb9NBb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEyBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmV7JcMACgkQJNaLcl1U
h9CY+gf3YsZTfcu/vz6WuiAEAFNcmWZVpApi5hN7KrHcB7qQWGfbWcivQWhFfiFc
2HsD9BS9nkFG8HWmHz2DKgZltPNOIIVLnaHLBS6IaFqXCqDkWdDDpVmYTBCcIsSV
Ls8IlGaVn9ddGf//+9sCcG1yIVnEj2NXqCHSM6EcDwNRy+kvGz9UG8pKYd2clgMv
eVraA+qIr2R0jePWFgGuYGwrmy2O6/u0LHkjCnbUABHA2g8hGRvbv/Rv6IW1zKbb
D013IGVbR1TkUWGlVU5b6AOS6DLlHMwIYwqaa5Gw1EQ/Q0S2J5N5105UGICxqVBA
p1yWhSlzFo3Tjs7PQxsTZV3DHmFx
=WcEt
-----END PGP SIGNATURE-----

--3QwHa6JjLmRb9NBb--