Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6099348rdb; Thu, 14 Dec 2023 08:16:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/RcquULUKYfBolaZinFdvMBITtXVeNortQxvkhqVeNk1RGd3dccxnIouucofrsn48P/0z X-Received: by 2002:a05:6a20:c11d:b0:181:74fe:ba83 with SMTP id bh29-20020a056a20c11d00b0018174feba83mr4695021pzb.40.1702570565289; Thu, 14 Dec 2023 08:16:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702570565; cv=none; d=google.com; s=arc-20160816; b=onK/kyVwciytRWZ3DUE6w7bp67R92OZu4j1czzEV36cd0/h7lsWrkhT1WhFHwDK5iD bbG+QUnxoo275AhWPwXijlX8wJ3XTp44jYQ5MdE1xetvKO8Jih/x6OCAoR1rKbF15n5h By+qdOK84ERa30utTgKOtzJXt82AZLI0YfOHUWG3xOYoD4YKIc34piV7licJaGn/9/7x v0ag87RTO+nfqPkJrxPQEfMH1O+XOmGqv/RGvjTgtqJymMWidNFjaje1tDncYPleQeyq IY8TtHYLYdpaull9anz7jAr1UT+0oLl5vYDmFtkka8fax2HKD/+bB8TtXRjDK0ZcBjQl JwIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=z1Ou2BN/NSSGCNvRe4VvolyrUm7oUAf2oh76V3K9T9M=; fh=nt8Pf/q23huXPsU7HBfe7mqIazU73yESuI6HujKTB+0=; b=HRJmfT1fyPIN4Ia1lQ9XNWi5YAJQIm9fxo7VsoyRGV43OmPUC5vILX+MOchcsR9j4r C3Z37a7qu7mhXDDXOWtqqMJEUNUEiLUzfmjinVhWA+S//WY0uPQyPZ1SrOw7cq+skKGk kYtfBNzh1LhUfI5p/l8x/zSppJOqbYHKk2geObZfHDpKxfQ3iZVp/gkTa/4AubyWoFb0 amzcNZCgEn0HPrJZDEG9/djlKo4iHmnR5VjQtnQmLZFyCwnSJWg9wVZjC2cjtNpv01Yn bKg9K1OjumbYZCjryOMAc20t1k8r85Cfx4SsMTb8obD4S5dMVc9Aj0pBNo8C8FwN6ABX qvfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ZkSvzWFe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id j20-20020a635954000000b005b9a149e61esi11653524pgm.649.2023.12.14.08.16.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 08:16:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ZkSvzWFe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id C454C807E461; Thu, 14 Dec 2023 08:15:15 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230179AbjLNQPB (ORCPT + 99 others); Thu, 14 Dec 2023 11:15:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbjLNQO7 (ORCPT ); Thu, 14 Dec 2023 11:14:59 -0500 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4827B115 for ; Thu, 14 Dec 2023 08:15:05 -0800 (PST) Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1d351cb8b82so10267965ad.3 for ; Thu, 14 Dec 2023 08:15:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1702570505; x=1703175305; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=z1Ou2BN/NSSGCNvRe4VvolyrUm7oUAf2oh76V3K9T9M=; b=ZkSvzWFe4GfrTmBb8iUOsSMZShHZoC/6pFizlZJfB9ONOgN3UTUwkKgX7kuJyqDJbT kavajsdaTI6rnXuGy85d33h+u8VKloOrALanp91z+RAAw++psw1KGHgu8zFL0gR5oymo S2PjEMBmoHCB52+2P6XENFdmySM51D5bZWxYQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702570505; x=1703175305; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=z1Ou2BN/NSSGCNvRe4VvolyrUm7oUAf2oh76V3K9T9M=; b=dPMI5SJNVpqLxGVB+pFTPqalGG2meZ1D9yfk5MiAuT0miTOGGIZk95c4rx9AbcKD+G FJasHksMUf3FGSm3dVJJedat57ZxYZsjMWMzvjKJlRS5E2RXFoR0rDWhzNv4vvFrqUHx 5xdQjrkkdwFGWecTGwxp9kfM1MGHrwU2gJ3adwckskEk6XOUeL1f/HIt1ovGrNoTLFHD Qm0EhXJoeofYKX26TapuHlVkaqvfHA0LDK3coaIA/zQ3SpOyk62ZQGhfJmbhEcFB2RnX F/w2SfPNg5T/J8+dRqTd4ED1+1kzGFazCpZ2bsbNjt9MazI7N8Xv9yokdMl24W/uzzHU a5qw== X-Gm-Message-State: AOJu0Yw7XQqNuN/FxtM1oWwYqWgBVSGv61Gk2xGQugyV3/XVYZPc8ZVU jWzdfeZeMQ26HAKk5Jrsk5JBSw== X-Received: by 2002:a17:902:eb82:b0:1d3:4c35:17a0 with SMTP id q2-20020a170902eb8200b001d34c3517a0mr1926746plg.120.1702570504783; Thu, 14 Dec 2023 08:15:04 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id n6-20020a170902e54600b001d1cd7e4ad2sm12549781plf.125.2023.12.14.08.15.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 08:15:04 -0800 (PST) Date: Thu, 14 Dec 2023 08:15:03 -0800 From: Kees Cook To: davidgow@google.com Cc: Rae Moar , Brendan Higgins , Greg Kroah-Hartman , Matti Vaittinen , Stephen Boyd , Shuah Khan , Jonathan Corbet , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Maxime Ripard , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-sound@vger.kernel.org Subject: Re: [PATCH v3 3/5] overflow: Replace fake root_device with kunit_device Message-ID: <202312140814.314B59CD@keescook> References: <20231214-kunit_bus-v3-0-7e9a287d3048@google.com> <20231214-kunit_bus-v3-3-7e9a287d3048@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231214-kunit_bus-v3-3-7e9a287d3048@google.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 14 Dec 2023 08:15:16 -0800 (PST) On Thu, Dec 14, 2023 at 04:49:17PM +0800, davidgow@google.com wrote: > Using struct root_device to create fake devices for tests is something > of a hack. The new struct kunit_device is meant for this purpose, so use > it instead. > > Reviewed-by: Matti Vaittinen > Signed-off-by: David Gow Acked-by: Kees Cook -- Kees Cook