Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Javier Carrasco <javier.carrasco@wolfvision.net>
Date:   Thu, 14 Dec 2023 17:29:11 +0100
Subject: [PATCH v2 3/4] usb: typec: tipd: declare in_data in as const in
 exec_cmd functions
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20231207-tps6598x_update-v2-3-f3cfcde6d890@wolfvision.net>
References: <20231207-tps6598x_update-v2-0-f3cfcde6d890@wolfvision.net>
In-Reply-To: <20231207-tps6598x_update-v2-0-f3cfcde6d890@wolfvision.net>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Javier Carrasco <javier.carrasco@wolfvision.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Uk5qSlRzeEpSK1BPci82LzBNRSswdk5HQlVVK3FySmxuWXNGWDNpZU0zcjZR?=
 =?utf-8?B?N0NUdEIxMWVTTGR6RVdza1BLN1FGZVB0emszTzBHWGI1WG9VN1hPSUYwNFBY?=
 =?utf-8?B?QTdVMzZxUElBMm11UGJwRnhmaFlxd2w4TjE4d1IvVDhhSk9CbS9QcU82K3Za?=
 =?utf-8?B?bit6N1oycUlPM0tJQ3VCeDZ5WjA0NjRLUWN5T2tuZTRZSWJGZnRiZHhiWVdm?=
 =?utf-8?B?Qlo5aytMMktacHJEYi8rVlU4Wk1uUjhoQjRZYndLWGI4WkY3K0c5N3ZuZlpU?=
 =?utf-8?B?aGxuUkdPQ2hZUDBoQWdLL005QTZ1Vmt6Nm9rNk5ua2pSN2JRRkFiaDJYNkti?=
 =?utf-8?B?WVc0b29YbUlPR1NJUmxhb3NSYWFHa2JQUnNFT1p4bXlWeE8ybkgzOWtUajl6?=
 =?utf-8?B?eVlEK1RNeFB5b0ZFU1dCSERIUlBkOUFVYUozSDZpOXp5UHRVajhuczRKUFRn?=
 =?utf-8?B?WmJTTzJnUWxkQ2FaSTNYbHN5TlhLM0NjZTdTV0NOc1lnd1hRR1NITEZEdHhZ?=
 =?utf-8?B?U3M5MkRlMUFibGpvajVLNmZkU1dLdS80K1lxZ3RHV3FMK1lIbnh5M3haQmE0?=
 =?utf-8?B?RUZYWk5GTm9IUkJieFk3ajZaTmNMQ0I1dDI2aWYwSmZFNnN6c09RRkZ6a2x0?=
 =?utf-8?B?Q1pQWFoxbEV4a2M1Nnd0NjlNcEx3YnplUGRYUHRlN3kvYjVKWCtqWkdSOGYw?=
 =?utf-8?B?WFlXb1dsUHJNQ2xtK3BxMTYrVzRMT2xCTzVMTVpsN2FVV05zN2xGZUR4K21S?=
 =?utf-8?B?NVdiL3pBNGJwdkppQ2xSeDZwNmRQTGM5ZlVzK1VMUms0WXdxUm5SWVg2Zldw?=
 =?utf-8?B?bkhmc0x5dTRHRE9xNXBuYytrU0ZTeUZ2Qlg2d0k4VVZ4blNFNkxucWlJdkNC?=
 =?utf-8?B?L3JWbmttN2d3OS9DeklWcWRwanNQRlBwSC9Zd0xUQnJYeDY1OWtUV1JsSTV0?=
 =?utf-8?B?dS9HcUZaWWQ1WHhNMjJpbWZpN3dCTURxZ1lENGxrSzNNNGxnWFYwaXJNcEpp?=
 =?utf-8?B?Uk1hdDFhNnptNlY0SGRXNC9mVEN6aG9TREhtYnJQUk91V2wzeXdQNW93L3Rl?=
 =?utf-8?B?OHFrbmVDTFlYVHdnaGFoSVo3MEtDT0UyS29YeGxKZmxkeXpxVndCQWVKbHZJ?=
 =?utf-8?B?VWpvSVNzTUpldysxQW5ydVZQTXVxVGo4WWFUN3RWbVUraHRNNG9UMkwvVVow?=
 =?utf-8?B?VldWdnNtNjlEN0lobGZCQlRReUVML0RDZTNDb0JhUFlRR09ydXhRcWM3NnN0?=
 =?utf-8?B?UHVMeHJ6YlhwSjJveFBiNlFXdHBKYmNlRkwxbVFQYXYxTk0wTjZTd21mbCtC?=
 =?utf-8?B?RWpYcHozR29ZaktweWFIbVEzYXZyZ1A1VXoySjZFKzFLTTdMcmhQWXY4cm9N?=
 =?utf-8?B?bUc2WFlNWTVSRk5Ia1pBSkxSZzdod0ZncnlJTnJLOElsdzZZYTdnVlpuTkNs?=
 =?utf-8?B?Zkp0cUJrbkhITHhMTTBwYWJhcnVHMWh0Wm52VGRIblVyNnZ1SGZtcHU3dko5?=
 =?utf-8?B?OTgvU2NDYSt6eGd2cGpUMVNIOERlbEQrRnhnRXNWUmFPa3NpR1J1WnBjVmM1?=
 =?utf-8?B?cGJSc3R3SmNJZ2VEVTN3emRuNlF3TG5PVmc3TThWNlB3ZnM0ZzZ1dDB1c09m?=
 =?utf-8?B?d3YrRkNacHk3aEQwQW5HSWFJczRaamtlbDdTcEh3VisrblkrZENWcDA5cDRo?=
 =?utf-8?B?aFBtTVFlMS9DNUdwTmFOU1FXUmo4YnZwRFNuMkZ6c2phWWFLbnM1R1M0ei9H?=
 =?utf-8?B?NlYyTUhiN1pKeDhIOXFyUjZEblZQdkxNVGlEejk5dm1GNzBWZ092RjMxUktm?=
 =?utf-8?B?MndtQndhRGp3bGRtNDdaWnhrZmU4djIxWEQwd0xIQjJEZjU2UmlwZVNPOVdv?=
 =?utf-8?B?VkswK0ZDR1EzNmNOVkZUbnZ0MTdFcGVFT2NwVzRBQytYQm4vT3pTT21nQU1p?=
 =?utf-8?B?QmxyRitCVlRYekdjNDdqMGcxc1lyNkpObzdpU1pqWkNEUnFyU3V3ZUVpMmh0?=
 =?utf-8?B?TW5BTmxPN1BTbjU0S0s2Q01KQ3V6NFFHQVZuUk5nV0Y2YTQ3SE56M1NPV2hV?=
 =?utf-8?B?cDBrL3pRM0pmaXpYY213Uy9SNFVzK1JVczRMNmFCcWZaRC9sYm1VR3c5bmFU?=
 =?utf-8?B?UkE2dlpYTHhvaXBzMHdGQUR6Y2l6ZFpLaDFOYXBSWE1QY1k5S0V0YXpCTHNo?=
 =?utf-8?Q?hjeJpHXGrjIXEHCZPAGasBo=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: d396dd6f-1995-445e-708a-08dbfcc1d0e3
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 16:29:16.7878
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8gAqaoFCD69lPL89BonTnrsUDM8zLav8QsjB347qJzPG9N8iqnnyZfbF4u+A5y3wW1I9EOMrxufWmj/0QdYF+UwJW6x5Rr5d8yErbvi6dcc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8302
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 14 Dec 2023 08:29:35 -0800 (PST)

The input data passed to execute commands with tps6598x_exec_cmd()
is not supposed to be modified by the function. Moreover, this data is
passed to tps6598x_exec_cmd_tmo() and finally to tps6598x_block_write(),
which expects a const pointer.

The current implementation does not produce any bugs, but it discards
const qualifiers from the pointers passed as arguments. This leads to
compile issues if 'discarded-qualifiers' is active and a const pointer
is passed to the function, which is the case if data from a firmware
structure is passed to execute update commands. Adding the const
modifier to in_data prevents such issues and provides code consistency.

Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net>
---
 drivers/usb/typec/tipd/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index 83e5eeecdf5c..7f4bbc0629b0 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -330,7 +330,7 @@ static void tps6598x_disconnect(struct tps6598x *tps, u32 status)
 }
 
 static int tps6598x_exec_cmd_tmo(struct tps6598x *tps, const char *cmd,
-			     size_t in_len, u8 *in_data,
+			     size_t in_len, const u8 *in_data,
 			     size_t out_len, u8 *out_data,
 			     u32 cmd_timeout_ms, u32 res_delay_ms)
 {
@@ -396,7 +396,7 @@ static int tps6598x_exec_cmd_tmo(struct tps6598x *tps, const char *cmd,
 }
 
 static int tps6598x_exec_cmd(struct tps6598x *tps, const char *cmd,
-			     size_t in_len, u8 *in_data,
+			     size_t in_len, const u8 *in_data,
 			     size_t out_len, u8 *out_data)
 {
 	return tps6598x_exec_cmd_tmo(tps, cmd, in_len, in_data,

-- 
2.39.2