Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   Javier Carrasco <javier.carrasco@wolfvision.net>
Date:   Thu, 14 Dec 2023 17:29:10 +0100
Subject: [PATCH v2 2/4] usb: typec: tipd: add function to request firmware
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20231207-tps6598x_update-v2-2-f3cfcde6d890@wolfvision.net>
References: <20231207-tps6598x_update-v2-0-f3cfcde6d890@wolfvision.net>
In-Reply-To: <20231207-tps6598x_update-v2-0-f3cfcde6d890@wolfvision.net>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Javier Carrasco <javier.carrasco@wolfvision.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2RWeGMxbldxUlFWdlR6QmpJVlFaOUgzY0Y0VHpmdlkyY3Z0V1kxc1VxWE8v?=
 =?utf-8?B?VTNiSUllZDk5bzVqUWh1VXFENFZSRWtHS3djOTFsK3J6ZjlBcjVnanhPdXl4?=
 =?utf-8?B?TDlGNmJoUHY2WUxUUEdZNWJDd2ozVEt0SFFYUWkvdzhReXBhTHZyamJCY3dO?=
 =?utf-8?B?Z0ZaTWlTMHVGVzNabmNlbnBSMVRKOWxHYXR1THJGR0NwUWlQcWt3VEpmbmFj?=
 =?utf-8?B?SFNlQWU1TUdIejIyaFBuSktRWlZMcHJseG1RUDIwQVNhdm5pZTd1SVlNek1B?=
 =?utf-8?B?ZE5naDlIaUVsOUpNaGV4MzFYUlZIK1JacGxzSWh2aytSSlBuSktxTnQxYUlm?=
 =?utf-8?B?dXN6bmx6cEpEcm8yUkFJcEN0dGtHMzBGR2ZLYTJlR25HUE5hZjE1MldRbGZE?=
 =?utf-8?B?U1dycDFHbmFDNEljUXVMWEc1NE5RTWVMVUxmOVF5ZnlCWHJjUG0xVjErbFdB?=
 =?utf-8?B?VDZrWThZVGtkeVZxOWdJZVRpWjY1L3F2aUJCK0tKYk5XWFZDWkZMaEREVzV0?=
 =?utf-8?B?Y3p1RFN6TVMxRmJwWTkxRkZzWTFSVDJWdGtuZ0ViY1hFUThuSDRFNTJpdHNi?=
 =?utf-8?B?cnN3RFJ4TVJRUlB4bHFHa24yVDlQck5ZQXBaQUJhWWI1SUFVNXUzK2N5a1B2?=
 =?utf-8?B?aWpSem16bkczKzY2Z3orajZyQllTRWZUb1B5eGMzeFhyUU9hdEJBcjZpNGpq?=
 =?utf-8?B?ajRZWnl5d09uNVlNRlNYNVM4c21Qdm5DeDRiTElGbFczNVBXMVptT1pLT2Y2?=
 =?utf-8?B?STNISzJmaElCU1pJN3h5LzFvYXZyU1paRFRQdUNsRVlQS2I1NnNQM2FmTVVM?=
 =?utf-8?B?bng4L0ltVnVqYVNoS3R2UDZxdWI3WXpSOU5mMnBsSkUrQmY1M0d1enRodHd3?=
 =?utf-8?B?K3EyMURpdE90L0JNS2FBeGpUaktGdmN5dWVFSTZOZTVxUG9sYVZ5S3padWZU?=
 =?utf-8?B?Nm1WQ0FWRzNqM1U2VUI5SVlSZHdRM3Q0amI3S1pmTE1JVmF4Qk5VaWtmY2Mr?=
 =?utf-8?B?ZnZuYmJMWnk5UFpkcWpBQVJkYmU2TU5kSDhWSDhYbkRmalE3WUdDWkZ6aUVj?=
 =?utf-8?B?VThON2l6L3c2MEN2amNPSy9wY1U3WFVldWhMNEVUdDIwZnlYS0FoaVd0bjJa?=
 =?utf-8?B?bmpZbnZDU3RUYXhJQ0o5R2VlclRENXhITExyYmkwZjNHODUzQmE4YnlpN1VE?=
 =?utf-8?B?ZDEvNy9WbXkwRHF5aWJvUzVTRUtidjYwMDcyUmNlL3BkaG1wNGhwUVBvUVVm?=
 =?utf-8?B?Mzd5b1pTTHZYY0MyU3NBRzh4UXlGcUxMRDhIY29hb0pFU3RiZDhWMnRhMDUr?=
 =?utf-8?B?MGJKSlZuV2FFWEd4dFJsaWpteDB4M0NIMFdUSDg4Z0xnNUV1cmhETVRuanNO?=
 =?utf-8?B?TkZWYlJJNmZGQktCRlhjNnRYVzlmVGhUODBCb0xEV2hjT3FYTVJDR0hjY2h4?=
 =?utf-8?B?WDliQzZVd0pVcDNjZjhhUUxMeWtIdktPR1ZJRC9EK3V0VlpseFZUaVJrSEY5?=
 =?utf-8?B?c3hOY3FUM1ozMTg1dDlFWFVkMXFmV3ZVTnJxOFNjcE4xNFpSbHAzWEc2S2F4?=
 =?utf-8?B?U2l3TzNpMXFmdDhpVll2MnNtV0U2ZW9VMFFlUmdyYW1TQnBnRnd6U2NucWMv?=
 =?utf-8?B?cFNRQzluWTVkcWdNY1hRc2VNRmVtaGR3eWxiWDRHVFlRcEZ6RVJaOVFuQU1V?=
 =?utf-8?B?RW1TVXIrbVozSGNPTzU2YTZLZng0VHJxOXl0VUhjcUNRdzExL0t2UldnSXZN?=
 =?utf-8?B?ZGF1VE53aTZ5cEN5bE84UkZlQWJoMXp4TDlqUVoyTWNXMGpHS01CRitzVzdk?=
 =?utf-8?B?cHloMlgyaVh2UFo2Mm1LcWxpTUpYTGNkcG8vOU1OSFFna0t1NzVjc2xpSEZj?=
 =?utf-8?B?cEJtR203VEhlMGt6RVVVTklwRVVtaDhRc3l5REkxMzB5NDhLbVpwYUI5UWMy?=
 =?utf-8?B?QUNleENGejVLSktmMU5idklpSEVJWnFHN1FCbUNxR1d6dHJ3a0U1NHF2UnRU?=
 =?utf-8?B?MWVzQ3VscysrU0k1d3VucFdRMkdwbnV1UFJ6Vlc3NTdJMTdnZzNZWitUK2hR?=
 =?utf-8?B?MzVia1krR0pyektuUFhwTGVydlc4R2UwYnpJY1RZRDhCTFNQdkJEaDFOZUhJ?=
 =?utf-8?B?eFNDa202UER4Rm0rSFZDT25IMjhuVEtaR2svbytYRitrbU5wS2liTWxTR2pa?=
 =?utf-8?Q?kW0pCi6AiDJiUfadRBG0LTs=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 48531cf0-c2f1-4d82-9c25-08dbfcc1d08d
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 16:29:16.2077
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P6aWcS4NVFV9qzCNh6ULaQtrwrBgBZDIXjQ8nTTnsEpZTCIsfGaGjCMChrpCQjiXLeE3F+OexB+k1eDss9BT14SUw9zIBLxhWFOZg3BTAKY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8302
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 14 Dec 2023 08:29:43 -0800 (PST)

The firmware request process is device agnostic and can be used for
other parts.

Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net>
---
 drivers/usb/typec/tipd/core.c | 35 ++++++++++++++++++++++++++---------
 1 file changed, 26 insertions(+), 9 deletions(-)

diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index f0c4cd571a37..83e5eeecdf5c 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -873,6 +873,30 @@ tps6598x_register_port(struct tps6598x *tps, struct fwnode_handle *fwnode)
 	return 0;
 }
 
+static int tps_request_firmware(struct tps6598x *tps, const struct firmware **fw)
+{
+	const char *firmware_name;
+	int ret;
+
+	ret = device_property_read_string(tps->dev, "firmware-name",
+					  &firmware_name);
+	if (ret)
+		return ret;
+
+	ret = request_firmware(fw, firmware_name, tps->dev);
+	if (ret) {
+		dev_err(tps->dev, "failed to retrieve \"%s\"\n", firmware_name);
+		return ret;
+	}
+
+	if ((*fw)->size == 0) {
+		release_firmware(*fw);
+		ret = -EINVAL;
+	}
+
+	return ret;
+}
+
 static int
 tps25750_write_firmware(struct tps6598x *tps,
 			u8 bpms_addr, const u8 *data, size_t len)
@@ -961,16 +985,9 @@ static int tps25750_start_patch_burst_mode(struct tps6598x *tps)
 	if (ret)
 		return ret;
 
-	ret = request_firmware(&fw, firmware_name, tps->dev);
-	if (ret) {
-		dev_err(tps->dev, "failed to retrieve \"%s\"\n", firmware_name);
+	ret = tps_request_firmware(tps, &fw);
+	if (ret)
 		return ret;
-	}
-
-	if (fw->size == 0) {
-		ret = -EINVAL;
-		goto release_fw;
-	}
 
 	ret = of_property_match_string(np, "reg-names", "patch-address");
 	if (ret < 0) {

-- 
2.39.2