Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6116788rdb; Thu, 14 Dec 2023 08:43:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IEp1MBp4z3oR6B3AA/KhtH+HFYeF8sj/DRS9YWigXYQvc6siq73c4yCqO3oPn2kItK1G+cA X-Received: by 2002:a17:902:6806:b0:1d3:5879:d591 with SMTP id h6-20020a170902680600b001d35879d591mr1583703plk.20.1702572182714; Thu, 14 Dec 2023 08:43:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702572182; cv=none; d=google.com; s=arc-20160816; b=bIPcz8OimWLv89fIbZV58wXp05t14ZMb6poiMiPGIJhrOFGCm8QysUb7tMoQCrfRsp mKk7rtUsaM2jdovrAevpwce7D68NRbBW5Y6/MNVZgDJ+UtCjQlXLIJNGVSmgAp64X4Xd aOHMGP3EDSvtzbCjoxLW+LkEx0yCFLCMDQ3TrZSvuzhsVj8BdWDVRZO2R6OLeJqGaBV8 x+NiEBN+uCM0WKXceLdQnzALdFfqKLn+mTTNF9jSWwcWV6GY/2nTZ110UGqxp1YwfJ+7 HNwf/5x/C5TugA2UgSwgZcPNf1KQhKaK7/XkC4pTFc59woQzZ6iTopHS9Ig/SwuJ/ukz i35g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=k2TqcXvQkdwSeIxXVKgePBpInamqAk+/o8OVNT+EtrM=; fh=uIzItq1WNN5EySvBQ/743ZuhDMpcme4AAoJHtVn++r8=; b=ATnflCiEzm99tKT/05XTFyYtQa0uQ48Eel2GcT/5FZYsIV8ukNGORcwRytTmeYjrSc 3af48jpdySuRg6y6auU35kWS3905wDqtH1bt7267cG4exE2bwliFLszt/gEUZYYsWLOm 4R9wE3Q78jX8V/f10ZNr9fYVg4mYmnlJL1oAV0Wo+qJLCaHWjcH7L3g7zjzhr9zEUfF+ iVuGbjEnu/+lJLfiZqFpuAC0xulUfPZZvpLCbzL1MVng9qb4LFDrmDdoLDxQ1ipjc0dp WsFR0/oOiHlU6gmXOSF/lRaZd+dw4qgP22ItFT8kkkFSl/xuFj8R1knxSffSDGY2ozux FNEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=sz0m5ZgY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id jw1-20020a170903278100b001d0068a4a3dsi11422724plb.410.2023.12.14.08.43.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 08:43:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=sz0m5ZgY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 3827180DF26C; Thu, 14 Dec 2023 08:43:01 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229862AbjLNQmv (ORCPT + 99 others); Thu, 14 Dec 2023 11:42:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229957AbjLNQmu (ORCPT ); Thu, 14 Dec 2023 11:42:50 -0500 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [IPv6:2a00:1098:ed:100::25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A55F114; Thu, 14 Dec 2023 08:42:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1702572174; bh=04lraI2c4Uv8FYflDBQHgnQ/5ptT6GN6bQzxy23YiUU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=sz0m5ZgYDE5dfllYDKZomUG52RmngQJQu77ZBXrDUYIcZoX9EFgXRibxckiUF0Jd+ 5KgHwKtwN3Hsz/0K74YqlYUZWsI5XU1l7F+CvSVGnej+Trnajb/7irngCFx7r1t7KK NsraIMCCwPmUw5WZ0rMheceXvFOPktPSosJ7wBtqEBpOG2/LuF5Yd0yaoyN9sIU8CK /z885ZZ288pzv1SGfrOglWYZVyUIDvtmirN0sp45HBArOJsV8R7iqlfAAI7+77k8Te gvNq0cJXuP9wrZUDu4xDOeUyUr22iUUvszu/EoAnx46q3L3qaWO3hHITnPDyQ3xQmr 2cUdUzLu1reEQ== Received: from [100.115.223.179] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 89F7D37809D0; Thu, 14 Dec 2023 16:42:53 +0000 (UTC) Message-ID: <913257d4-75dc-4887-97d6-0f206c401057@collabora.com> Date: Thu, 14 Dec 2023 18:42:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/11] ASoC: SOF: topology: Add new DAI type entry for SOF_DAI_AMD_BT Content-Language: en-US To: Venkata Prasad Potturu , Mark Brown Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Pierre-Louis Bossart , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Daniel Baluta , Kai Vehmanen , Alper Nebi Yasak , Syed Saba Kareem , Kuninori Morimoto , Marian Postevca , Vijendar Mukunda , V sujith kumar Reddy , Mastan Katragadda , Ajit Kumar Pandey , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, sound-open-firmware@alsa-project.org, kernel@collabora.com References: <20231209205351.880797-1-cristian.ciocaltea@collabora.com> <20231209205351.880797-12-cristian.ciocaltea@collabora.com> <318470ce-1631-4c46-b425-755c877dda65@amd.com> <421128f7-6a17-4be9-a72b-272ea4017fbd@collabora.com> <5095ce7b-13bd-4805-b81e-f7565ab41b67@collabora.com> <0de8f81b-e7d4-43f6-b011-eb6ee09cc7fe@amd.com> From: Cristian Ciocaltea In-Reply-To: <0de8f81b-e7d4-43f6-b011-eb6ee09cc7fe@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 14 Dec 2023 08:43:01 -0800 (PST) On 12/14/23 15:15, Venkata Prasad Potturu wrote: > > On 12/14/23 17:53, Cristian Ciocaltea wrote: >> On 12/11/23 07:58, Venkata Prasad Potturu wrote: >>> On 12/10/23 21:20, Cristian Ciocaltea wrote: >>>> On 12/10/23 16:01, Mark Brown wrote: >>>>> On Sun, Dec 10, 2023 at 12:12:53PM +0200, Cristian Ciocaltea wrote: >>>>>> On 12/10/23 11:51, Venkata Prasad Potturu wrote: >>>>>>> This should send to SOF git repo for rewiew, once SOF reviewers >>>>>>> approved >>>>>>> this, again need to send to broonie git. >>>>>>> All the changes in sound/soc/sof/ path should go to SOF git. >>>>>> Unfortunately I'm not familiar with the SOF dev workflow. So it's not >>>>>> enough to have this patch cc-ed to >>>>>> sound-open-firmware@alsa-project.org? >>>>> The SOF people basically do their own thing in github at >>>>> >>>>>      https://github.com/thesofproject/linux >>>>> >>>>> with a github workflow and submit their patches upstream in batches a >>>>> few times a release, however my understanding is that their >>>>> workflow can >>>>> cope with things going in directly upstream as well. >>>> Thanks for clarifying, Mark!  That would greatly simplify and speedup >>>> the whole process, at least for trivial patches like this one. >>> Hi Cristian, >>> >>> We have created a Pull request in SOF git hub for I2S BT support. >>> please hold v2 version SOF patches till below PR get's merged. >>> PR:- https://github.com/thesofproject/linux/pull/4742 >> Hi Venkata, >> >> If this is going to be handled via the github workflow, this patch >> should be removed from the series.  Since there is no dependency on it, >> I cannot see a reason to put v2 on hold. >> >> Do I miss something? > Non-sof driver related patches can directly send to broonie git ad v2 > series. > SOF driver patches should send to SOF github to avoid merge conflicts > as  per guidelines of SOF community. Honestly, I don't really see a high risk of conflicts, the patches are not that complex and can be simply cherry-picked when needed. Moreover, as we already had people reviewing this, splitting this up will only add confusion and unnecessary burden. Are there any specific changes you are concerned about and cannot be really handled here?