Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6155142rdb; Thu, 14 Dec 2023 09:39:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IFN7NJeJxOo64ZGuq7PfQdOSEGuwZPCdEG/7QTiEXHxs2tZC1TPkDs6HeWSjgc4lWiizvkX X-Received: by 2002:a17:902:f2ca:b0:1d3:47c6:b8fb with SMTP id h10-20020a170902f2ca00b001d347c6b8fbmr3888964plc.23.1702575554497; Thu, 14 Dec 2023 09:39:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702575554; cv=none; d=google.com; s=arc-20160816; b=JKV7GbihF1VyDHhjDfXguo8gmVGblThgyWm2h+6yNMpUahvr9rDSGqdSy+JmZqhkgb bsxboJvI3btmOfG62sbogaJsELZ6PXY59sfWVBEIEeTo9jByYYfwC/HHgvuGRAQcNB/O ON9NXKOv9qpoImcqh67/sRXCp2XoW7K8EKuDmo8OQ4SydWpT1nhuGBA4YUSHjUFK+u72 KzFK5UjyPTgr5uGMNVVj82rc94dOTuWWd7buVFpujfR/Ckz1BhySkla4ZmVVXePiM/m/ LmJVngimFWLYgds/A5DmDoSUMFw7M7siLDKtyfBs7VuvW3Zjd4Z0INqizLi/O3XlcZDq Assg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=lJMU3Ia+pknY44fzKVAHZPSTmsYBW7KBb38TSMzJr/c=; fh=M38NtZRGpKRAhU1Ixk+V2aStZ6nMSY0SWiH6rRqC2uo=; b=SZc723Oj36ZV/FX2qu9zyu3s3iObN6trdf9OLW98lLS+/eddQVuECm42B20voiqjj7 Qt+DhoTEn27jwjkpSWaQhcTg5uSbl6es0hPmmH47CPFf1y5DUkpglkmfDQW56KTJHJAE RiHM+T24ITLfiaD4dPswsVl+8aHXXelkpKF+UXtpWCSFR+uJwa1yL9Vi8sx6zsOEhK1m 9t7YrzQyUUO3ySoZ+wtS45IJlGfMHkUa80LiqFP981aZxJ5XmmD1rIkouTCP1be2q44v lyWOCASFQ7f/7nvV8JZGZ0AC9+MiBM/5TrCEjZOcKNnS/Q8jPgvmOqmdLg4wWxKTPIH1 0DzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PN906fd5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id c10-20020a170902724a00b001d09fdba96esi11506286pll.590.2023.12.14.09.39.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 09:39:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PN906fd5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id BD0A9826AC55; Thu, 14 Dec 2023 09:39:11 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1444067AbjLNRi5 (ORCPT + 99 others); Thu, 14 Dec 2023 12:38:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbjLNRi4 (ORCPT ); Thu, 14 Dec 2023 12:38:56 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2B6710E for ; Thu, 14 Dec 2023 09:39:01 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB98BC433C7; Thu, 14 Dec 2023 17:39:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702575541; bh=V/fbxsK7q1OnjNdRchrl8etLwYN7DQR4SahFULXkoe4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PN906fd563Q8HLlx91Hl7Dq4NFroiwUoyofjLvvPbk2wF8OvvtszM8A/AK2ycUTu9 BCGTLKaNEXbHvuKgeDjkYKLjeKmpeUiBOWK96sZbof20gqWp6ViVkE34qDhIr57LYd PfDssee2KM5WkvGXQ4xbH5nLcyFE66ZPnBYXx9JW+LPGbdE3WoUAqQNRPKfOXQiWZG obXvXu919sT/jBR2ZQdEqZJDo5bK8UTvY1E6dG/ur1BvAt9Tg2/tm1oMTfGfZAAg8I WzpZqyvZrb+/Vn+1TFd3opBt6eFsiLJW6N7lQLYtAnKJEVIFjn0gui03KHzZNyWM0b aBgPhDFE2qA5g== Date: Thu, 14 Dec 2023 09:38:59 -0800 From: Jakub Kicinski To: Ahelenia Ziemia'nska Cc: Jens Axboe , Christian Brauner , Tony Lu , Karsten Graul , Wenjia Zhang , Jan Karcher , "D. Wythe" , Wen Gu , "David S. Miller" , Eric Dumazet , Paolo Abeni , linux-s390@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Alexander Viro Subject: Re: [PATCH RESEND 06/11] net/smc: smc_splice_read: always request MSG_DONTWAIT Message-ID: <20231214093859.01f6e2cd@kernel.org> In-Reply-To: <3d025aeb-7766-4148-b2fd-01ec3653b4a7@kernel.dk> References: <145da5ab094bcc7d3331385e8813074922c2a13c6.1697486714.git.nabijaczleweli@nabijaczleweli.xyz> <20231213162854.4acfbd9f@kernel.org> <20231214-glimmen-abspielen-12b68e7cb3a7@brauner> <3d025aeb-7766-4148-b2fd-01ec3653b4a7@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 14 Dec 2023 09:39:12 -0800 (PST) On Thu, 14 Dec 2023 09:57:32 -0700 Jens Axboe wrote: > On 12/14/23 3:50 AM, Christian Brauner wrote: > >> Let's figure that out before we get another repost. > > > > I'm just waiting for Jens to review it as he had comments on this > > before. > > Well, I do wish the CC list had been setup a bit more deliberately. > Especially as this is a resend, and I didn't even know about any of this > before Christian pointed me this way the other day. > > Checking lore, I can't even see all the patches. So while it may be > annoying, I do think it may be a good idea to resend the series so I can > take a closer look as well. So to summarize - for the repost please make sure to CC Jens, Christian, Al, linux-fsdevel@vger.kernel.org on *all* patches. No need to add "net" to subject prefix, or CC net on all. > I do think it's interesting and I'd love to > have it work in a non-blocking fashion, both solving the issue of splice > holding the pipe lock while doing IO, and also then being able to > eliminate the pipe_clear_nowait() hack hopefully.