Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
References: <20231214-topic-undo_ddr_stats-v1-1-1fe32c258e56@linaro.org>
In-Reply-To: <20231214-topic-undo_ddr_stats-v1-1-1fe32c258e56@linaro.org>
From:   Doug Anderson <dianders@chromium.org>
Date:   Thu, 14 Dec 2023 09:48:24 -0800
Message-ID: <CAD=FV=W5V7XO-h7DXxQgqEYcN0R2oHTJ_3G06bY8tKGtjKySRg@mail.gmail.com>
Subject: Re: [PATCH] Revert "soc: qcom: stats: Add DDR sleep stats"
To:     Konrad Dybcio <konrad.dybcio@linaro.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Thu, Dec 14, 2023 at 4:25=E2=80=AFAM Konrad Dybcio <konrad.dybcio@linaro=
.org> wrote:
>
> After recent reports ([1], [2]) of older platforms (particularly 8150 and
> 7180) breaking after DDR sleep stats introduction, revert the following:
>
> Commit 73380e2573c3 ("soc: qcom: stats: fix 64-bit division")
> Commit e84e61bdb97c ("soc: qcom: stats: Add DDR sleep stats")
>
> The feature itself is rather useful for debugging DRAM power management,
> however it looks like the shared RPMh stats data structures differ on
> previous SoCs.
>
> Revert its addition for now to un-break booting on these earlier SoCs,
> while I try to come up with a better way to enable it conditionally.
>
> [1] https://lore.kernel.org/linux-arm-msm/20231209215601.3543895-2-dmitry=
.baryshkov@linaro.org/
> [2] https://lore.kernel.org/linux-arm-msm/CAD=3DFV=3DXX4wLg1NNVL15RK4D4tL=
vuSzZyUv=3Dk_tS4bSb3=3D7QJzQ@mail.gmail.com/
>
> Reported-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Reported-by: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  drivers/soc/qcom/qcom_stats.c | 187 +-----------------------------------=
------
>  1 file changed, 1 insertion(+), 186 deletions(-)

Tested-by: Douglas Anderson <dianders@chromium.org>