Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <1ce43346-3f60-b614-cdcc-7d9db8dec758@mediatek.com>
Date:   Fri, 15 Dec 2023 01:54:19 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] arm64: mediatek: remove broken pmic interrupt property
Content-Language: en-US
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Arnd Bergmann <arnd@kernel.org>, <soc@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Ben Lok <ben.lok@mediatek.com>
CC:     Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-mediatek@lists.infradead.org>, <bear.wang@mediatek.com>,
        <pablo.sun@mediatek.com>, <wenst@chromium.org>
References: <20231212214737.230115-1-arnd@kernel.org>
 <bc5dafe4-5487-4794-97f1-f4e4d967a665@collabora.com>
From:   Macpaul Lin <macpaul.lin@mediatek.com>
In-Reply-To: <bc5dafe4-5487-4794-97f1-f4e4d967a665@collabora.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 12/13/23 19:09, AngeloGioacchino Del Regno wrote:

> Il 12/12/23 22:47, Arnd Bergmann ha scritto:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The pmic is connected to the GIC, which uses four-cell interrupt 
>> properties,
>> but its interrupt is specified as two-cell that would only make sense 
>> for
>> the GPIO irqchip:
>>
>> arch/arm64/boot/dts/mediatek/mt8195.dtsi:464.4-27: Warning 
>> (interrupts_property): /soc/i2c@11d01000/pmic@34:#interrupt-cells: 
>> size is (8), expected multiple of 16
>>
>> Remove the interrupt for now to shut up the warning. When someone 
>> figures out
>> what the correct interrupt and parent are, we can add it back.
>>
>
> Please, can anyone from MediaTek comment on that?

Sorry for late response, I've just stuck in other tasks and didn't 
notice this

patch is for genio-1200-evk. I've tested 6.7-rc1 but I thought it might 
be an issue

in origin mt8195.dtsi and not be related to board dts.

> I see a mt6360_pins on PIO:
>             pinmux = <PINMUX_GPIO17__FUNC_GPIO17>,
>                  <PINMUX_GPIO128__FUNC_GPIO128>;
>
> ...and that's GPIO128, which may effectively be the IRQ pin for MT6360.
>
> Still, I'm not sure whether the interrupt is on GIC or PIO, please 
> clarify,
> otherwise we will have to get this commit upstream.
>
I think it could be solved by adding

'interrupt-parent = <&pio>;' to mt6360 node.

But currently I have no much time to verify it.

I'll try to find some time to find out the solution tomorrow.

> Thanks,
> Angelo
>
>> Fixes: f2b543a191b6 ("arm64: dts: mediatek: add device-tree for Genio 
>> 1200 EVK board")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>>   arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts 
>> b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
>> index 70b465f7c6a7..a409ef998746 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
>> @@ -238,8 +238,6 @@ &i2c6 {
>>       mt6360: pmic@34 {
>>           compatible = "mediatek,mt6360";
>>           reg = <0x34>;
>> -        interrupts = <128 IRQ_TYPE_EDGE_FALLING>;
>> -        interrupt-names = "IRQB";
>>           interrupt-controller;
>>           #interrupt-cells = <1>;
>>           pinctrl-0 = <&mt6360_pins>;
>

Thanks for pointing out the issue! Let's see if it could be solved by 
adding 'interrupt-parents'.

Macpaul Lin