Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <a8fa9a13-d49f-4f16-b99e-a128a5feedb2@intel.com>
Date:   Thu, 14 Dec 2023 10:10:29 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 01/29] selftests/resctrl: Convert perror() to
 ksft_perror() or ksft_print_msg()
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC:     <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        LKML <linux-kernel@vger.kernel.org>
References: <20231211121826.14392-1-ilpo.jarvinen@linux.intel.com>
 <20231211121826.14392-2-ilpo.jarvinen@linux.intel.com>
 <1e7ede83-ac80-43aa-a452-0f95b32d849c@intel.com>
 <c82b5c4-72e-c1ad-dce9-e5adf5d4a9b@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <c82b5c4-72e-c1ad-dce9-e5adf5d4a9b@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bWJCZElITWxUbjNyQlJMN2VwUndyWHQ3QzNRbTdOZW0rT1htWldOc25CbjRB?=
 =?utf-8?B?Y3kyMXp1R1lVcmgxOWExZDRJOEVvWU5CTTluU3RvZlJ0dnFmRjczc3NuQStY?=
 =?utf-8?B?TE5zbkpnZmo5LzVWSG9Ec1d6NnMyVStRVWI3ZVh6bHVERFlKcU1VK3RjbWxl?=
 =?utf-8?B?VWgwS2k3QURsd005bHVPOG5pbW1oZEduOUU5dUVSU083VEVYZDdUS250VGY2?=
 =?utf-8?B?eGtMOVZneENhSmFEOVovY3ZqQTV5eEhJaitxSE5ma1lNaGdJTmdhVW5QbkZM?=
 =?utf-8?B?UVJNbDdqZzJBbFBtdkxvNnhiRmN2eDI5Q2ZzODBnb2VPZEI3Mm56a25GckFN?=
 =?utf-8?B?SUt2enNDTjk5aG5FRDZ6YzJCZ2MxZ0ZzeDhjdlRObXhyOUtQZExTTmRrYVFx?=
 =?utf-8?B?NlR6amg0cTBiRUdHWnVvb0ZLRk9LSkVEYStJODJjbDIrcy9MWGgwdnYzY3F6?=
 =?utf-8?B?NWM4UmFaK1BOWVNseUpoSzZ1T2o4MnhJaUFHUTdjZ25WNTVKOUNVSkZnUWRT?=
 =?utf-8?B?ZzRLTm1Ga0pLUDExb0xSQTFyL2tCMkY4VllURFRqYzIrWjF4a2hTWnlNbGpx?=
 =?utf-8?B?SW9JY1I4WktjZ1ovWW9laUNtUWw3UzU1SWlBeTRveXFKaE9BZVA2aSt0R0x3?=
 =?utf-8?B?VGhIdkl6M2ErV1hsZTIwVTNuQUljUmdTZy8vK1M2R21OSFlBWXFpOUFoNmdu?=
 =?utf-8?B?STNpak43NlFqVjdYL3JuK3JUR2JURUdHQU9OYVUyNkh1alc3dVNqcHl5MmFX?=
 =?utf-8?B?K3dHU01XWE1zSXloV2YrZjlXMlQ5YXRQMTJheG1QZThOQWZOK2s4c2diYTVM?=
 =?utf-8?B?cVdDeWpqN0NxUnY2UGs5ZEhvQ0ZEUHlMeXgyK2g2Q3dGV0lxblduYlBMV3kz?=
 =?utf-8?B?WWJPU3g4aVlheTlyQTdJUUtmUHJzeWIrVS9JSTlKWUJ4ZXRuTzR0eENFY1cx?=
 =?utf-8?B?VGVYMkNqNnh5THl4WjF3QzM1am9lTXRLdm5CendkZjZnT2dqNlV6bURuakda?=
 =?utf-8?B?a0U1cVp5RnY1T01tcHZhcmhidEIvaTlhYTFINmN5RmZtYkxMWURBQytQd1ND?=
 =?utf-8?B?aFFGbHN4Sk1URXkwaEhudTMralc0eXV3cXN3WEt0Qzd0NTU2MVFGQ1dSc3RX?=
 =?utf-8?B?bnluRzNrMExwL0k5aTBuS25Vem5lWTlmUUwxbE9KSnZybnhCbjg2ekxDd1Av?=
 =?utf-8?B?OG9mNWxRc3FyclBHLzViWm9aMko0Y2ZLWnc4MWFrSzVNeCsxV2hkUGtKOWFD?=
 =?utf-8?B?SkNuRnN3U0ZaSEd1V2w4bzFqYlU2eHlMTmh3bFdRVEM1Z29kT3VrK2cva2lh?=
 =?utf-8?B?WHVFSjV6V29QS2RVVzB1ZlZ2S0EweFNwRC9YZm5BYUVOYVpNYzZtQ3ljT0dJ?=
 =?utf-8?B?K1BrME9RSXhjWWFaSWhVNXlYRnB5ZkRGVW5aRndETWR4MnJMeDlNSlM3ZXZ1?=
 =?utf-8?B?YUhaMkx2RDd2RlB0Z0hIYWtIekNpazZPVUZ5ZUFacU5TMVNJZU5xZmlmUm9M?=
 =?utf-8?B?cHJkSWhNNGh5U2toK3UxclBld2VZWExCTHk0V3YyQ0plTVZENUdFZ0paNUJj?=
 =?utf-8?B?MVc2UFpOUjBLbFp6VEJ0eUMySnZadjRMSjZFV29zUHlwZEZOSUV5MDIzcE96?=
 =?utf-8?B?RU5DT3FCTHFDeTIzQVRIOW1tVHZWUHZMekxUdHpvbm9Vam5Kckp2NnJQM3hk?=
 =?utf-8?B?LytMbUpib2RrWGRWUnF0L213eCtxSDM0dEVXanUyWjZLNnUzREJjaHRDa29S?=
 =?utf-8?B?dVZaQjFZUkRRdXVCaWJPRkQrRXZiNlp3T1daY3Z0UDYzUTVzcXJobjdQem9R?=
 =?utf-8?B?bnpSNmtKWXNIcTkzcjdSM08vR3FPdTlDMCtrekpyRkpNSDV4cll5QUtpMVlZ?=
 =?utf-8?B?bVVtT3pIZk15NkRSb3JxTW80aElvOHlRd1RXeEZwaVRjaG1POTlKUFViYklx?=
 =?utf-8?B?V3hDUzBzRkxmOUZPcEY3VHRmeGMyNUhjQm9PcG5OQUFkMDRlakFYQXZRSzhQ?=
 =?utf-8?B?SlEvNUxWbzlVUFRLd1JpOS9oSjd3OTg4L0IwdlZSQmczR0lKdytqblNXUGtz?=
 =?utf-8?B?UXJPc1J5UlFSMnVGUGRaSDJiMDlHZ3JBUUg3Q1RhQ1ppaGpaVU1Pc0h4am0y?=
 =?utf-8?B?KzMwd3NxOTVPakR2YkczelhkRmw4UmV4SitmRnJybXRGVU1IM1FLcVk0SG5i?=
 =?utf-8?B?Y0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4558c76c-75ee-4793-19df-08dbfccff58b
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 18:10:31.2380
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FmfDF4GPHHvd0miL3wnQzEDnRe8XuAuwg7Z6VE0wTbbaLNUBWc6R8Q+ejDJCNv+e1L9dt2xv563ViswNOnvaEicudOfPdomdi0pNbLPqeFg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6032
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 14 Dec 2023 10:10:52 -0800 (PST)

Hi Ilpo,

On 12/14/2023 2:12 AM, Ilpo Järvinen wrote:
> On Wed, 13 Dec 2023, Reinette Chatre wrote:
> 
>> Hi Ilpo,
>>
>> On 12/11/2023 4:17 AM, Ilpo Järvinen wrote:
>>> The resctrl selftest code contains a number of perror() calls. Some of
>>> them come with hash character and some don't. The kselftest framework
>>> provides ksft_perror() that is compatible with test output formatting
>>> so it should be used instead of adding custom hash signs.
>>>
>>> Some perror() calls are too far away from anything that sets error.
>>> For those call sites, ksft_print_msg() must be used instead.
>>>
>>> Convert perror() to ksft_perror() or ksft_print_msg().
>>>
>>> Other related changes:
>>> - Remove hash signs
>>> - Remove trailing stops & newlines from ksft_perror()
>>> - Add terminating newlines for converted ksft_print_msg()
>>> - Use consistent capitalization
>>>
>>
>> Another great cleanup. Also thanks for fixing some non-sensical messages.
>>
>> ...
>>
>>> @@ -149,7 +149,7 @@ int cat_perf_miss_val(int cpu_no, int n, char *cache_type)
>>>  	param.num_of_runs = 0;
>>>  
>>>  	if (pipe(pipefd)) {
>>> -		perror("# Unable to create pipe");
>>> +		ksft_perror("Unable to create pipe");
>>>  		return errno;
>>>  	}
>>>  
>>> @@ -185,7 +185,7 @@ int cat_perf_miss_val(int cpu_no, int n, char *cache_type)
>>>  			 * Just print the error message.
>>>  			 * Let while(1) run and wait for itself to be killed.
>>>  			 */
>>> -			perror("# failed signaling parent process");
>>> +			ksft_perror("Failed signaling parent process");
>>>  
>>
>> Partial writes are not actually errors and it cannot be expected that errno be set
>> in these cases. In these cases I think ksft_print_msg() would be more appropriate.
> 
> I can change those to use print instead although I don't think these will
> fail for other reasons than a real error as the pipe should be empty and 
> only single byte is written to it.
> 

Apologies, I did not pay attention to the actual size of the message. Yes,
leaving it as ksft_perror() is reasonable.

Reinette