Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6193169rdb; Thu, 14 Dec 2023 10:40:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IExe8i9Bz4d+6/eo8yKA5/NuLkTLTcWd15tTw1Vh8ViYj4Ps64Gn3y4lgZMZ3I9+1VyX+gm X-Received: by 2002:a17:90b:e12:b0:28a:bd54:e66 with SMTP id ge18-20020a17090b0e1200b0028abd540e66mr2813559pjb.40.1702579203695; Thu, 14 Dec 2023 10:40:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702579203; cv=none; d=google.com; s=arc-20160816; b=lGLQv2HDbes5+71JwbhI7cxhc7WKsw13h2DbHR2oNhFq9kNLi79FCijoBnTByAS8EB k53lvrj+xhEU81AFZokTRMHQTcWssElP/3+34kelTj1purzmZWSYV8wZZWXLU1xnVzIT fKFoROa293l/vfSb0xT0uHlfe95HkY4L3YrlaG2lMBrnXPMK5yAAHQELvWfToRvWMcFa ECjNuQUNF9882xZ5UgIJ//CC2NuNisyeIJ9Bs5yf6UIKH0seKeajD98hD00ArF8S2q5N UYXB6POuc0DaDtNlH03AbVvZtMG5ou2g7gCBPDCXK26DzTAbUR5jpfW0pPEKPQ3KlaCX IeyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=3yhB6eTQ5FXZkMyUhaiKOlSz8sui2h6qSwLfyzOfMbo=; fh=fFpITan00wkAHxFKINrpH2e4BL1B8ibIImPYUNaRjsg=; b=RGAXlSSZheLM9teRkM57LilsW+anmkKN9zSmlSFfVl14p2QiI7ZvtU1Dz0k+B9egg2 HwqS9zr+KgmQ6J5hSNOdgTDrDUpLk1fssJ6pfdu9esbAW70b2JbBT5kuUZI330RkgWN7 uttPAT1yIQcNVU82B22v5e1FmHl7g/ujeVkiyfxqwmJeMZsKY7c+cuOsfeMutV3KLjtP cq/OW6lVwzxDF1J+VdijBzT85AtSNYADNp0hgBPA0kH5eMycgIPQ/Zl4CRiSVpf0QZAr ecCY2pQvQF7iE5YKxvuv3i5i//zUIzEFj/ubeYKJXL/LfieAIspQdyIsiRTd7T7y5ajR Duog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hHi2piBs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id z10-20020a17090ad78a00b0028b08990987si1512634pju.168.2023.12.14.10.40.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 10:40:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hHi2piBs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 4D633887B775; Thu, 14 Dec 2023 10:40:01 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1444201AbjLNSjq (ORCPT + 99 others); Thu, 14 Dec 2023 13:39:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229579AbjLNSjp (ORCPT ); Thu, 14 Dec 2023 13:39:45 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52891111 for ; Thu, 14 Dec 2023 10:39:51 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10639C433C7; Thu, 14 Dec 2023 18:39:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702579190; bh=XAEh20qvBS23cKK2nPKEFW+2DroDAYtyZm3Y94vZ9+A=; h=From:To:Cc:Subject:Date:From; b=hHi2piBsqatjGYdPPgiGCbp9w7BBK/xwFrUQBb+rtgAaG/vETqeooAc1UZ7ee7QYJ W0rhDWFTPwqi3ub3MIb8B78W82lCga7J7j1wn0VWqT0I0BA7AL2/ibudanRXXUPmSv P1OJPlUgDyMnZRCQ8k39mWRI2SPPLDvyI+3P5zkcoDBWcALRe+XQtCwnQ1XRNAkIQ1 H+tVZjntfe7p2l8TsPXKyhPIzn7RkbKLo8k2CK5fA0xjeLgLnC43LLt1mnothqO40R TEXEgfYaveQEXLYOBE9ZsESdOUbuOduV/lgyO2fHD+Bg43wWlThiytcGng/fF5phUH 219PfYxpUVRqw== From: Arnd Bergmann To: Tomas Winkler , Arnd Bergmann , Greg Kroah-Hartman , Wentong Wu , Sakari Ailus Cc: Alexander Usyskin , linux-kernel@vger.kernel.org Subject: [PATCH 1/2] [v2] mei: fix vsc dependency Date: Thu, 14 Dec 2023 18:39:31 +0000 Message-Id: <20231214183946.109124-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 14 Dec 2023 10:40:01 -0800 (PST) From: Arnd Bergmann CONFIG_INTEL_MEI_VSC_HW can be set to built-in even with CONFIG_MEI=m, but then the driver is not built because Kbuild never enters the drivers/misc/mei directory for built-in files, leading to a link failure: ERROR: modpost: "vsc_tp_reset" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_init" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_xfer" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_need_read" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_intr_enable" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_intr_synchronize" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_intr_disable" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_register_event_cb" [drivers/misc/mei/mei-vsc.ko] undefined! Add an explicit dependency on CONFIG_MEI that was apparently missing, to ensure the VSC_HW driver cannot be built-in with MEI itself being a loadable module. Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Signed-off-by: Arnd Bergmann --- drivers/misc/mei/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig index 858bd701d68c..1e28ca23a74a 100644 --- a/drivers/misc/mei/Kconfig +++ b/drivers/misc/mei/Kconfig @@ -62,6 +62,7 @@ config INTEL_MEI_GSC config INTEL_MEI_VSC_HW tristate "Intel visual sensing controller device transport driver" + depends on INTEL_MEI depends on ACPI && SPI depends on GPIOLIB || COMPILE_TEST help -- 2.39.2