Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <da48d207-da8e-4085-940d-54a0dfec1c9f@intel.com>
Date:   Thu, 14 Dec 2023 10:52:29 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 14/24] x86/resctrl: Allow resctrl_arch_rmid_read() to
 sleep
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20231025180345.28061-1-james.morse@arm.com>
 <20231025180345.28061-15-james.morse@arm.com>
 <73bcd9f2-7c2d-4e9e-bcd8-ce3de2f9a5a4@intel.com>
 <b49f55df-e566-9a6c-b7d0-b0b675e787fc@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <b49f55df-e566-9a6c-b7d0-b0b675e787fc@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0luYjFEN04zaENnQnpNQmFYbTFmNGtEclUybU5pb3ppa1MzdFk4U2lEczRJ?=
 =?utf-8?B?WXYvbDNudXZXeTRUQzcxb2plSTNjZERIRjNJc2E2YjB5TVJQRTMyNkJuSGp4?=
 =?utf-8?B?NitkajRkWkl4SEJVbTlYVWozR2NnMGJNNC9WZW1QVEN4azVOOW5ocVNUQVRo?=
 =?utf-8?B?Y3ZlNmh3Z3BqeTE3K0hKOENGanY0bFVNNUk1YjdoNFIxVmJFUnkvem02M3ZP?=
 =?utf-8?B?c2VMdGxUbjZCZ2RaVTlxNXFTWkFRYnFhRTM0MGdXSXVpT25COTRZWnpyZjRY?=
 =?utf-8?B?aGRraCt2S21tWnJYYmE2bm5OcFdxZmw2MEt1NzlWQnh4aHA0MWFDYmxPdCtZ?=
 =?utf-8?B?ZVJCUzFCMWY4QjhmQ3R3c3BSZ3A2RnNPYmUyNGUrbWFocTRnekhBbndDVzBK?=
 =?utf-8?B?T2ZGYjNFY25nRVIrSFIzem5oRnZ4WU56UndOeHpCQzBLL2Nxb3RacFZodDkx?=
 =?utf-8?B?ci9PRWM1cU92aU94UHJaK1ZpcXFrdzhpOEJGY0xKdGZPT1N5SFN3UzhaM2xH?=
 =?utf-8?B?aGpEanBROTE4RUxvOTh2dVd2SzJJYWlUbHZtQ3FtQlhvdEc2M29HMGh4Nzl6?=
 =?utf-8?B?bHRuU1U3b2V0UHR2TzhVbDhEU0NMd290Skx3ZDZmd2EzVTNhcHA2eDFKb3JV?=
 =?utf-8?B?R2Y5aWxCZjVsdzZxbmVMd29CZlluYitWbjVpNndyd2U4ekxsM3BMczB4aXJM?=
 =?utf-8?B?a3dSUXdNNnJCR084U1daWTVVb3labnF1SkV4dkh4Z1BtaTRFalhyTHdLSkRy?=
 =?utf-8?B?UU42QTFDMmdLczljckd0UTF1MzZKTXJvaFpnR1JMdStWQmFWTEpDdE8rVXcy?=
 =?utf-8?B?VGZ2eGJMYjBRRk1BSStqUHRPczBCR2NrMncyRWNxRFdBTlJWYWE4RWM1UTUx?=
 =?utf-8?B?K3NaVTVQT3RrU2RUcjBxVEJqYThzY3VHK1BSN3FVNHNMb1Fpd0tBRnZHbmhv?=
 =?utf-8?B?dzBnOWZvNXRaYVlSdDlGcGtWZkExUWZxL3BkUnl6bnhuY2ZqMm5BaXhaV1A2?=
 =?utf-8?B?cUJBQU1waXd2N0J4RjFMQ3dNT1ZsNjVqUisvVFJUMXRidVVjZWRzUDVRK1Y5?=
 =?utf-8?B?bW5raFVTUVFqa1cvaWFEdkk1TFlQaWQvdDA3RnpWUVJPakpQNlN5SEZpVEdL?=
 =?utf-8?B?clRaV3lNQ0lMTXFoMzNFSWNtZnlSYUQ3aFBPbytoZnNOWlJ3ekdvYlY0MFVF?=
 =?utf-8?B?VTQwYTFGdHpPRE1naWw3S3NDZDZIcjNXZlhJTkRIMjdPeHBpSmRTK0hjK05O?=
 =?utf-8?B?eGRYdnZlTVNadU1wbXd5U2xHdXl2aCswUXU0dWw3SUFJdHpsMENuNVRSbjZw?=
 =?utf-8?B?L3Q0M3Fvd0czYXVGWllFZEdLZ29kU2dTRGswRXRTR25jZmkzaFdjZEQvTEQ1?=
 =?utf-8?B?OGJicURsb3lnRmdtZFJ0Q3BBRUt6aGo4clBzWXFFYlpIRDZySklmM3oyY2Q2?=
 =?utf-8?B?Ynlid24weGRROU9KQWJRUDZEZ0VnekwwYTNvS2o3Q1N2dWtUS1haZExxVlVK?=
 =?utf-8?B?SWsrTzJKbGsrRlR4eng3OFppa3FOMDJwZ0o2REx5L1lxT1JtV05EeVFZY1ZH?=
 =?utf-8?B?U0lpSmlHenVqM2w4azNJOUJ4anFCTTVzMkhPMkpndlcrWnZiTDRBRy9hOHVT?=
 =?utf-8?B?QWpNbkEvK1B1VFhqbDFad1ArWkdNT3EvU3VpNnM2RnY1SkpvTUFDQ3h3d3cx?=
 =?utf-8?B?VkJoSk91cGtjejE0SDRzdFNPRGtMckl1aVlPZmRPMzBhUVYxdDQxOE5IaHI5?=
 =?utf-8?B?alFvTnlWdHJpNzRjMXhkbkp4SUZxdnh4aU1GTWNsWWMwd200TElOS1hsWTBk?=
 =?utf-8?B?bjh5ZVVDV0F1LzlIcktsZG82a0hpeDI5M0U3ejJ6MEFCMUlPOUFUTHdlb2lZ?=
 =?utf-8?B?aENhdWpOa0xleUxuNUFCSERzRFRMMzZXQlFrWUdHaVlScGdEOERaN2pGMjk4?=
 =?utf-8?B?bFhqL0J4VTErMVkycGd2c09zMzZPaDk5b0tBVDF5dW13QnFySDVQUHRwVVpC?=
 =?utf-8?B?aC9CajVVNEptbHYvUlRJa25zWTVaZWlZMHZDRHpOZ1IwdGNoYjlSSVhpZUZZ?=
 =?utf-8?B?QytRQStHSG1qckF3bFNZS25hV1l4MVNxN3ZVTjNhUy9tRlROSlM3cDZUU3Ux?=
 =?utf-8?B?MS9Wa1dnajE5Nmh0OVJJUldXbW1rS3NLWGRmOUZBanJPVlRUeWEva3dJTDNX?=
 =?utf-8?B?dEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f228bf47-50b8-4029-4215-08dbfcd5d420
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 18:52:32.1553
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bXHRqU4CwqURa4uFJM+YhH38JjeQy74mjedapyC/TuNbSZHcTwXce/Sp/VPN1tXhFsmtLqGxbrqulzC3YqFjrByrVGAIPUbJu70/AaH8s50=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8505
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 14 Dec 2023 10:54:50 -0800 (PST)

Hi James,

On 12/14/2023 3:37 AM, James Morse wrote:
> On 09/11/2023 17:47, Reinette Chatre wrote:
>> On 10/25/2023 11:03 AM, James Morse wrote:

>>>
>>> No changes since v6
>>
>> If I trusted this I would not have taken the time to review this patch.
> 
> I'm not sure what you want me to do from this comment ... but this 'no changes' annotation
> doesn't work for either of us, so I'll remove them.
> 

The "no changes" annotation is valuable when it is accurate. When the patch
explicitly claims to have no changes since previous version when in fact there
are changes then it complicates the review process.

Reinette