Received-SPF: pass (google.com: domain of linux-kernel+bounces-23-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 14 Dec 2023 11:40:56 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Shuah Khan <shuah@kernel.org>, Mike Rapoport <rppt@kernel.org>, James
 Bottomley <James.Bottomley@HansenPartnership.com>, kernel@collabora.com,
 "kernelci.org bot" <bot@kernelci.org>, linux-mm@kvack.org,
 linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: secretmem: Floor the memory size to the
 multiple of page_size
Message-Id: <20231214114056.ec687939a411961db10e73df@linux-foundation.org>
In-Reply-To: <20231214101931.1155586-1-usama.anjum@collabora.com>
References: <20231214101931.1155586-1-usama.anjum@collabora.com>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 14 Dec 2023 15:19:30 +0500 Muhammad Usama Anjum <usama.anjum@collabora.com> wrote:

> The "locked-in-memory size" limit per process can be non-multiple of
> page_size. The mmap() fails if we try to allocate locked-in-memory
> with same size as the allowed limit if it isn't multiple of the
> page_size because mmap() rounds off the memory size to be allocated
> to next multiple of page_size.
> 
> Fix this by flooring the length to be allocated with mmap() to the
> previous multiple of the page_size.

I'd like to understand how this was noticed, what the ongoing effect
might be, etc.  To help decide which kernel version(s) need the patch.

> Fixes: 76fe17ef588a ("secretmem: test: add basic selftest for memfd_secret(2)")
> Reported-by: "kernelci.org bot" <bot@kernelci.org>

Which is one of the reasons we're now placing a Closes: tag after a
Reported-by:.