Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6227328rdb; Thu, 14 Dec 2023 11:44:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IHEAjIh7NXpTA7ttuLZCO40AApgZhFCqZsnKfTu+KxTj49RfsyQHud4bZgtMKj7Df2+lDC2 X-Received: by 2002:a05:6a21:1a3:b0:18f:fa28:fb39 with SMTP id le35-20020a056a2101a300b0018ffa28fb39mr6585835pzb.52.1702583050473; Thu, 14 Dec 2023 11:44:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702583050; cv=none; d=google.com; s=arc-20160816; b=HTw+gouhupkhcM+aTa5hmYizJf+dXKEYpljy8apPlc/QDiHruJ3EAg+rPSE5yME+y/ VItMHhwzz7T/jHHdNAwkagvflHhh+ltXu7HBDIthV/q8AK9GKE/F+2TjSL0tBq4x6Y3J 7RIEhv0l8DGiJgS1ef8NtiycXLGLvPMAp8jeZYP0hGxLZv+H/9K7nyf5hNpTaxNRRaC+ syxi5n33v0VDhy4BMlANbHN7OX2poT81nK9vA6C6CdoLpYZPhajLOWwJ+OoK4P9aKm0D dGevsu3Tt29gFlHF2Rw3vbnZ4T0IMJ69rb79KJ44bPhgtV94KWrMUfhfRBxGgJGDuYxx yxhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=C/sOZEf0OHuX4MSvvEbce/WbiB55dHt1ktGIW8+UCTk=; fh=4iHbZ733mqZc4Bx83AV0konbWC9aXbRvmPAEmCiuGYk=; b=nRaFeRwXVqXmaf4g6li2HQLuF4tyQ1/x6hev/vUtwiK0L71bUn3a6xwYQEqVcKPzpI OZAkg2EwtkEESU1S61+i27oKagsagWpyHTzkg+mNCNA+xIiBb3FmJTJOvjYuXY0/6FTZ +Xw2yQn3+1DVwHvMJKRWqnqXtZySzdDw4ofrLI2T9oWN6ENes8Y4mvK0tQOvN7Qa8fHd D0kyn7QBuhFqL5o5RBZuyISx6WUTya7ntbG+O0PWTuriSrVhdLSnabwZ/AG791UXoutj QzcyyoRRUzklFPZ6Z+KFK+RIximqNgypLn4kt9PwOKVIG90QN3T5vjYr4TOKgTw1sF10 trRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id 203-20020a6302d4000000b005c200b11630si11824044pgc.45.2023.12.14.11.44.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 11:44:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 2F8FA82CD619; Thu, 14 Dec 2023 11:44:08 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229683AbjLNTUr (ORCPT + 99 others); Thu, 14 Dec 2023 14:20:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232492AbjLNRlE (ORCPT ); Thu, 14 Dec 2023 12:41:04 -0500 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCFB8B7; Thu, 14 Dec 2023 09:41:10 -0800 (PST) Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4SrflK5yzwz6K61J; Fri, 15 Dec 2023 01:40:45 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 0FB9E1400DB; Fri, 15 Dec 2023 01:41:09 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 14 Dec 2023 17:41:08 +0000 Date: Thu, 14 Dec 2023 17:41:07 +0000 From: Jonathan Cameron To: "Russell King (Oracle)" CC: , , , , , , , , , , , , , , Salil Mehta , Jean-Philippe Brucker , , , James Morse Subject: Re: [PATCH RFC v3 05/21] ACPI: Rename ACPI_HOTPLUG_CPU to include 'present' Message-ID: <20231214174107.0000171f@Huawei.com> In-Reply-To: References: Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100002.china.huawei.com (7.191.160.241) To lhrpeml500005.china.huawei.com (7.191.163.240) X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 14 Dec 2023 11:44:08 -0800 (PST) On Wed, 13 Dec 2023 12:49:37 +0000 Russell King (Oracle) wrote: > From: James Morse > > The code behind ACPI_HOTPLUG_CPU allows a not-present CPU to become > present. This isn't the only use of HOTPLUG_CPU. On arm64 and riscv > CPUs can be taken offline as a power saving measure. > > On arm64 an offline CPU may be disabled by firmware, preventing it from > being brought back online, but it remains present throughout. > > Adding code to prevent user-space trying to online these disabled CPUs > needs some additional terminology. > > Rename the Kconfig symbol CONFIG_ACPI_HOTPLUG_PRESENT_CPU to reflect > that it makes possible CPUs present. > > HOTPLUG_CPU is untouched as this is only about the ACPI mechanism. > > Signed-off-by: James Morse > Tested-by: Miguel Luis > Tested-by: Vishnu Pajjuri > Tested-by: Jianyong Wu > Signed-off-by: Russell King (Oracle) Formatting nitpick inline. Either way FWIW: Reviewed-by: Jonathan Cameron > diff --git a/include/linux/acpi.h b/include/linux/acpi.h > index 4db54e928b36..36071bc11acd 100644 > --- a/include/linux/acpi.h > +++ b/include/linux/acpi.h > #ifdef CONFIG_ACPI_HOTPLUG_IOAPIC > int acpi_get_ioapic_id(acpi_handle handle, u32 gsi_base, u64 *phys_addr); > @@ -629,7 +629,7 @@ static inline u32 acpi_osc_ctx_get_cxl_control(struct acpi_osc_context *context) > #define ACPI_GSB_ACCESS_ATTRIB_RAW_PROCESS 0x0000000F > > /* Enable _OST when all relevant hotplug operations are enabled */ > -#if defined(CONFIG_ACPI_HOTPLUG_CPU) && \ > +#if defined(CONFIG_ACPI_HOTPLUG_PRESENT_CPU) && \ Trivial but I think there is a tab to many before that \ > defined(CONFIG_ACPI_HOTPLUG_MEMORY) && \ > defined(CONFIG_ACPI_CONTAINER) > #define ACPI_HOTPLUG_OST