Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6300205rdb; Thu, 14 Dec 2023 14:17:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IGFSL7G24MmkxJlMSMHgq8Qze4jTRPYWiaLW0BsslEtUXADxwoTUrVqlCvZOP3IVZNe9CLZ X-Received: by 2002:a17:902:6b0c:b0:1d0:8c63:cfe4 with SMTP id o12-20020a1709026b0c00b001d08c63cfe4mr8641705plk.77.1702592229646; Thu, 14 Dec 2023 14:17:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702592229; cv=none; d=google.com; s=arc-20160816; b=V8SCvfjxclzXze3x68gsY85GYyueGniBkcJJtExWz3O3PSiDa4IzN/m36gQVjojvtb fHv3sdETcaGntIt82WueKaqd9k6QzIU6UYC5/gQq5IOht/rSlvhYfyT12w57nl5VTJrg +KeuNw/tDtOzdde1rvs1p826Wih73a45xPqw6TdMuN8NDL+m2FAHeleCY1yQacF4h6uP sZ25jF8n5HaEnxdVboa4kDohac4r4hIAWzfFeeJUVAJfS9/6LEVGGVL32FiCOmFvDkcT Nr0JRm6bJMr34WdLyqa/D/xwULKYj5Lsh01e0lrekirHBFZBsPJgqO/K68ps4jysrwse 7azA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=DOndnH0lG18vvOVhppdwTo3ViPA7l5XEHJHxXEXV2X8=; fh=w1bq4WYqe8V5rKVfJm9GebVJJUzEKglRApizdOU2VvE=; b=xrA0oeJGUzCJ5L8g/TO5xAwNQIQkwSWW5GUQ1gVtvZ5QudYywlpoDrp8VVSesLbMO3 dybUE0WR+pR0F9Ovb6XSk5Kdx14sAK/F7u/FmpykH7LGS1DIHMqTGb2ky8dgH21vE9Tk mU2zl/L4n2UQpLlzngD5YlT0mFOiUVrXK3eORFGVGEz1lP+QhOULNK0SNShqshWiE4oc QeI8u5jIBbshL5Z0UR19nEjZNzoGYj+Fykp0AmOJQmNppfdd4YpWhvzFLNcCbSunXJJm vDZmohRahyM6rjo5UHriXSZF8pSCRgT0woEsBb98VHkqZ3wI6IIkbCkdwEKTkWKb6e9Y 29cA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=WX7H+Zrw; spf=pass (google.com: domain of linux-kernel+bounces-179-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-179-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id i13-20020a170902c94d00b001c754f13381si12151971pla.455.2023.12.14.14.17.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 14:17:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-179-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=WX7H+Zrw; spf=pass (google.com: domain of linux-kernel+bounces-179-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-179-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5600A283099 for ; Thu, 14 Dec 2023 22:17:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 800746720A; Thu, 14 Dec 2023 22:17:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="WX7H+Zrw" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60683671E8 for ; Thu, 14 Dec 2023 22:17:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F662C433C8; Thu, 14 Dec 2023 22:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1702592222; bh=2D9nG2KNudL+10rZMcKkKt/VtIVyh9wWPQJtsj2OmR8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WX7H+ZrwBVrU3L1JS5De2zQh+c0BePlKvIWJc5LefMj36TYdyIPyIw3K38DgoEEWG jYwV2WvZdxeUat7eT0WhN8zQgD6v9xD/u3ern3xb7nSLxsDB09A3d7PKyyJPtJBmVA S4g5xo9qcSqYFX6zN/b7RpYjvP7M4VPQ73X3aRZc= Date: Thu, 14 Dec 2023 14:17:01 -0800 From: Andrew Morton To: Barry Song <21cnbao@gmail.com> Cc: Mel Gorman , baolin.wang@linux.alibaba.com, linux-mm@kvack.org, david@redhat.com, hannes@cmpxchg.org, huzhanyuan@oppo.com, linux-kernel@vger.kernel.org, shikemeng@huaweicloud.com, v-songbaohua@oppo.com, willy@infradead.org Subject: Re: [PATCH] mm: compaction: avoid fast_isolate_freepages blindly choose improper pageblock Message-Id: <20231214141701.29aef9815d3e743645786c1e@linux-foundation.org> In-Reply-To: References: <20231206110054.61617-1-v-songbaohua@oppo.com> <20231213130231.ksban2ovad4q4rxj@techsingularity.net> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Thu, 14 Dec 2023 09:34:35 +0800 Barry Song <21cnbao@gmail.com> wrote: > > > Reported-by: Zhanyuan Hu > > > Signed-off-by: Barry Song > > > > Acked-by: Mel Gorman > > Hi Mel, > Thanks! > > Hi Andrew, > Given this patch has been in mm-stable, > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-stable&id=d19b1a1797 > does it still have a chance to collect Mel's tag? That would require a rebuild of mm-stable, which is also a rebase. I don't think I've had to do that before - I'll occasionally rebase, but just to drop things - not a full rebuild from the quilt patches. If I end up having to do that then I'll somehow try to remember to make this change.