Received-SPF: pass (google.com: domain of linux-kernel+bounces-193-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Yang Shi <yang@os.amperecomputing.com>
To: riel@surriel.com,
	shy828301@gmail.com,
	willy@infradead.org,
	cl@linux.com,
	akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [RESEND PATCH] mm: align larger anonymous mappings on THP boundaries
Date: Thu, 14 Dec 2023 14:34:23 -0800
Message-ID: <20231214223423.1133074-1-yang@os.amperecomputing.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Yx9Q+ASuDo4HxeC026AfmbjQPZTTAncbCGBToBQALFf+fMieEacJApSJ34c3?=
 =?us-ascii?Q?Ti8vypclQX6Z66KqQ4vxPgfjHCTcTxLzI/4DcB14DJkMl878bh17bMEbc1xi?=
 =?us-ascii?Q?S5Vi9z9my4xM+yOWElxf8/9Iu08mCjjgAwjq7OvodkgETKNWA4yfxkxOkTvx?=
 =?us-ascii?Q?2wvoK9KhQgSuFKn5CiO2mZ4t4I99jJ6XXkuUG6j61z42xeOH+8KZ+9sey56x?=
 =?us-ascii?Q?zdJ3msIaOmBWLnKckJFvh7JEBABCz14cPYmO8if+J9UEeE+T9JiaxFrp+Nro?=
 =?us-ascii?Q?27jVTGr6zAmuZayFRm87o1XzK3m5UQQEUhfNnE5P8tndWQ05H5MX+URb9j0s?=
 =?us-ascii?Q?TacpkS5uheIAobi/jqILhyyXReGBLKMn4sW+0WrbQQks2ia4DEQskto6NtLs?=
 =?us-ascii?Q?RfOxcDvr5yT77/RLhTgVtg7UaVCn/OAWVIP63usRKY6lxqQFgKSMfJKBEwWT?=
 =?us-ascii?Q?oq/NWK0XxOgLAnw4xj2kG6yIG2zSQgmJA/Q1giNqm+8BToyWnNZndgH7v3Sb?=
 =?us-ascii?Q?cbSE20xitz1zgtf6fA499poa9OB3kXp1eOGuvUnssahSmvCjWqDgJF11b02m?=
 =?us-ascii?Q?SEMfs70ne3xSJs7K42cd9cqpr+T+LeCpGGhauqBoZB2wvXiOgdZMc2GGUYDB?=
 =?us-ascii?Q?VWmPDJ1J58ytWm78EI7/yOky+sjhRw9n695PSGDMgRr0vkYIxz1wF2BboEGn?=
 =?us-ascii?Q?Y2jp9emzA7Bj998wXQdMoFQd4/LoqWR24pzVGZtqm6skhVGsCJ3LGI9G7Wso?=
 =?us-ascii?Q?eRB4sfoQe4e8cHDxvT0e8X4jFeWDr0cM1ec70EKsXq5VfcVXoD7FzOdoAhCz?=
 =?us-ascii?Q?6d0kquA/xUkZ7hRcA+2l2EdDIr1lMuRMJ+/n+xeYtw3Yps16whdpmYrgjm73?=
 =?us-ascii?Q?aeyaKmyYZvSZ8EvlSGRhzjNzesyk0vSsJv+57+4hYN5bbY6Gsr97RC8RABri?=
 =?us-ascii?Q?kuIhkmFQpPsjN81cGQvwg8LAla+NyL8BOJAsy+FkkQc0/1QS0au+S6rA7cKt?=
 =?us-ascii?Q?Eg9RnVc6g5WHnoAWzfJjL9l8HCKXi1bUbsMHtOTPhAynkKF876EsJ4NtDtIy?=
 =?us-ascii?Q?Ys6sL8bnYnwS8Yw38yRamKkYcgc6aXKlzJfVEux8i112tg2jgovpmWd961pA?=
 =?us-ascii?Q?Dbi99mM7KT4jIJsqqtvsJ/pucL1y3Kx70t84PLSOm7H6CbbsTZjN0BPoD+WJ?=
 =?us-ascii?Q?bxZRHykUF3ijndzrL8M0RvZWKfEcfW/R/oU0abIcwK2XaENSzXdkbcuAVVnD?=
 =?us-ascii?Q?+J9qtTWp+YMHGBjU2Qhrp5eGLnHcvaTr4h/salCOfXuxfBPF5mMIcL5fY+gr?=
 =?us-ascii?Q?N9/su8rE8HTSdizCCuBDG4d7owo5AVWHCgVNkEe6O3QlR+zRtOfhtUWpwfkY?=
 =?us-ascii?Q?vNKRPsUcxsRX0S8q6aeITih+HJrXIhDZOgatAYbJFNtEkKc9c/kZHB46ZM6m?=
 =?us-ascii?Q?NoWteuy+R6Z7pClwQU5BnbQ6qkAkdENBiZvL4Y+aAbg6+OpWQBbJ5PwG2dWY?=
 =?us-ascii?Q?KhzWM9hm/FgXEyNY7FRhR5+HkxLWg256ldfw1huGWoXyOazdUjvLxLdNU1Sr?=
 =?us-ascii?Q?ZK6FGFdJLwKga7AXRdMwsMFVs8yFGYO+rTIQsSTKrGacsVfj7nXsQviTPRDW?=
 =?us-ascii?Q?eGFy5TJq7F0DLhLvFIuGXZM=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8604f7ff-84a5-41c3-2a20-08dbfcf4decf
X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7492.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 22:34:44.5659
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nMh+cJuTSCSEaxPuJK5UHrbOqOTVxYik36Yj3sQwUkfRuXorecVFy+GXGgusia3tA4ClrJDFqN3E16YUR0IH7oALZAZUcXC1+wdzPNsD9uE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB8166

From: Rik van Riel <riel@surriel.com>

Align larger anonymous memory mappings on THP boundaries by going through
thp_get_unmapped_area if THPs are enabled for the current process.

With this patch, larger anonymous mappings are now THP aligned.  When a
malloc library allocates a 2MB or larger arena, that arena can now be
mapped with THPs right from the start, which can result in better TLB hit
rates and execution time.

Link: https://lkml.kernel.org/r/20220809142457.4751229f@imladris.surriel.com
Signed-off-by: Rik van Riel <riel@surriel.com>
Reviewed-by: Yang Shi <shy828301@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Christopher Lameter <cl@linux.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
This patch was applied to v6.1, but was reverted due to a regression
report.  However it turned out the regression was not due to this patch.
I ping'ed Andrew to reapply this patch, Andrew may forget it.  This
patch helps promote THP, so I rebased it onto the latest mm-unstable.


 mm/mmap.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/mm/mmap.c b/mm/mmap.c
index 9d780f415be3..dd25a2aa94f7 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -2232,6 +2232,9 @@ get_unmapped_area(struct file *file, unsigned long addr, unsigned long len,
 		 */
 		pgoff = 0;
 		get_area = shmem_get_unmapped_area;
+	} else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) {
+		/* Ensures that larger anonymous mappings are THP aligned. */
+		get_area = thp_get_unmapped_area;
 	}
 
 	addr = get_area(file, addr, len, pgoff, flags);
-- 
2.41.0