Received-SPF: pass (google.com: domain of linux-kernel+bounces-265-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <8bddc464-a2f3-47e5-85e6-d4067db67ccd@infradead.org>
Date: Thu, 14 Dec 2023 15:57:26 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pm.c:undefined reference to `i8042_command'
Content-Language: en-US
To: Arnd Bergmann <arnd@arndb.de>, Jiaxun Yang <jiaxun.yang@flygoat.com>,
 kernel test robot <lkp@intel.com>, Masahiro Yamada <masahiroy@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
 Nicolas Schier <nicolas@fjasle.eu>,
 "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
References: <202312041909.lwhcU35R-lkp@intel.com>
 <5f1caaf8-1edf-444a-b017-c4d08e52213b@infradead.org>
 <f712a65b-4984-46e8-bd43-1309b5cd41f0@app.fastmail.com>
 <c10194f2-097f-4455-9932-19961edbf990@infradead.org>
 <40b5e438-22f4-43e5-9663-db44dd402a35@app.fastmail.com>
 <374978b4-9bed-4d5c-90e2-344e46dedaf8@app.fastmail.com>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <374978b4-9bed-4d5c-90e2-344e46dedaf8@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit


On 12/14/23 11:54, Arnd Bergmann wrote:
> On Thu, Dec 7, 2023, at 01:21, Jiaxun Yang wrote:
>> 在2023年12月6日十二月 下午5:26，Randy Dunlap写道：
>>> On 12/5/23 22:52, Arnd Bergmann wrote:
>>>> On Wed, Dec 6, 2023, at 06:24, Randy Dunlap wrote:
> 
>>>> I think it's bad style to force-select an optional subsystem.
>>>> How about making the entire file optional? It seems that there
>>>> are already __weak functions in its place.
>>>
>>> Yes, I agree in general.
>>>
>>> Hopefully the maintainer will opine your suggestion.
>>> Jiaxun?
>>
>> LGTM, PM is not an essential function here.
>> Arnd, do you mind making it a patch?
>>
> 
> I just tried it out and my version doesn't actually work since
> we still end up building the file with SERIO_I82042=m.
> 
> We could still make it work by checking for serio being
> built-in here, but in the end I think that's worse than
> Randy's patch, so let's just go with his original version.
> 
>       Arnd

I think that we should look for yet another alternative then.
I don't believe that adding "select INPUT" is a good idea.
It would be the only "select INPUT" in the entire kernel tree.


thanks.
-- 
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html