Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6364222rdb; Thu, 14 Dec 2023 16:50:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IGPtdmyf0DiYGmJdz4DNM4Clj72Ifk6SqAANadn9BRAGhlGlXZoaXNANKMU3lsrtAR8zOKk X-Received: by 2002:a05:600c:3ba6:b0:40b:5e4a:4063 with SMTP id n38-20020a05600c3ba600b0040b5e4a4063mr5440824wms.131.1702601406362; Thu, 14 Dec 2023 16:50:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702601406; cv=none; d=google.com; s=arc-20160816; b=vV3d5VZNhJgqaeg3iV7rrO78MrEz02qXyOkT1Pi3TVAbQnS+Vbss+d0e3zzkAV419D sRUrULvOkoAkDmwFqedXeCbW3N71haMHzW8vFeWOpYvARf/ywFUCxEVyJ7U2N+ls8J9S 0tS9fpyETPoifgRilkBpSuD6qV7BXQCV5TbVm+cw49roqiijz6p4o++aGhppTei9Se0C K8u1ZdG10OWe5W/NW3Ri0Zj8awxkDxm+9kDuJPiwzZKwz6Gt8K8P5Ti3uc5Lx3gslxBn 77sEpUppBn2LczjkxLmMSf8El4BkXhVPgHj2rNfuS7Pwr5cW5H5YsDEFSN89RIzkB0vS Dd8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:autocrypt:references :in-reply-to:date:cc:to:from:subject:message-id:dkim-signature; bh=vWDCfTgrMnjG8GpBS1b4pGEfSNMD7D80zgBIrS8hZGs=; fh=nQ9gCoVOgTX+nKL2EWvE6Z3UYlb+dJxelCnXv4/64NE=; b=TgdBhMVUMK+eWYWu4Wblj+6sHYD3jOPY9hLu9IPihI16plXQDuaCENuxVcP7J1//d7 BcrjqCPziwxcXPjhv3eqNGazRo/5HtXYxzHoKc51Y1L8wDZMhVi0fEnnwahCdkQjvJJ1 XZcyGrC8g5G/tBC8M6rld7MuAV+CIljJZ87FvFsjRHX9zM5SjZgRE0B+BgoEn91SgChQ M0Vy9X/aAWP5XhSiKZ2twyK8Pr+Ie1j3RyA0Jyf4r7q+oPWcYMb+PUfQ6uuaxe23b6fn YVQPvZtq5d1Kx5N8tx1CfBiiyqZvW8OECcAW2lyvcppiq5YJ1ayAHVj1xdYB1VdkI6Ws r2EQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Vy9RQT8I; spf=pass (google.com: domain of linux-kernel+bounces-294-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-294-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id i10-20020a170906264a00b00a1b3b00907esi7121476ejc.2.2023.12.14.16.50.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 16:50:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-294-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Vy9RQT8I; spf=pass (google.com: domain of linux-kernel+bounces-294-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-294-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id EECA31F22C70 for ; Fri, 15 Dec 2023 00:50:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B2575805; Fri, 15 Dec 2023 00:49:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vy9RQT8I" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 711D4A34; Fri, 15 Dec 2023 00:49:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-40b5155e154so1584995e9.3; Thu, 14 Dec 2023 16:49:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702601393; x=1703206193; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=vWDCfTgrMnjG8GpBS1b4pGEfSNMD7D80zgBIrS8hZGs=; b=Vy9RQT8IQkf6bTialyqA1Z+DfbRmMzfUy/i41uj5iWL1UUNq1Tg2j6YJbWW8Hs8RSy OEi32FQQIpxx6XLSwMHkTEZU5Wf4v7c7kKiCOL3HVoFcz/R5HZ2oemx+4qYWtwPtBbT4 uqK0PoufvPUg3iZjRwv5ERrG1tjUL6YmNnXTRPmRjSOXQgulM6DfNshgf++0BsWOY81p 2nJ8M8fMLAbWZtm/f2cM+kqTxQCCKva7VTdoiae9pRcreLlA/hlaGr28uxPIcf+chEqQ JPSTPXhiHT4Ji6PlrY9K+bbd03W7zNgNjR/mnSSoIrZhFxcc+LYS7nQH1jMrLLRdh5ob IPGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702601393; x=1703206193; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vWDCfTgrMnjG8GpBS1b4pGEfSNMD7D80zgBIrS8hZGs=; b=j3Y2c6nHsW7Xnb87jfhpnwFvC8guvxknmDkNlFBLbz6f2CL4WO0/pb6TPZ1geHMi2Z mNGQ1OwYR/Cit0VPLv7aicNqnvovIu0GKDepZvgjp27jtfHYCxlIrstIeCYLQK6oOoDx 8DAC6pKOg63nx2CMVkpe/eDKxO6NBR2jkIkPrq8MUx2O2fIOZAqulsl7jrb4tnpXmUka Eq8zj+XfPse4PZxZKMsH6++1NCd3cDdW0Pv0R7Oe6az10hbQzx72ywlYtl3k31aUs+kI wNC1mqxlnFJlnQuyKSgxKVXt9299PW4iqOJJ9WZ4YsRCG1Da/sUCB7AyoerSEhaUMdva UVeQ== X-Gm-Message-State: AOJu0YzYFk+w+UkYUR/C90aXKa3Hk4t/NkQq48E59lDmxCz4qbwRR9wy H0+9xg7Uj8iOciS0afjz6yc= X-Received: by 2002:a05:600c:2146:b0:40c:2b26:970f with SMTP id v6-20020a05600c214600b0040c2b26970fmr5326861wml.198.1702601393500; Thu, 14 Dec 2023 16:49:53 -0800 (PST) Received: from [192.168.1.95] (host-176-36-0-241.b024.la.net.ua. [176.36.0.241]) by smtp.gmail.com with ESMTPSA id s5-20020a05600c384500b0040b632f31d2sm27005390wmr.5.2023.12.14.16.49.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 16:49:52 -0800 (PST) Message-ID: <526d4ac8f6788d3323d29fdbad0e0e5d09a534db.camel@gmail.com> Subject: Re: [Bug Report] bpf: incorrectly pruning runtime execution path From: Eduard Zingerman To: Andrii Nakryiko Cc: Hao Sun , Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , bpf , Linux Kernel Mailing List Date: Fri, 15 Dec 2023 02:49:51 +0200 In-Reply-To: References: <480a5cfefc23446f7c82c5b87eef6306364132b9.camel@gmail.com> <917DAD9F-8697-45B8-8890-D33393F6CDF1@gmail.com> <9dee19c7d39795242c15b2f7aa56fb4a6c3ebffa.camel@gmail.com> <73d021e3f77161668aae833e478b210ed5cd2f4d.camel@gmail.com> Autocrypt: addr=eddyz87@gmail.com; prefer-encrypt=mutual; keydata=mQGNBGKNNQEBDACwcUNXZOGTzn4rr7Sd18SA5Wv0Wna/ONE0ZwZEx+sIjyGrPOIhR14/DsOr3ZJer9UJ/WAJwbxOBj6E5Y2iF7grehljNbLr/jMjzPJ+hJpfOEAb5xjCB8xIqDoric1WRcCaRB+tDSk7jcsIIiMish0diTK3qTdu4MB6i/sh4aeFs2nifkNi3LdBuk8Xnk+RJHRoKFJ+C+EoSmQPuDQIRaF9N2m4yO0eG36N8jLwvUXnZzGvHkphoQ9ztbRJp58oh6xT7uH62m98OHbsVgzYKvHyBu/IU2ku5kVG9pLrFp25xfD4YdlMMkJH6l+jk+cpY0cvMTS1b6/g+1fyPM+uzD8Wy+9LtZ4PHwLZX+t4ONb/48i5AKq/jSsb5HWdciLuKEwlMyFAihZamZpEj+9n91NLPX4n7XeThXHaEvaeVVl4hfW/1Qsao7l1YjU/NCHuLaDeH4U1P59bagjwo9d1n5/PESeuD4QJFNqW+zkmE4tmyTZ6bPV6T5xdDRHeiITGc00AEQEAAbQkRWR1YXJkIFppbmdlcm1hbiA8ZWRkeXo4N0BnbWFpbC5jb20+iQHUBBMBCgA+FiEEx+6LrjApQyqnXCYELgxleklgRAkFAmKNNQECGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQLgxleklgRAlWZAv/cJ5v3zlEyP0/jMKQBqbVCCHTirPEw+nqxbkeSO6r2FUds0NnGA9a6NPOpBH+qW7a6+n6q3sIbvH7jlss4pzLI7LYlDC6z+egTv7KR5X1xFrY1uR5UGs1beAjnzYeV2hK4yqRUfygsT0Wk5e4FiNBv4+DUZ8r0cNDkO6swJxU55DO21mcteC147+4aDoHZ40R0tsAu+brDGSSoOPpb0RWVsEf9XOBJqWWA+T7mluw nYzhLWGcczc6J71q1Dje0l5vIPaSFOgwmWD4DA+WvuxM/shH4rtWeodbv iCTce6yYIygHgUAtJcHozAlgRrL0jz44cggBTcoeXp/atckXK546OugZPnl00J3qmm5uWAznU6T5YDv2vCvAMEbz69ib+kHtnOSBvR0Jb86UZZqSb4ATfwMOWe9htGTjKMb0QQOLK0mTcrk/TtymaG+T4Fsos0kgrxqjgfrxxEhYcVNW8v8HISmFGFbqsJmFbVtgk68BcU0wgF8oFxo7u+XYQDdKbI1uQGNBGKNNQEBDADbQIdo8L3sdSWGQtu+LnFqCZoAbYurZCmUjLV3df1b+sg+GJZvVTmMZnzDP/ADufcbjopBBjGTRAY4L76T2niu2EpjclMMM3mtrOc738Kr3+RvPjUupdkZ1ZEZaWpf4cZm+4wH5GUfyu5pmD5WXX2i1r9XaUjeVtebvbuXWmWI1ZDTfOkiz/6Z0GDSeQeEqx2PXYBcepU7S9UNWttDtiZ0+IH4DZcvyKPUcK3tOj4u8GvO3RnOrglERzNCM/WhVdG1+vgU9fXO83TB/PcfAsvxYSie7u792s/I+yA4XKKh82PSTvTzg2/4vEDGpI9yubkfXRkQN28w+HKF5qoRB8/L1ZW/brlXkNzA6SveJhCnH7aOF0Yezl6TfX27w1CW5Xmvfi7X33V/SPvo0tY1THrO1c+bOjt5F+2/K3tvejmXMS/I6URwa8n1e767y5ErFKyXAYRweE9zarEgpNZTuSIGNNAqK+SiLLXt51G7P30TVavIeB6s2lCt1QKt62ccLqUAEQEAAYkBvAQYAQoAJhYhBMfui64wKUMqp1wmBC4MZXpJYEQJBQJijTUBAhsMBQkDwmcAAAoJEC4MZXpJYEQJkRAMAKNvWVwtXm/WxWoiLnXyF2WGXKoDe5+itTLvBmKcV/b1OKZF1s90V7WfSBz712eFAynEzyeezPbwU8QBiTpZcHXwQni3IYKvsh7s t1iq+gsfnXbPz5AnS598ScZI1oP7OrPSFJkt/z4acEbOQDQs8aUqrd46PV jsdqGvKnXZxzylux29UTNby4jTlz9pNJM+wPrDRmGfchLDUmf6CffaUYCbu4FiId+9+dcTCDvxbABRy1C3OJ8QY7cxfJ+pEZW18fRJ0XCl/fiV/ecAOfB3HsqgTzAn555h0rkFgay0hAvMU/mAW/CFNSIxV397zm749ZNLA0L2dMy1AKuOqH+/B+/ImBfJMDjmdyJQ8WU/OFRuGLdqOd2oZrA1iuPIa+yUYyZkaZfz/emQwpIL1+Q4p1R/OplA4yc301AqruXXUcVDbEB+joHW3hy5FwK5t5OwTKatrSJBkydSF9zdXy98fYzGniRyRA65P0Ix/8J3BYB4edY2/w0Ip/mdYsYQljBY0A== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2023-12-14 at 16:06 -0800, Andrii Nakryiko wrote: [...] > If you agree with the analysis, we can start discussing what's the > best way to fix this. Ok, yeap, I agree with you.=20 Backtracker marks both registers in 'if' statement if one of them is tracked, but r8 is not marked at block entry and we miss r0.