Received-SPF: pass (google.com: domain of linux-kernel+bounces-295-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: "Wu, Wentong" <wentong.wu@intel.com>
To: Arnd Bergmann <arnd@kernel.org>
CC: "Winkler, Tomas" <tomas.winkler@intel.com>, Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sakari Ailus
	<sakari.ailus@linux.intel.com>, "Usyskin, Alexander"
	<alexander.usyskin@intel.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/2] [v2] mei: fix vsc dependency
Thread-Topic: [PATCH 1/2] [v2] mei: fix vsc dependency
Thread-Index: AQHaLrz0vFnOVTNi4EqVltp8uDeAP7CpgsvQ
Date: Fri, 15 Dec 2023 00:51:42 +0000
Message-ID: <DM6PR11MB43164A072AE0C0F8F49356A38D93A@DM6PR11MB4316.namprd11.prod.outlook.com>
References: <20231214183946.109124-1-arnd@kernel.org>
In-Reply-To: <20231214183946.109124-1-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?t+NUtCOj/vnyN5xHGipeXEEGIwpWIhSkTP88nkONACZY367pN/hr1rn4ybUR?=
 =?us-ascii?Q?owW7Z3MTVROfu2HapRjxPZvhL3wHRpOp9yF3wnBh+iEk3lr1pnwmRwLGJXI0?=
 =?us-ascii?Q?idcQz4e7r8nbP7xxqUpFpDL71bNAve4DlWWegRFCwAeZbvLi28LgnibQpXZk?=
 =?us-ascii?Q?DBUAHwTLNMqL5aky51Zvs3965ya+BmRAWEyxDQ1LZnC4MMpz62mR8rDZej3U?=
 =?us-ascii?Q?3FZ1r5SCr/5+EFrIWXzpFqJFxzyu3+GlC5T3WmKBmbI/SGBddboxUjfWc6h8?=
 =?us-ascii?Q?f0l6+rIpwrsaV0JB86HBVo73ZNWaojJo1uQWwhGlEawpthjtGvJgMDe4OPwn?=
 =?us-ascii?Q?rtytQ3pXOFdlz0+NzItrJOKGpblFi0zYKDD42BEXoB9Mbf4nbJP3HRQL9KpU?=
 =?us-ascii?Q?2FQaJ7WjG4vQvb7YLfNPDqM2LW2B+NzvNvDfuPauIpxiOwI+55h5gj647QHp?=
 =?us-ascii?Q?s9/bBbPclZ2MlPXh1Qm/lRWQbcH5Qje+FEn2ZqqmhZ8zDgm+7zWgQ1jkZ++s?=
 =?us-ascii?Q?nmpgz4nVvbJBg1gBVXRZx9nkp+pQKE82Msi6OwMOewzk33TwzuilWAkLAkXi?=
 =?us-ascii?Q?FB2+wwafr0lWMuEV+OBAMWz+Y2YgWnqkJBpkMqEipObrSiGMYGbtJuaLfhOY?=
 =?us-ascii?Q?qwRtiepdoxFZwQXxPmBCjZmgJCz88goYsEGKwhndD0bQbTGH50n0Xupm0J/Y?=
 =?us-ascii?Q?uAQk/fbWPr9fz8N7nbEpRekUFcG+TlpcK4xg1gVVWYFWUaa0OX1L1ToVe9wd?=
 =?us-ascii?Q?bIP9QG+JNe3dNf8rXa1q+2a1sbc98iepMte3BG+DVFEy+j9BTrkdI0kwzuOB?=
 =?us-ascii?Q?DpxyYYtIfONRnc0ul5npVq/ukeE7/OCSsc9j33tv45+eZcE8dVPu+8U9VenL?=
 =?us-ascii?Q?76xQoSlLjnSW2egHYp/zCZ1qwtpfBS7ElzqF38bvRoDmCWEq2xQxnrsOokRJ?=
 =?us-ascii?Q?qMlzbFRs51AiCaXiXk2tm1eNhpSYpJMWmAIEfJFlQjPeotRJVP9Ec0E+I52f?=
 =?us-ascii?Q?1mmuu/dqMoeWjzRAbo+d1G/pgN+Ic5NoC0YH/c6qsc17C+Kf5mD3Eeay6cy+?=
 =?us-ascii?Q?gWLxMY9FAXO6xNRKTJQXjQTYplPOO4kzrdE6EI2u1HvQicKfz93CkJuwOe/B?=
 =?us-ascii?Q?iU1vTAy0/OtHs3l691E2J2ankb/I7sgc796/bawiYqMCmajduczpYWM3xoWt?=
 =?us-ascii?Q?e9AUEO4jOWXG2i4hyA883notTZUxvCT/AjHduDkUzL4HKTlc0fRS1ep4XMtR?=
 =?us-ascii?Q?SgVgKULxUM8rsEEM+DHkUJluFgrDe7HYnAbnnzuhqAzRv7BtrPH2irf6g749?=
 =?us-ascii?Q?fo7Uj/GgKk5DT4o5KpF445Fc5tMYL7sYu24vyhEXmxSjiKbuUwIz+sP7dtRJ?=
 =?us-ascii?Q?g1XFf7HaZhfYVhS+bl7mIjwZvhIdpPNvEDCbzEYEDLNEiD2MPpzbuvcw3VKU?=
 =?us-ascii?Q?DqptbxhSb0o/nopIdpr2JcDjvblh1wVeKoS4mT/FQpm3K1NyJDvnf5C/W32c?=
 =?us-ascii?Q?IXWAykaY5y/Z/qO2DZRJmakjel7/MZhuLknbVFhGeMzrqywBVBVWZUwi7seG?=
 =?us-ascii?Q?5wuwcmDKD+KQsNqh6lFddjefsjlYwZVu0qB1exaf?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4316.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c2a0288-cf2f-4369-3233-08dbfd08011b
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2023 00:51:42.2592
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nPXgyJAGUifGj2mICsavDBh0GVUjuuWS+VdHCxfaEg6+R2Nf6K/fGs7bYhaCmdOUUTY6i1zjgPc3lGoXPFEDRw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7753
X-OriginatorOrg: intel.com

> From: Arnd Bergmann <arnd@arndb.de>
>=20
> CONFIG_INTEL_MEI_VSC_HW can be set to built-in even with CONFIG_MEI=3Dm,
> but then the driver is not built because Kbuild never enters the drivers/=
misc/mei
> directory for built-in files, leading to a link
> failure:
>=20
> ERROR: modpost: "vsc_tp_reset" [drivers/misc/mei/mei-vsc.ko] undefined!
> ERROR: modpost: "vsc_tp_init" [drivers/misc/mei/mei-vsc.ko] undefined!
> ERROR: modpost: "vsc_tp_xfer" [drivers/misc/mei/mei-vsc.ko] undefined!
> ERROR: modpost: "vsc_tp_need_read" [drivers/misc/mei/mei-vsc.ko] undefine=
d!
> ERROR: modpost: "vsc_tp_intr_enable" [drivers/misc/mei/mei-vsc.ko]
> undefined!
> ERROR: modpost: "vsc_tp_intr_synchronize" [drivers/misc/mei/mei-vsc.ko]
> undefined!
> ERROR: modpost: "vsc_tp_intr_disable" [drivers/misc/mei/mei-vsc.ko]
> undefined!
> ERROR: modpost: "vsc_tp_register_event_cb" [drivers/misc/mei/mei-vsc.ko]
> undefined!
>=20
> Add an explicit dependency on CONFIG_MEI that was apparently missing, to
> ensure the VSC_HW driver cannot be built-in with MEI itself being a loada=
ble
> module.
>=20
> Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks

Reviewed-by: Wentong Wu <wentong.wu@intel.com>

> ---
>  drivers/misc/mei/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig index
> 858bd701d68c..1e28ca23a74a 100644
> --- a/drivers/misc/mei/Kconfig
> +++ b/drivers/misc/mei/Kconfig
> @@ -62,6 +62,7 @@ config INTEL_MEI_GSC
>=20
>  config INTEL_MEI_VSC_HW
>  	tristate "Intel visual sensing controller device transport driver"
> +	depends on INTEL_MEI
>  	depends on ACPI && SPI
>  	depends on GPIOLIB || COMPILE_TEST
>  	help
> --
> 2.39.2