Date: Thu, 6 Dec 2007 15:19:29 -0500
From: Jeff Dike <jdike@addtoit.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/6] UML - Customize tlb.h
Message-ID: <20071206201929.GA9366@c2.user-mode-linux.org>
References: <20071206170640.GA7420@c2.user-mode-linux.org> <20071206114642.555a0749.akpm@linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20071206114642.555a0749.akpm@linux-foundation.org>
User-Agent: Mutt/1.4.2.3i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 796
Lines: 27

On Thu, Dec 06, 2007 at 11:46:42AM -0800, Andrew Morton wrote:
> > +void flush_tlb_mm(struct mm_struct *mm)
> > +{
> > +	struct vm_area_struct *vma = mm->mmap;
> > +
> > +	if (atomic_read(&mm->mm_users) == 0)
> > +		return;
> 
> Under which circumstances does this test succeed?

Sigh, none.  The other copy obviously succeeds during exit - this one
isn't needed.

> This file rather needs an inclusion of percpu.h.  I guess you got
> lucky.

Yup, drop this, and I'll send a fixed version.

				Jeff

-- 
Work email - jdike at linux dot intel dot com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/