Received-SPF: pass (google.com: domain of linux-kernel+bounces-300-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 14 Dec 2023 17:01:37 -0800
From: Kees Cook <keescook@chromium.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] scripts: kernel-doc: Report excess struct member
 descriptions
Message-ID: <202312141700.E0BC0FD19@keescook>
References: <20231215001451.work.746-kees@kernel.org>
 <16d1510c-fa3e-4fa9-ba4d-c483a22f83a4@infradead.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <16d1510c-fa3e-4fa9-ba4d-c483a22f83a4@infradead.org>

On Thu, Dec 14, 2023 at 04:21:17PM -0800, Randy Dunlap wrote:
> Hi Kees,
> 
> On 12/14/23 16:14, Kees Cook wrote:
> > While missing descriptions were already be reported, missing struct
> > members were not. For example, previously this output was empty, but now
> > produces:
> > 
> > $ ./scripts/kernel-doc -none ./drivers/leds/leds-mlxreg.c
> > ./drivers/leds/leds-mlxreg.c:42: warning: Excess struct member 'led_data' description in 'mlxreg_led_data'
> 
> I just made a patch with similar functionality last night:
> 
> https://lore.kernel.org/linux-doc/20231214070200.24405-1-rdunlap@infradead.org/

Ah-ha! So you're as confused as me about where the robot was getting
warnings from! Your patch is better.

-Kees

-- 
Kees Cook