Received-SPF: pass (google.com: domain of linux-kernel+bounces-308-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <9a2b85a8a19e002093e2471a97850d26e335900f.camel@irl.hu>
Subject: Re: [PATCH 03/16] ASoC: tas2781: disable regmap regcache
From: Gergo Koteles <soyer@irl.hu>
To: Mark Brown <broonie@kernel.org>
Cc: Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
  Baojun Xu <baojun.xu@ti.com>, Jaroslav Kysela <perex@perex.cz>,
  Takashi Iwai <tiwai@suse.com>, Liam Girdwood <lgirdwood@gmail.com>,
  linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Date: Fri, 15 Dec 2023 02:17:01 +0100
In-Reply-To: <bf24488f-e4e1-4d3e-a67e-fe74c05acda4@sirena.org.uk>
References: <cover.1701906455.git.soyer@irl.hu>
	 <21a183b5a08cb23b193af78d4b1114cc59419272.1701906455.git.soyer@irl.hu>
	 <0b836c10-b21b-4275-8dd0-254dd5467497@sirena.org.uk>
	 <47097f19398808b64f4cc87c2a3c7cc462fb2416.camel@irl.hu>
	 <5f3f0306-799f-4f3b-9e05-fbd300c59d5d@sirena.org.uk>
	 <b0ab21657f2e4f0825579de97ca012e294d1e743.camel@irl.hu>
	 <bf24488f-e4e1-4d3e-a67e-fe74c05acda4@sirena.org.uk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.2 (3.50.2-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2023-12-07 at 22:39 +0000, Mark Brown wrote:
> On Thu, Dec 07, 2023 at 10:12:13PM +0100, Gergo Koteles wrote:
> > On Thu, 2023-12-07 at 20:36 +0000, Mark Brown wrote:
>=20
> > > > And only one, because tasdevice_change_chn_book directly changes th=
e
> > > > address of i2c_client, so the unlucky one gets invalid values in it=
s
> > > > actual book from regcache_sync.
>=20
> > > The code creates the impression that writing to one tas2781 writes to
> > > all of them, is that not the case?
>=20
> > Yes, the tasdevice_* functions, but the regcache_sync doesn't know
> > this.
>=20
> So this syncing is done in software not hardware?  My understanding was
> that this was a hardware thing.

If you mean that the amplifier does not know that there are several
programs or configurations or profiles, but only runs the current one,
yes.

>=20
> > > How would the devices get their configuration restored?
>=20
> > tasdevice_tuning_switch calls tasdevice_select_tuningprm_cfg which
> > checks whether the devices needs a new program or configuration.
>=20
> > the runtime_suspend and system resume set the devices cur_prog,
> > cur_conf to -1.
>=20
> ...
>=20
> > The tas2781_hda_playback_hook calls the tasdevice_tuning_switch
>=20
> And there are no registers other than these programs?

The tas2781-hda writes 4 things:

1. Profiles from RCA file
eg. INT8866RCA2.bin has 4 profile:
Music degree 0
calibration
voice call
earpiece spk2 bypass

The profiles contain pre-power-up and pre-shutdown register+value
sequences for each amplifier.

2. Programs from DSP firmware.
eg. TAS2XXX3870.bin has 1 program:
Tuning Mode

3. Configurations from the DSP firmware.
eg. TAS2XXX3870.bin has 2 configurations:
configuration_Normal_Tuning Mode_48 KHz_s2_0
calibration_Tuning Mode_48 KHz_s2_0

Programs and configurations contain blocks with addresses where they
should be written.

4. Calibration data from EFI variables.
R0, INV_R0, R0LOW, POWER, TLIM,
Based on the chip, they should be written to 5 registers.

The code restores all of these in playback_hook, runtime_resume,
system_resume functions without regmap_cache_sync.