Received-SPF: pass (google.com: domain of linux-kernel+bounces-342-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <3bc7d3b5-7b15-4b14-ab2b-20968249818a@intel.com>
Date: Fri, 15 Dec 2023 10:27:15 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 15/39] mm/huge_memory: batch rmap operations in
 __split_huge_pmd_locked()
Content-Language: en-US
To: David Hildenbrand <david@redhat.com>, <linux-kernel@vger.kernel.org>
CC: <linux-mm@kvack.org>, Andrew Morton <akpm@linux-foundation.org>, "Matthew
 Wilcox (Oracle)" <willy@infradead.org>, Hugh Dickins <hughd@google.com>, Ryan
 Roberts <ryan.roberts@arm.com>, Mike Kravetz <mike.kravetz@oracle.com>,
	Muchun Song <muchun.song@linux.dev>, Peter Xu <peterx@redhat.com>
References: <20231211155652.131054-1-david@redhat.com>
 <20231211155652.131054-16-david@redhat.com>
From: "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <20231211155652.131054-16-david@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3NoS3FPejdDWWZ2MTJGdkI2ajYxTkN4VHF5QldPSTBqMnRrNG14dTFFS1g1?=
 =?utf-8?B?VVZibndRY1ZuS3cxNDR0SjZkekRhWHhxcDFoMTVOTWYxYjJ1OG9EdmdZekkw?=
 =?utf-8?B?OWMycGZQTzF0aG5laGEwemdpb0FtSDMrL0Z1K3ZmZ3BSd285WmNqQ1JIS0Iw?=
 =?utf-8?B?MUNCbnRFejBkek51dFFiOFpPRnFzclNHNUxOcHU3by9OY2Ewa3JXcGJValdZ?=
 =?utf-8?B?MGhPbWV6WEZ0Q3l3YzE1eXBTRFpKWXhGbkl2Y1V6b3JLdC9XSWRxaFdEdnZv?=
 =?utf-8?B?blZ4RUEyRzZLRGhhMVVaZkcxVmFqNFdxVmhiRGZTc1lEWXB4Rjk0QTJaRUVE?=
 =?utf-8?B?ZzB2cVY1SU1Xa0lMMU5Za0dram55UVlQYVZpdzNHNHd0S0JkTG1xS0dKMm8x?=
 =?utf-8?B?S3dFNDRLOFdOQ2lLRFYxNHU3OFdMR0xTUGZMR3hFN0I3akdiZDB0S2lFNDRK?=
 =?utf-8?B?aEdMYjBSSHFzYjVpMEgrSW5sYWhvREozUk1rWHpJN0xyM2E2bU12c1VSZnVE?=
 =?utf-8?B?V0tlZ2lqYkRUcWtUUGR1S01IdkRzRlNEOStUT2YvL0gxVFlCOWJDRVdmMVh4?=
 =?utf-8?B?WENkVlRJanhIVDlRNy9JbzcweFcyZGZOeEJLSTJCZmJ5QUozZkY5Yjhhc09U?=
 =?utf-8?B?dlkrbjMyY05LWFVuYjk3NWtXcHVGWnRyb0ZDV1E0YnhIazRTdE9iYUhxcE5o?=
 =?utf-8?B?Z3lXaHhVTGZvMERsOTNvckRXRVk5M25nVGZaMElqOTVhSXNzR0hiMkFUdCt0?=
 =?utf-8?B?b0xPemFueEl1di9YaHVWb01XNmxzREF6eEZuZzNaTEFJTlRCUnhMOTlSNGpl?=
 =?utf-8?B?S2VqTm1ldkZmdWlTK252RHJucVlhdVJxS1k5cmpPL0FYSTdnczhxZkZGRVJI?=
 =?utf-8?B?c3Y0VlJndDZDT3VRbFFhM3FlTkxmTDA5Q1BHNTB0MmluUkkya1RaYnp3WXY2?=
 =?utf-8?B?R3BSUHM0c2VOMzg0S0NrYXRXY2FZYWRjdUxYM0hoeElJaUQ1MjNTOTBXeTc3?=
 =?utf-8?B?YngzR1FmQmpRd3l1SHlzMzY5Q1dCeUVFUm1xOWFyWGwwc095Ym5XVldhSmsr?=
 =?utf-8?B?djJyYy93eG13OXQvUTZZaUR0Q2FETWNvTWlXMHpMYlJCK1BZam5lbFAvR2Uz?=
 =?utf-8?B?c1Y3cERXTjdBazVXV0dTRlZod3FBVGRENHZta2NsZ3E4RjJJWmZYQm9wVENN?=
 =?utf-8?B?U1AzUmMwWjR6bTRnY3Y5YUNQaS9HM2JYdFdFVldyWUpMa0NHV2Z2YTJSV24z?=
 =?utf-8?B?RnRLRXVZM0RscmRvaVVnb01wNDFhbGZYM3RLbUJpelhFTjQ2b0pmU3FYUlhZ?=
 =?utf-8?B?VkVXVnU4djgxejArREJFTFV2d2h1MVNFWGRiR1ZnTEoxSzVUNDNjb01naitR?=
 =?utf-8?B?T1RHdkRjZ2U2TnUwUVNBKzI5N0FoMlBzZ0pWSld1SVJnTnBLNW50UFFzbjkv?=
 =?utf-8?B?UktPY3lKdG9BdGYrVGpDcnBVbHJvdVoydmdobEJGSFpENytnRlhwZ2FJQmNv?=
 =?utf-8?B?bmtQdGsycTRKQmU0Z1ZkaXIwN2NhSnNseG94a0dtUmZpc1VEelg2OTRVblMr?=
 =?utf-8?B?ZG1WMG5RM1dOaElGM1Zqa0NtV2E3NnI3bEZwMmR1M2dBL0NudjVLdEduN0ps?=
 =?utf-8?B?UloyQmk3Zk5hU2VXSjdvQ2lXalFqOW1lV0dSVVRXVFFUSnJsUXFwb1BlQzA1?=
 =?utf-8?B?MHFPcVhXdnYrOEd0TkRMVTN2ckVTVmU3ZS9aQnZOYlIxeDNzNUlXR2piL09V?=
 =?utf-8?B?V3FGeXlaczJRUGtMbHFxKzBmWU0xY2ZJdjZkR21ENEFOcHNYY3ZTWEN1MzFS?=
 =?utf-8?B?QWlYcjJheGVWajFjSHRyUU9HbVlCQkhuLzBBOHBFa3JwRUVWNHIxYlcrRzJ6?=
 =?utf-8?B?OGdITDcwdFhXSHdUUlRYK2FaMVhVWlpXeWRwZHljUmQyYWZkaGJyaGMyOTRN?=
 =?utf-8?B?WVd2QVRJTDBPY1JCcGErQ1c1Z0VBUlhrZ2NnckN0bTNSNUczWGdtOFdpWU1P?=
 =?utf-8?B?T0VrWkZlQVZoQnNZNEtZdTRORkJVMW9aendYajFqS0p6bWQ2enBUb2k3RVVu?=
 =?utf-8?B?UFpYY0FKK1hTcHhieFBiL3VabDdHSHRtK3EyS003ZWlvNnZYbVdaNzE3NHU0?=
 =?utf-8?Q?vWopvejxGUcBUn3Cp21kCbT6E?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 99f97810-6d92-443c-c7e7-08dbfd155c11
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2023 02:27:18.6410
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QXa/vpR9M4W3jnxVvM0pE+ceSxCNVuNvNnbaI83XXqXCYhUjIqTho5FDbI8GR73s95tYWsNVmC+gwXwRpDITQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7017
X-OriginatorOrg: intel.com


On 12/11/2023 11:56 PM, David Hildenbrand wrote:
> Let's use folio_add_anon_rmap_ptes(), batching the rmap operations.
> 
> While at it, use more folio operations (but only in the code branch we're
> touching), use VM_WARN_ON_FOLIO(), and pass RMAP_EXCLUSIVE instead of
> manually setting PageAnonExclusive.
> 
> We should never see non-anon pages on that branch: otherwise, the
> existing page_add_anon_rmap() call would have been flawed already.
> 
> Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Yin Fengwei <fengwei.yin@intel.com>