Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6403036rdb; Thu, 14 Dec 2023 18:31:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IFpbIYI4WGLOubDeeOT9wNS2ChMS0A2EpeHBnNefncNMTxbv3ZWoVlDfankULvwOxFgzZdC X-Received: by 2002:ae9:e40c:0:b0:77f:3f35:745e with SMTP id q12-20020ae9e40c000000b0077f3f35745emr11845142qkc.142.1702607495496; Thu, 14 Dec 2023 18:31:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702607495; cv=none; d=google.com; s=arc-20160816; b=ghYvWXYEWSIVSLpZo5KnG8xKQLJKJX/kA8MrmWmgrKNOHBws1JBtLvCaXrAoD37u3S GlsRbobq4Oggam4zJUstvekoLu2VMdcEGefEEnm4V19C2p628dAZJAMjnLalq/t2UQEn 1VaJ6aOiIHM/ZkTXQWs60JPjqwBO5OyyYh2RnWQmsfyuHmHb+xgJgKVanfGQ7X2FWHkp V0QZguAG9ZDS/Jk7pylNo+2WHj7uotO837bABDgjR/jKhW/xrhV32Hy8Usiep9MCINYj upFSy/SUW/ndj5PlMgJK3EXOkzTS+boPuS0x6Xp5b7PklnsEm2x+CNS0DdIh4Stuc4L2 ijhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=ciWixoj9UkQ4OM79q9TQTfVlptETwuOYFH/B/dkuCYY=; fh=dmNdVz6ZGGN/12CZaEfJKX7NX3Vtx66H/XytJBPqYyI=; b=u1qcYun3U9CsvZyfDGtSRpGxn3ZAgSj9doEyAXDnWGIP9INJc9G4ehv15dca60XSAt C8Xh8ploAk3EemjDAdtJgtgba9N3thXOxoyYEyHQ27kp+f5U81oMiaZAuLJcao+4fgQv XWJ3M1JlWnv5tH+lMJF1LbknT1vMbpjniuvc9t8DixJoaPPzCZqTc8v0RUgRg6BYcaJK I/oGjRbI6j7q+hlFAjL9XQV0kEGqvMiVYU3JeHgorZlWyj1tX1j8y7MnvkBcrPd9X4zP MEW7bAVkaePVgCTj+hXWFXnN1C05QN9Mba7pz75WI8c8JP+Aq9e4SOUcBIM5VweN5KM9 OOhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dkpiwemH; spf=pass (google.com: domain of linux-kernel+bounces-348-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-348-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id h22-20020a05620a245600b0077d883cb7b1si13150894qkn.238.2023.12.14.18.31.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 18:31:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-348-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dkpiwemH; spf=pass (google.com: domain of linux-kernel+bounces-348-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-348-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 456FB1C221B5 for ; Fri, 15 Dec 2023 02:31:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B6CE0EBB; Fri, 15 Dec 2023 02:31:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dkpiwemH" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6421807; Fri, 15 Dec 2023 02:31:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 013BDC433C8; Fri, 15 Dec 2023 02:31:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702607485; bh=ciWixoj9UkQ4OM79q9TQTfVlptETwuOYFH/B/dkuCYY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dkpiwemHB5IMIhKteD/xK6e0viUDrWEqWFVcI0OIq8t2qRzen7Yn697y4UbkdBGL6 xlcfQaaJHL1he+q2VGdCvb2pnPTd633FVCGpx6uBskcZwX3ILKa4izDxfxlWy2pqQK 4AxNERUbcPqJKPxBKaMzNCst7+qjiNkOpCP1iv/JZIwd81sCOU66/chUzzrb6R3cMB rUSPHqAvW6kHZCdNDA1XqhOBpbp9MYj7xUL/VA6WVu5mJD+9xa0/Nyx694kJ5HpqcL 2UWbidQZP0YmOFmPGWkFaCQ7kGuoCIWku5jUYMQtMSWjcVH2aYgGbmVtRRshTBJvZx 53ewpzVLxTtag== Date: Thu, 14 Dec 2023 18:31:23 -0800 From: Jakub Kicinski To: Daniel Golle Cc: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: phy: skip LED triggers on PHYs on SFP modules Message-ID: <20231214183123.0f0af377@kernel.org> In-Reply-To: <102a9dce38bdf00215735d04cd4704458273ad9c.1702339354.git.daniel@makrotopia.org> References: <102a9dce38bdf00215735d04cd4704458273ad9c.1702339354.git.daniel@makrotopia.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 12 Dec 2023 00:05:35 +0000 Daniel Golle wrote: > Calling led_trigger_register() when attaching a PHY located on an SFP > module potentially (and practically) leads into a deadlock. > Fix this by not calling led_trigger_register() for PHYs localted on SFP > modules as such modules actually never got any LEDs. Any suggestion of a Fixes tag? Looks like the triggers were added a while back, are we only seeing it now because we started exercising the code more?