Received-SPF: pass (google.com: domain of linux-kernel+bounces-370-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <91288e11-0d92-4b69-b792-e83456e1752f@intel.com>
Date: Fri, 15 Dec 2023 10:39:38 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 15/39] mm/huge_memory: batch rmap operations in
 __split_huge_pmd_locked()
Content-Language: en-US
To: David Hildenbrand <david@redhat.com>, <linux-kernel@vger.kernel.org>
CC: <linux-mm@kvack.org>, Andrew Morton <akpm@linux-foundation.org>, "Matthew
 Wilcox (Oracle)" <willy@infradead.org>, Hugh Dickins <hughd@google.com>,
	"Ryan Roberts" <ryan.roberts@arm.com>, Mike Kravetz
	<mike.kravetz@oracle.com>, Muchun Song <muchun.song@linux.dev>, Peter Xu
	<peterx@redhat.com>
References: <20231211155652.131054-1-david@redhat.com>
 <20231211155652.131054-16-david@redhat.com>
From: "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <20231211155652.131054-16-david@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzU5RTZ6TFlZSXBxbG9TRHhMVlozUWRlRmFrTDk0VlR5MC9aa2xBcStjazc3?=
 =?utf-8?B?S1FjL3FoUHVoT2wvNzQxa0gvdkVDazVwZnk5K3UvckJvek1Nd0NnTnk0ZGNr?=
 =?utf-8?B?SmZ5RWlodFB2QURPZ1ppbWRIOUNYOUt6cjZzTHVGSHZtODQxT3JvN1VmZVly?=
 =?utf-8?B?V0xQSzRSUGpRSU1EUmZ6WFExR3BpWExFZWRjYkRHWTBzeW92ZnNGRyt4Y1Zh?=
 =?utf-8?B?OVhVd2cxbmo5Z2t1ZGFjT2ZzRmR4ak9HVVlpdHZuaTB5U0dUdUFJaXE3L3Bv?=
 =?utf-8?B?aXgwN0NNZy9wanRXRjJjNytLaDhHclNKQVd5Uk1sNGtvYkROWmtDOTVxcnNm?=
 =?utf-8?B?RnBZalBFcG8wd05KaSs5eE16Y2tEVU01Y3pNQVFxQ2VhbUlvK0RVTWE1UDJs?=
 =?utf-8?B?RWpjaGdVcVhBdEduVTNXU094R0RZSS90Z21BOWNhWXB1K1U0Q1FmU25LSEk0?=
 =?utf-8?B?UXd4THA1U25WTEhDZHMzWVh3aUwwQ2E0bjgvR0o5cEdxemdTODRpem83SkpD?=
 =?utf-8?B?dGlSd0w2MlcwaXlkQzhxNDFFeVBaYXhIODEwcnNDRnRhcC93enZlZU1IbEdy?=
 =?utf-8?B?OGJnREc2NDZFY1hidzdLK25ONU85YkhvRzBJZ21KdEFpQzVtdFpteEp1Wk5h?=
 =?utf-8?B?OHhudTYrT2lhTElEUDJ1MGF3WndsUFBrT1J4bmJaN2h6SlJXZldrMkM5WmtY?=
 =?utf-8?B?empnUEJFZTFCbGtnTXJORVJrWSs1Y3NaZmsxKzJIb3pNSFlOWFpUeUVtUHRt?=
 =?utf-8?B?OUs3UWFiOEJaNmRUQkJKV3h5UThUOENMaWpVN3BrY0lwb1BnMnpUc1B2Y1g3?=
 =?utf-8?B?Mldua0dlMmIvaHR4cnEvQ1U4WTY1enNMT1ZYQXNlLzJZUDh0YWJmbDRMcm4z?=
 =?utf-8?B?VDVKUUlUY2RESWZ2OU1nZzYydW9LVDBycU42Y1pPTVJwOFNTdVY0QUE4WFZk?=
 =?utf-8?B?ck9yZUlFbWdjZTZhcVlzVGZxcWJoYjBTWmhMbHJacXNST2VYMkp3YktTSWxj?=
 =?utf-8?B?UG0wdVRWUVFOQUFIMFRyd21vaTgyV096bG1mS1RQbWNYTFk5WkxBZmRNamJH?=
 =?utf-8?B?Uzk4K1BmSzBYeFVwWnd6MnZQQWlZWDNiTkN1eWwxbVFsazFvZW1PZksrSjZu?=
 =?utf-8?B?SkU4YS9qRDlvMjlkZVNxYXZ3cFNudmFrS0tNWlBBU2tGeTNzUjFZZVliNjNG?=
 =?utf-8?B?NlB1Q0V0NTFTcDRGUUZQMnpCUHJGZlNUVmZ6cnJXV0lNQzg1S2JnUFZuanZh?=
 =?utf-8?B?RFlDQXJPV0FTUW1IaHpIV1p6SkYvT1lPT1hVR1p1cktpU3I0aVJDRXB1dUVx?=
 =?utf-8?B?TnNxdjF1MDJzcnBuMWpJRDBucTNyNUUwSytOamlWOEphSjZzRzU5TmZ5bnR3?=
 =?utf-8?B?SDE0d2NYU3ZERWlnK24xcjBQMzI2MHBSSGF2dmVydUdUZnpyUUxhWkFzNmkz?=
 =?utf-8?B?cGtURFAwVzFhdzBST1FDU2pTVVFOZVJ1OStYZ280b2VvWTN4OE1NN21MWTZW?=
 =?utf-8?B?c1c1MU9zUWF3ZTV4eTJpc09CTWNFRVZLUXZwc1BvK2pGdDk2SHBxSHA4L0t2?=
 =?utf-8?B?VUNHYmE5QzhwTUd6NTZ0M3k5MThIeGxWekFCWktaRDUxNUV0S0d2dy9qZGZD?=
 =?utf-8?B?QkNJOEs0VDZiOFQvSGozbWtSUXFIdUxDSFg3RXdWTkh4dDdXVmVWb3dDTHZ0?=
 =?utf-8?B?dkQ2dFoxOFIzMS81dHE2djZTM1BkNGt3QkgyL1RHZ3RILzJicUtxbE1SR2h1?=
 =?utf-8?B?YVppUStuQXlJdGIrVjFjYWlFN1hFVjN4bjU0L0pJSndxT3J1R3hRVEU1S0FH?=
 =?utf-8?B?dWNialJWQ28rdHBTZjZVZm9UMTM1ZVg1VEZSaHNFdnhPM1V1bUxVTFMxUGRT?=
 =?utf-8?B?UGl3WDhNKzJlNnd5eUV2eDNYYkhhREptdVRYazI2c2JGTy82cmJSekhsRTFV?=
 =?utf-8?B?SE5ib094b0Jub0NIV1ZqS25XVmV1QjIvVUQ5U0pWQkU1WTFFZnhQcXJqVjRH?=
 =?utf-8?B?L0NSbjRQOEpYV0RrbE9MUE9Fazc1QUNNRzBES2RMRnp4cnNIZloyRXRyUzZP?=
 =?utf-8?B?d2xhM0VnMVJWZFhSL1k1RFd0M0xXVTkyYjBEVnpWZThsakZOaWtLTEsvQmgx?=
 =?utf-8?Q?qFIFch/2TTcGl/mukJTlVt1rw?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 94913a52-59fb-484c-091c-08dbfd171910
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2023 02:39:45.2077
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pADq+P9wY0vmSmMlMBMSzjjpuctBs1sN1YV5CNZIx8nPJC52ZrBkMDNE0XmfjJ8r90DKefERRNPV6/JVcg7Yyg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6931
X-OriginatorOrg: intel.com


On 12/11/2023 11:56 PM, David Hildenbrand wrote:
> Let's use folio_add_anon_rmap_ptes(), batching the rmap operations.
> 
> While at it, use more folio operations (but only in the code branch we're
> touching), use VM_WARN_ON_FOLIO(), and pass RMAP_EXCLUSIVE instead of
> manually setting PageAnonExclusive.
> 
> We should never see non-anon pages on that branch: otherwise, the
> existing page_add_anon_rmap() call would have been flawed already.
> 
> Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Yin Fengwei <fengwei.yin@intel.com>