Received-SPF: pass (google.com: domain of linux-kernel+bounces-387-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Nicolin Chen <nicolinc@nvidia.com>
CC: "Liu, Yi L" <yi.l.liu@intel.com>, "joro@8bytes.org" <joro@8bytes.org>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>, "jgg@nvidia.com"
	<jgg@nvidia.com>, "robin.murphy@arm.com" <robin.murphy@arm.com>,
	"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>, "cohuck@redhat.com"
	<cohuck@redhat.com>, "eric.auger@redhat.com" <eric.auger@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "mjrosato@linux.ibm.com"
	<mjrosato@linux.ibm.com>, "chao.p.peng@linux.intel.com"
	<chao.p.peng@linux.intel.com>, "yi.y.sun@linux.intel.com"
	<yi.y.sun@linux.intel.com>, "peterx@redhat.com" <peterx@redhat.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>, "lulu@redhat.com" <lulu@redhat.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "Duan,
 Zhenzhong" <zhenzhong.duan@intel.com>, "joao.m.martins@oracle.com"
	<joao.m.martins@oracle.com>, "Zeng, Xin" <xin.zeng@intel.com>, "Zhao, Yan Y"
	<yan.y.zhao@intel.com>
Subject: RE: [PATCH v7 1/3] iommufd: Add data structure for Intel VT-d stage-1
 cache invalidation
Thread-Topic: [PATCH v7 1/3] iommufd: Add data structure for Intel VT-d
 stage-1 cache invalidation
Thread-Index: AQHaGViOWXGe59nutU2rEx/0zRDvrrCozh6AgADg1VCAABsWAIAACKYA
Date: Fri, 15 Dec 2023 03:04:44 +0000
Message-ID: <BN9PR11MB52766D7F774510E0181CC89B8C93A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20231117131816.24359-1-yi.l.liu@intel.com>
 <20231117131816.24359-2-yi.l.liu@intel.com>
 <c967e716-9112-4d1a-b6f7-9a005e28202d@intel.com>
 <BN9PR11MB5276D14D2A7FF60B41A6A7B48C93A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZXu5whlIGfiq16wF@Asurada-Nvidia>
In-Reply-To: <ZXu5whlIGfiq16wF@Asurada-Nvidia>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4Wzd/B6rYhR5gWhFpbAj0BMTU3dG/URSzczeO5RTsuOYgew9JANfMQOSke2B?=
 =?us-ascii?Q?+zStQpGtW2UIopkRsPwj6788j/PMvxzD5Jnne8prWwcHLXgOOG8B+MLq8ZfK?=
 =?us-ascii?Q?ab00VILO79xJ56fLYyTE2GH0OQCNkw09JBJ4XTgtWCmMe4BzG5PNXlsoX18q?=
 =?us-ascii?Q?GCa4+fqSkKpDUKu0OFPm1WVtIwEQDse4kwrv2/vnzh8X7RskU22OL/A8N1UY?=
 =?us-ascii?Q?PUPPp9lsGbr00rpF18XiGM8F7geK6gGGttcUNJDRD2iLPDu6qpTtuH41p7lx?=
 =?us-ascii?Q?3xEs2Vh6GmIk2GXJJdkBcrEce5liy2w/VCGkABgJHZEmfXUvaCTJgSNVwCEI?=
 =?us-ascii?Q?M6rsD1KE47p5LVBDGZpdnJ9lKyaswnu6+FM4P0LTtVCqp2eeBEsEs7myh+1N?=
 =?us-ascii?Q?XM/V2bN5GQ9oTZ9I7MyCqL7LZvbLDtVaHdqL0znf9RHdvmwgn2l5sJpT8HxH?=
 =?us-ascii?Q?5FZmsu7MhFZiwvM3fZODAxneEG5/cyuoQNtvDXYoypxlr49P4P1/W8Xf1WYE?=
 =?us-ascii?Q?QSE9K6Q+/BvieHbrTuX1vjadkU3AgKM2Tj2yn1xZPJshRZ5cX/3LPW3HHgHV?=
 =?us-ascii?Q?wU7OomTXFcCxkFFZsluIB0pxo7VXi1uSI2a0XZow4AbAtfLHKuIIdE7P7/NV?=
 =?us-ascii?Q?oPzMAfXBW+G258M6bWc1HEmV3gUdBnydsLHJRZ6E/4yPw3Ak4eFAimLTdhMh?=
 =?us-ascii?Q?3g1GpoOn/O+vd9/XfLynIYsjxRK7od3fXIGgeAUItII8a55k7YTj8dFsiZ0c?=
 =?us-ascii?Q?RT7rehAK8xKh/75O+GTVfxyUSKriSpOhyvnuJnXZDM+8HDBXUQGlq4rjI1Ym?=
 =?us-ascii?Q?Qrv8yMU+m96WcvjddHmk8vN5tAd9PNx4Ww9PFmwyJV/NiDMdmzwudtajm+cg?=
 =?us-ascii?Q?f0dTfAzOASejy0yEAOwlF0bZ5O8A7FhiQmDuN8G4FiUFfhkyzNczZrLNZWUI?=
 =?us-ascii?Q?ownre3vrf5ZNgsX4EW8INJo8s0Qyv1MszGPMPdy+xjyDeteOHfBzBta+ALAS?=
 =?us-ascii?Q?pchSk7tQCiUgpQstd/Goo18xT15l5GYIrxcOUy07ib33pD844ipJ3rN8mIkD?=
 =?us-ascii?Q?Es8cqDhIGAWZU71utL5LjFIBPXIz5l3dsMkANS0w/YEl3KsfscZr5VebeRCH?=
 =?us-ascii?Q?subdokBwMuuQt7dOEQA302sn60vycqLtXi6J70NXNu0QbpXOmLBMrwBX+Z+c?=
 =?us-ascii?Q?BIbwNrVEEvUkR26vEoWs58PMH1NjQidUKoqBPd1Dl6NIdo5Pn4DP/wBMqWUh?=
 =?us-ascii?Q?DSHS4QdV48sK5+DKcXjhRcv5VmHm+o1pLBEMlTulQCnQr+CxP0tkt00KlrXm?=
 =?us-ascii?Q?o9/t5xehv7bAWf2PoOq4jcIAxHsERUS9gVOYxqsXWWsS94B8SKmBH1s/WN0n?=
 =?us-ascii?Q?DHFDcJ7/do/fq5vjbYZ6Anc9z3f7p/b6W/BdaCQAyDlROmBuj0mhR4ejnD7q?=
 =?us-ascii?Q?PKBjHdZJ47zUGjSRC0D26GHmEeIwDxFuzG+NxMuh3zYEUxi4fgxHT97owbbz?=
 =?us-ascii?Q?d0mWDGD/k0HBnz3Ms7ZPqAax9zBGesboStr91yLNRwfysrCdNKH5wgJ0bHFc?=
 =?us-ascii?Q?jw2yTixACqOZy0GmvxxfFrscqR8Fop7wWsiU7P55?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 203547f1-4042-4605-f086-08dbfd1a970e
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2023 03:04:44.8175
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: w8ZSgUJV7fu0SV87ho/yZHROlNixuPnrFvAJegnvvVzO3TPbxsrwKOCG52h9TtELrcu4Q3wN6sLFcaGDtxRwZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR11MB8753
X-OriginatorOrg: intel.com

> From: Nicolin Chen <nicolinc@nvidia.com>
> Sent: Friday, December 15, 2023 10:28 AM
>=20
> On Fri, Dec 15, 2023 at 01:50:07AM +0000, Tian, Kevin wrote:
> > > From: Liu, Yi L <yi.l.liu@intel.com>
> > > Sent: Thursday, December 14, 2023 7:27 PM
> > >
> > > On 2023/11/17 21:18, Yi Liu wrote:> This adds the data structure for
> > > flushing iotlb for the nested domain
> > >
> > > +struct iommu_hwpt_vtd_s1_invalidate {
> > > +     __aligned_u64 addr;
> > > +     __aligned_u64 npages;
> > > +     __u32 flags;
> > > +     __u32 __reserved;
> > > +     __u32 error;
> > > +     __u32 dev_id;
> > > +};
> > >
> > > dev_id is used to report the failed device, userspace should be able =
to
> map
> > > it to a vRID, and inject it to VM as part of ITE/ICE error.
> > >
> > > However, I got a problem when trying to get dev_id in cache invalidat=
ion
> > > path, since this is filled in intel iommu driver. Seems like there is=
 no
> > > good way for it. I've below alternatives to move forward, wish you ha=
ve
> > > a look.
>=20
> > >
> > > - Reuse Nicolin's vRID->pRID mapping. If thevRID->pRID mapping is
> > > maintained, then intel iommu can report a vRID back to user. But inte=
l
> > > iommu driver does not have viommu context, no place to hold the vRID-
> > > >pRID
> > > mapping. TBH. It may require other reasons to introduce it other than=
 the
> > > error reporting need. Anyhow, this requires more thinking and also ha=
s
> > > dependency even if it is doable in intel side.
> >
> > this sounds like a cleaner way to inject knowledge which iommu driver
> > requires to find out the user tag. but yes it's a bit weird to introduc=
e
> > viommu awareness in intel iommu driver when there is no such thing
> > in real hardware.
>=20
> I think a viommu is defined more like a software object representing
> the virtual IOMMU in a VM. Since VT-d has a vIOMMU in a nesting case,
> there could be an object for it too?

for VT-d it's not necessary to maintain such vIOMMU awareness in
the kernel (before this error reporting case) given its interfaces are
simply around hwpt's. there is no vIOMMU-scope operation provided
by intel-iommu driver so far.

>=20
> > and for this error reporting case what we actually require is the
> > reverse map i.e. pRID->vRID. Not sure whether we can leverage the
> > same RID mapping uAPI as for ARM/AMD but ignore viommu_id
> > and then store vRID under device_domain_info. a bit tricky on
> > life cycle management and also incompatible with SIOV...
>=20
> One thing that I am not very clear here: since both vRID and dev_id
> are given by the VMM, shouldn't it already know the mapping if the
> point is to translate (pRID->)dev_id->vRID?
>=20

it's true for current Qemu.

but there is plan to support Qemu accepting a fd passed by Libvirt.
In that case Qemu even doesn't see the sysfs path hence is not
aware of pRID. otherwise yes we could leave the translation to
VMM instead.