Received-SPF: pass (google.com: domain of linux-kernel+bounces-438-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "<Tree Davies" <tdavies@darkphysics.net>
Date: Thu, 14 Dec 2023 21:06:04 -0800
To: Nathan DSilva <expitau@gmail.com>
Cc: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com,
	tdavies@darkphysics.net, kamrankhadijadj@gmail.com,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: Add blank line after declarations
Message-ID: <ZXvevJ2vEEQ92rau@oatmeal.darkphysics>
References: <20231215032852.501316-1-expitau@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231215032852.501316-1-expitau@gmail.com>

On Fri, Dec 15, 2023 at 03:28:52AM +0000, Nathan DSilva wrote:
> Found using checkpatch, removes one warning about line breaks after
> declarations.
> 
> This is my first patch, feedback is welcome. I am submitting this as a test
> before moving to other subsystems to (hopefully) make more meaningful
> contributions.
> 
> Signed-off-by: Nathan DSilva <expitau@gmail.com>
> ---
>  drivers/staging/rtl8192e/rtllib_rx.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
> index ecaa4dec3f94..397859c7f5b1 100644
> --- a/drivers/staging/rtl8192e/rtllib_rx.c
> +++ b/drivers/staging/rtl8192e/rtllib_rx.c
> @@ -946,6 +946,7 @@ static int rtllib_rx_data_filter(struct rtllib_device *ieee, struct ieee80211_hd
>  {
>  	u8 type, stype;
>  	u16 fc = le16_to_cpu(hdr->frame_control);
> +
>  	type = WLAN_FC_GET_TYPE(fc);
>  	stype = WLAN_FC_GET_STYPE(fc);
>  
> -- 
> 2.43.0

Hi Nathan,

Thanks for your patch, but here are few comments.

1. Your subject line looks good. Keep it.

2. Your commit message should read something like.. 'Do x to fix Y'.
There are lots of examples in the log for this driver which demonstrates this.
You don't want 'This is first patch' in the commit log.

3. For this driver, it is best to send your patches to Greg, Philipp Hortmann,
and Dan Carpenter (error27@gmail.com) looks at them sometimes too. And like you
did, cc the mailing lists.

For example, My setup usually looks like...
git send-email ./patches/*  --to=gregkh@linuxfoundation.org --to=philipp.g.hortmann@gmail.com --to=anjan@momi.ca  --cc=linux-staging@lists.linux.dev --cc=linux-kernel@vger.kernel.org

A good source of info for sending patches can be foound here:
at https://docs.kernel.org/process/submitting-patches.html
and also there is a free tutorial at:
https://trainingportal.linuxfoundation.org/courses/a-beginners-guide-to-linux-kernel-development-lfd103

I'm a newbie myself, but I'm happy to help.
Cheers
Tree